Re: [gentoo-portage-dev] [PATCH eapi6-pt2 v2 3/6] Add sandbox directory removal functions for EAPI 7

2018-03-09 Thread Ulrich Mueller
> On Fri, 9 Mar 2018, Michał Górny wrote: > @@ -154,6 +165,12 @@ addread(){ __sb_append_var READ"$@" ; } > addwrite() { __sb_append_var WRITE "$@" ; } > adddeny(){ __sb_append_var DENY"$@" ; } > addpredict() { __sb_append_var PREDICT "$@" ; } > +if

Re: [gentoo-portage-dev] [PATCH eapi6-pt2 v2 2/6] nonfatal: Implement fallback executable for EAPI 7

2018-03-09 Thread Ulrich Mueller
> On Fri, 9 Mar 2018, Michał Górny wrote: > +if ! ___eapi_has_nonfatal_as_executable; then > + die "${0##*/} not supported as fallback helper in this EAPI" > +fi Nothing wrong with this, but this test isn't strictly necessary. PMS says in [1]: "Except where otherwise noted, they may be