Re: [gentoo-portage-dev] use* cleanup

2007-11-02 Thread Marijn Schouten (hkBst)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mike Frysinger wrote: > On Thursday 01 November 2007, Marijn Schouten (hkBst) wrote: >> Mike Frysinger wrote: >>> On Wednesday 31 October 2007, Marijn Schouten (hkBst) wrote: The immediate motivation of my examining this code was a request on

Re: [gentoo-portage-dev] use* cleanup

2007-11-01 Thread Mike Frysinger
On Thursday 01 November 2007, Marijn Schouten (hkBst) wrote: > Mike Frysinger wrote: > > On Wednesday 31 October 2007, Marijn Schouten (hkBst) wrote: > >> The immediate motivation of my examining this code was a request on > >> #gentoo-dev-help by lack for something which I could with my new code >

Re: [gentoo-portage-dev] use* cleanup

2007-11-01 Thread Mike Frysinger
On Thursday 01 November 2007, Marijn Schouten (hkBst) wrote: > Zlin found yet another bug. Since echo "" will output a newline my current > proposed implementation of useq won't be quiet. sounds like we should have a testsuite in portage to make sure the misc variants are operating as expected -m

Re: [gentoo-portage-dev] use* cleanup

2007-11-01 Thread Marijn Schouten (hkBst)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Marijn Schouten (hkBst) wrote: Zlin found yet another bug. Since echo "" will output a newline my current proposed implementation of useq won't be quiet. > _use() { > local flag=$1 > local string_success=$2 > local string_failure=$3 >

Re: [gentoo-portage-dev] use* cleanup

2007-11-01 Thread Marijn Schouten (hkBst)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Marijn Schouten (hkBst) wrote: > In gambit I used: > > econf $(if use static; then echo --disable-shared; else echo --enable-shared; > fi) \ > > could become: > > econf $(_use static --disable-shared --enable-shared) \ as zlin rightly pointed out o

Re: [gentoo-portage-dev] use* cleanup

2007-11-01 Thread Marijn Schouten (hkBst)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mike Frysinger wrote: > On Wednesday 31 October 2007, Marijn Schouten (hkBst) wrote: >> I hope this is just an artifact of the patch being a bit opaque. The >> inconsistent indentation in the patch is a consequence of emacs bash mode >> using a differe

Re: [gentoo-portage-dev] use* cleanup

2007-10-31 Thread Mike Frysinger
On Wednesday 31 October 2007, Marijn Schouten (hkBst) wrote: > I hope this is just an artifact of the patch being a bit opaque. The > inconsistent indentation in the patch is a consequence of emacs bash mode > using a different indentation style than (I guess) vi(m). I'm sure even in > vi you can r

Re: [gentoo-portage-dev] use* cleanup

2007-10-31 Thread Marijn Schouten (hkBst)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mike Frysinger wrote: > On Tuesday 30 October 2007, Marijn Schouten (hkBst) wrote: >> The purpose of this patch is to expose a generic function, namely _use, >> which can be used to build your own use* variant if you need that. I >> reimplemented all o

Re: [gentoo-portage-dev] use* cleanup

2007-10-30 Thread Mike Frysinger
On Tuesday 30 October 2007, Marijn Schouten (hkBst) wrote: > The purpose of this patch is to expose a generic function, namely _use, > which can be used to build your own use* variant if you need that. I > reimplemented all other current use function using _use (and _if) to cut > out duplicate and

Re: [gentoo-portage-dev] use* cleanup

2007-10-30 Thread Mike Frysinger
On Tuesday 30 October 2007, Marius Mauch wrote: > On Tue, 30 Oct 2007 19:32:52 +0100 > > "Marijn Schouten (hkBst)" <[EMAIL PROTECTED]> wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > The purpose of this patch is to expose a generic function, namely > > _use, which can be used t

Re: [gentoo-portage-dev] use* cleanup

2007-10-30 Thread Marius Mauch
On Tue, 30 Oct 2007 19:32:52 +0100 "Marijn Schouten (hkBst)" <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > The purpose of this patch is to expose a generic function, namely > _use, which can be used to build your own use* variant if you need > that. I reimplemen

[gentoo-portage-dev] use* cleanup

2007-10-30 Thread Marijn Schouten (hkBst)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The purpose of this patch is to expose a generic function, namely _use, which can be used to build your own use* variant if you need that. I reimplemented all other current use function using _use (and _if) to cut out duplicate and verbose code. Commen