Re: [geos-devel] 3.10.0rc1

2021-10-14 Thread Joris Van den Bossche
I was looking at our tests we run in PyGEOS with the main branch of GEOS, and noticed one issue I wanted to check with the GEOS developers (the other failures seem to be issues to fix in our tests, https://github.com/pygeos/pygeos/issues/233#issuecomment-943773401). The GEOSGeom_setPrecision

Re: [geos-devel] cmake detailed comments

2021-10-14 Thread Paul Ramsey
There's a lot of new libraries and projects using cmake, even the venerable gdal is heading that way, and that's a hard conversion. Talks in the postgres world also swirl around that change. I think getting comfortable with it, takes a while I know, is probably going to be more effecitive,

Re: [geos-devel] cmake detailed comments

2021-10-14 Thread Sandro Santilli
On Thu, Oct 14, 2021 at 10:02:03AM -0400, Greg Troxel wrote: > Stepping back from just thinking about geos, in the context of a > packaging system, there is a desire to do things in a way that works in > the general case, rather than tightly adapating to particular systems. Would a script like

Re: [geos-devel] 3.10.0rc1

2021-10-14 Thread Paul Ramsey
I have pushed a couple small tweaks for this in ec7f996bc It's just rounding off regression results to avoid differences at the 14th digit, there's nothing important changing under the covers. P. > On Oct 14, 2021, at 11:27 AM, Sebastiaan Couwenberg > wrote: > > Has postgis already been

Re: [geos-devel] 3.10.0rc1

2021-10-14 Thread Sebastiaan Couwenberg
Has postgis already been updated for geos 3.10? 3.1.4 has some test failures with it: https://ci.debian.net/data/autopkgtest/unstable/amd64/p/postgis/15944629/log.gz https://ci.debian.net/data/autopkgtest/unstable/arm64/p/postgis/15944881/log.gz Kind Regards, Bas -- GPG Key ID:

Re: [geos-devel] 3.10.0rc1

2021-10-14 Thread Jeff McKenna
Building fine on Visual Studio for the MapServer Windows community. (the only gotchya was that the RC1 link provided was http which failed to download, so https link came to the rescue. (also, thanks for including .editorconfig in the archive, as if I remember correctly I always had to go

Re: [geos-devel] cmake detailed comments

2021-10-14 Thread Greg Troxel
Sandro Santilli writes: > On Wed, Oct 13, 2021 at 03:41:30PM -0700, Paul Ramsey wrote: >> Actually searching for "RPATH" here turns up all kinds of knobs if you want >> different things done to rpath >> >> https://cmake.org/cmake/help/latest/manual/cmake-variables.7.html > > Greg might be

Re: [geos-devel] cmake detailed comments

2021-10-14 Thread Greg Troxel
I am guessing that this script is not doing anything to set RPATH and that FreeBSD puts /usr/local/lib in the default linker path. Which is interesting because people that build things not from ports might get ports libraries linked without asking for that prefix - but that's a system

Re: [geos-devel] cmake detailed comments

2021-10-14 Thread Greg Troxel
Sandro Santilli writes: > On Wed, Oct 13, 2021 at 12:08:50PM -0400, Greg Troxel wrote: >> >> Sandro Santilli writes: >> >> > What do you mean by "I like how our tests work now" ? How do they work >> > for you ? Are them guaranteed to be using the *just_built* (rather >> > than the