Re: [geos-devel] PR for new GeometryFixer API

2021-04-20 Thread Paul Ramsey
I've changed the CAPI, this kind of follows Dan's suggestion for an optional signature that can encompass all the behaviours, while leaving the no-parameters default in place. https://github.com/libgeos/geos/pull/433/files#diff-cbedc388a4d6d798494e26f51269040e8131b7c3e610b4fb4a792aee4b27e83eR12

Re: [geos-devel] PR for new GeometryFixer API

2021-04-19 Thread Even Rouault
Hi Paul, no impact for GDAL test suite. It tests MakeValid() in a very light way (using mostly the "hourglass" looking invalid polygon) Even Le 19/04/2021 à 22:44, Paul Ramsey a écrit : Important question for downstream maintainers: how wedded are you to current 'makevalid' output? If you ha

Re: [geos-devel] PR for new GeometryFixer API

2021-04-19 Thread Paul Ramsey
Important question for downstream maintainers: how wedded are you to current 'makevalid' output? If you have tests of 'makevalid' right now, and we replaced the default behaviour with the GeometryFixer, you'd get different looking (valid) results. https://github.com/libgeos/geos/pull/433#issuecomm

[geos-devel] PR for new GeometryFixer API

2021-04-16 Thread Martin Davis
JTS recently had a class called GeometryFixer added. The class provides functionality to accept any invalid geometry and convert it to a valid one. This plugs a noticeable gap in the JTS API! Paul R has ported this to GEOS: https://github.com/libgeos/geos/pull/433 It performs a similar functio