Re: [Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

2013-05-27 Thread Ben Caradoc-Davies
+1. Good analysis of the problem. My one concern is that this change might introduce some interesting new thread-local leaks, either security or plain unanticipated thread interactions. Would you consider leaving this on master for a month before backporting? Kind regards, Ben. On 27/05/13 22

Re: [Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

2013-05-27 Thread Justin Deoliveira
Looks good to me. +1 On Mon, May 27, 2013 at 4:37 PM, Phil Scadden wrote: > +0. While I am all for the bug being fixed, I dont think I can comment > usefully on the efficacy of the proposed solution. > > Notice: This email and any attachments are confidential. > If received in error please dest

Re: [Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

2013-05-27 Thread Phil Scadden
+0. While I am all for the bug being fixed, I dont think I can comment usefully on the efficacy of the proposed solution. Notice: This email and any attachments are confidential. If received in error please destroy and immediately notify us. Do not copy or disclose the contents. ---

Re: [Geoserver-devel] A (toy) datastore based on catalog contents

2013-05-27 Thread Chris Holmes
Yeah, very cool. And yeah, I hadn't thought of that, but could be a cool GeoNode feature - be able to see a map of all the holdings on that GeoNode. A visual catalog that can be queried. Could also be cool to have it on the root geoserver web page as an openlayers map - give people a quick overvie

Re: [Geoserver-devel] Chrome and not working save buttions (GEOS-5754)

2013-05-27 Thread Justin Deoliveira
Just tried on chrome, safari, and firefox. All working. Nice work on this fix. On Sat, May 25, 2013 at 10:48 AM, Andrea Aime wrote: > On Sat, May 25, 2013 at 6:28 PM, Andrea Aime > wrote: > >> Overall seems a step in the right direction, at least the main submit >> button works now... >> Going

Re: [Geoserver-devel] A (toy) datastore based on catalog contents

2013-05-27 Thread Justin Deoliveira
Very cool! I could see this being very interesting for projects like geonode that are focused on more on the sharing aspect of data from different geoservers. On Sun, May 26, 2013 at 4:54 PM, Phil Scadden wrote: > Fun! Interesting to see with a different catalog. > > Notice: This email and an

Re: [Geoserver-devel] ModiifcationProxy does not prevent changes to collection mutable items

2013-05-27 Thread Justin Deoliveira
Sorry, i meant to reply, not sure what happened. Proceed as you see fit but i'll suggest one more thing. We could use cglib to proxy for the classes. Afaik cglib is already a runtime dependency for GeoServer as its required by wicket, and i think spring. The proxy interface (MethodInterceptor) is

Re: [Geoserver-devel] WMS 1.3 cascading broken, how to test so that it does not happen again

2013-05-27 Thread Justin Deoliveira
Works for me. On Sat, May 25, 2013 at 3:54 AM, Andrea Aime wrote: > On Tue, May 21, 2013 at 2:34 PM, Justin Deoliveira > wrote: > >> I agree mocking would be the ideal approach. Can you be more specific >> about the issues in resourcepool? Imo an ugly hack, as long as its not >> spread out in t

Re: [Geoserver-devel] Allow templates for GetFeatureInfo HTML output to use request env values

2013-05-27 Thread Mauro Bartolomeoli
2013/5/25 Andrea Aime > On Sat, May 25, 2013 at 3:00 PM, Mauro Bartolomeoli < > mauro.bartolome...@geo-solutions.it> wrote: > >> Yes. I think this is a good idea. I only see one caveat: at the >> Dispatcher level I think parameters are available only in string form >> (correct me if I am wrong),

[Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

2013-05-27 Thread Andrea Aime
Hi, following up today's meeting I've put together a quick proposal for the machinery needed to fix http://jira.codehaus.org/browse/GEOS-5370 : http://geoserver.org/display/GEOS/GSIP+96+-+Machinery+to+pass+thread+locals+down+in+thread+pools Feedback and votes welcomed :-) Cheers Andrea -- == G

[Geoserver-devel] Searchable archive reachable from ml page

2013-05-27 Thread Andrea Aime
Hi, following up Jody's observation about uDig mailing list page having a search box allowing a direct search on the archives, I added similar ones on the GeoServer ml page: http://geoserver.org/display/GEOS/Mailing+Lists This way people can get an immediate search option as they are looking for i

[Geoserver-devel] GeoTools / GeoServer Meeting 2013-05-27

2013-05-27 Thread Ben.Caradoc-Davies
GeoTools / GeoServer Meeting 2013-05-27 === Attending - Andrea Aime Ben Caradoc-Davies Jody Garnett Justin Deoliveira Jukka Rahkonen Agenda -- * FOSS4G NA * Passing thread locals in thread pools * Arc support in GeoTools * GeoTools change prop

[Geoserver-devel] [jira] (GEOS-5826) Allow access to request parameters from HTML GetFeatureInfo content.ftl templates

2013-05-27 Thread Mauro Bartolomeoli (JIRA)
Mauro Bar

[Geoserver-devel] [Hudson] Build failed in Hudson: cite-wfs-1.0-master #839

2013-05-27 Thread Hudson
See -- [...truncated 103354 lines...] [exec]Test wfs:test1.0.0-basic-getfeature-filter-spatialoperators-dwithin-get-9 (wfs-1.0.0/d41e2657_1) Failed [exec]Test wfs:test1.0.0-

[Geoserver-devel] Making the dimension's default value configurable

2013-05-27 Thread Andrea Aime
Hi, right now DimensionInfo and the code handling dimensions uses dimensions values which are dependent on the data type: * for time it's "current" * for elevation is the minimum * for custom dimensions it's the first value in the list We would like to have this user configurable instead, with the

[Geoserver-devel] [Hudson] Build failed in Hudson: cite-wfs-1.0-2.3.x #114

2013-05-27 Thread Hudson
See -- [...truncated 103281 lines...] [exec]Test wfs:test1.0.0-basic-getfeature-filter-spatialoperators-dwithin-get-9 (wfs-1.0.0/d41e2657_1) Failed [exec]Test wfs:test1.0.0-b

[Geoserver-devel] Backport WFS metadata links support to 2.3.x

2013-05-27 Thread Andrea Aime
Hi, a couple of months ago I've committed on trunk a patch for http://jira.codehaus.org/browse/GEOS-3387 which adds metadata links support for WFS as well. The diff is here: https://github.com/geoserver/geoserver/commit/8524d26e1951973b9cd7cf3018fa80b2e1178c77 The patch has been sitting there for

[Geoserver-devel] [Hudson] Build failed in Hudson: cite-wfs-1.0 #1098

2013-05-27 Thread Hudson
See -- [...truncated 103384 lines...] [exec]Test wfs:test1.0.0-basic-getfeature-filter-spatialoperators-dwithin-get-9 (wfs-1.0.0/d41e2657_1) Failed [exec]Test wfs:test1.0.0-basic-