Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-07-10 Thread Jody Garnett
Thanks! -- Jody Garnett On 10 July 2015 at 13:52, Torben Barsballe wrote: > This has been sitting on master without issue for over a month, so I am > going to backport to the 2.7.x branch. > > Torben. > > On Thu, May 14, 2015 at 6:16 AM, Andrea Aime > wrote: > >> On Thu, May 14, 2015 at 3:13 P

Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-07-10 Thread Torben Barsballe
This has been sitting on master without issue for over a month, so I am going to backport to the 2.7.x branch. Torben. On Thu, May 14, 2015 at 6:16 AM, Andrea Aime wrote: > On Thu, May 14, 2015 at 3:13 PM, Andrea Aime > wrote: > >> As you said, if we accumulate too many of these large requests

Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-05-14 Thread Andrea Aime
On Thu, May 14, 2015 at 3:13 PM, Andrea Aime wrote: > As you said, if we accumulate too many of these large requests waiting to > stop in the background, it will kill the server, > and make control-flow useless (as it will think those requests are still > running). > Typo there, I meant, it will

Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-05-14 Thread Andrea Aime
On Wed, May 13, 2015 at 1:09 AM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: > I have moved my prototype implementation of a timeout format option into > GeoServer as part of the RenderedImageMapOutputFormat. (Pull Request here: > https://github.com/geoserver/geoserver/pull/1055 ). > >

Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-05-14 Thread Andrea Aime
On Wed, May 13, 2015 at 11:54 PM, Jody Garnett wrote: > Well I like the creativity behind > "EXCEPTIONS=application/vnd.gs.wms_partial" (vs > "EXCEPTIONS=application/vnd.ogc.se_blank"). > > I am tempted to call it vnd.gs.se_partial so it is clear it is still a > service exception. What is the HTT

Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-05-13 Thread Torben Barsballe
As with all other service exceptions, the return code is HTTP 200. I agree that this is suboptimal. I am fine with vnd.gs.se_partial if you think that is better, I went with vnd.gs.wms_partial because this Exception format is only valid for WMS requests, wherease we can get ServiceExceptions from

Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-05-13 Thread Jody Garnett
Well I like the creativity behind "EXCEPTIONS=application/vnd.gs.wms_partial" (vs "EXCEPTIONS=application/vnd.ogc.se_blank"). I am tempted to call it vnd.gs.se_partial so it is clear it is still a service exception. What is the HTTP status code when returning this partial image? One thing I do no

Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-05-13 Thread Torben Barsballe
I have now added a new WMS exception format ( EXCEPTIONS=application/vnd.gs.wms_partial) to return a partial image in the case a getMap request throws an exception while rendering. Exceptions of this format extends ServiceException to store the rendered WebMap inside the exception. Also added docu

Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-05-13 Thread Torben Barsballe
> I am currently getting two test failures that I cannot explain: > > Failed tests: > testParameterizedStyle(org.geoserver.wms.featureinfo.GetFeatureInfoJSONTest): > expected:<[1]> but was:<[0]> > > testParameterizedStyle(org.geoserver.wms.wms_1_1_1.GetFeatureInfoTest): > expected:<[1]> but was:<[0

Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-05-12 Thread Torben Barsballe
I have moved my prototype implementation of a timeout format option into GeoServer as part of the RenderedImageMapOutputFormat. (Pull Request here: https://github.com/geoserver/geoserver/pull/1055 ). Changes: - Added a "timeout" format option to the RenderedImageMapOutputFormat. Allows user

Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-04-17 Thread Torben Barsballe
Yes, the code I am writing uses the minimum of the two, as long as both are nonzero. Torben On Fri, Apr 17, 2015 at 9:12 AM, Andrea Aime wrote: > On Fri, Apr 17, 2015 at 6:05 PM, Torben Barsballe < > tbarsba...@boundlessgeo.com> wrote: > >> Hello, >> >> I propose to add a format parameter (form

Re: [Geoserver-devel] Add a WMS GetMap timeout option

2015-04-17 Thread Andrea Aime
On Fri, Apr 17, 2015 at 6:05 PM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: > Hello, > > I propose to add a format parameter (format_options=timeout:) to > the WMS RenderedImageMapOutputFormat that allows users to specify a timeout > on individual requests (As opposed to the global WMS

[Geoserver-devel] Add a WMS GetMap timeout option

2015-04-17 Thread Torben Barsballe
Hello, I propose to add a format parameter (format_options=timeout:) to the WMS RenderedImageMapOutputFormat that allows users to specify a timeout on individual requests (As opposed to the global WMS configuration *maxRenderingTime *option. In conjunction with this, I would like to add an except