Hi Andrea,
Thanks for the pointer. I've updated my PR with a unit test. I worked
to make it a bit more general so that additional FeatureCollection +
Visitor combinations could be tested in one place.
Cheers,
Jim
On 06/10/2018 02:23 AM, Andrea Aime wrote:
Hi Jim,
testing delegation work
Thanks Jim, that addresses the main problem. However, I'm worried that
the override of size() is going to cause performance issues. I was under
the impression that returning -1 is a valid response to size(), and that
seemed to be confirmed by Jody in the original PR
(https://github.com/geoserve
Hi Jim,
testing delegation works is not so hard, see this test class for an example:
https://github.com/geotools/geotools/blob/865cc72a90b07841a4c871d1b07fcc8e5defd35b/modules/library/main/src/test/java/org/geotools/data/crs/ReprojectFeatureResultsTest.java#L43
Cheers
Andrea
On Fri, Jun 8, 2018
Hi Andrea,
I tossed up a PR here: https://github.com/geoserver/geoserver/pull/2905
with a ticket https://osgeo-org.atlassian.net/browse/GEOS-8779.
I am not seeing a quick way to provide a unit test. If you (or anyone)
has a suggestion on that front, I'm happy to include one.
Cheers,
Jim
Hi Jim,
yes, properly implemented collection wrappers should allow delegation
Cheers
Andrea
On Fri, Jun 8, 2018 at 6:47 PM, Jim Hughes wrote:
> Andrea,
>
> Thanks for helping the PR through.
>
> I haven't tested out the first case completely. I've definitely run into
> the issue that Alvaro is
Andrea,
Thanks for helping the PR through.
I haven't tested out the first case completely. I've definitely run
into the issue that Alvaro is trying to address with WFS 2.0.
In the short term, is allowing the FC to delegate reasonable?
Cheers,
Jim
On 06/08/2018 12:07 PM, Andrea Aime wrote:
Ah,
that change was controversial and the pull request sat there for ages
before being merged:
https://github.com/geoserver/geoserver/pull/2664
(shows me as the author, but it's not really me, I'm just unwillingly
involved because nobody else would take action)
Please discuss.
Cheers
Andrea
On
Hi all,
While testing out GeoMesa with GeoServer 2.13.x, we ran into some issues
with the FeatureSizeFeatureCollection. I think there are two issues:
First, for a layers backed by a large volume of data, getCount returning
-1 is partially a way of saying that you don't want to count all the
