Re: [Geoserver-devel] Severe issue on DataStoreFileController

2017-10-31 Thread Torben Barsballe
Hello Alessio, I can't seem to find out exactly where that check was removed either (It seemed to occur right in the middle of a bunch of bulk refactoring), and agree the check should probably be restored. Torben On Tue, Oct 31, 2017 at 2:36 AM, Andrea Aime wrote: > Hi Alessio, > the mass file

Re: [Geoserver-devel] Severe issue on DataStoreFileController

2017-10-31 Thread Andrea Aime
Hi Alessio, the mass file moves happened during the REST upgrade made it hard to track because we have had two IOUtils in two separate modules for a week or so, but I believe I'm at fault here, the inflate code I copied over did not contain saveFile anymore: https://github.com/geoserver/geoserver/

Re: [Geoserver-devel] Severe issue on DataStoreFileController

2017-10-31 Thread Alessio Fabiani
Sorry again :) Just to be clear this line boolean saveFile = files != null && request!=null && request.getMethod(). equals(Method.POST); *is* the correct one, not the issue. That line of code was present on 2.11 and before and has been removed since 2.12. Sorry for the confusion. Regards, Al

Re: [Geoserver-devel] Severe issue on DataStoreFileController

2017-10-31 Thread Alessio Fabiani
Dear all, sorry to bother you again on this topic. After a deeper inspection of the code and spending a lot of time comparing changes between 2.10/11 and 2.12/13 versions of GeoServer, I finally identified the real issue here. Trying to summarize (if something is not clear please let me know), cu

Re: [Geoserver-devel] Severe issue on DataStoreFileController

2017-10-12 Thread Alessio Fabiani
https://github.com/geoserver/geoserver/pull/2592 Regards, Alessio Fabiani == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Alessio Fabiani @alfa7691 Founder/Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa

Re: [Geoserver-devel] Severe issue on DataStoreFileController

2017-10-12 Thread Alessio Fabiani
I no one is working on this I can spend some time to do a PR. Maybe if we can just share few ideas on possible solutions so I can move on the right direction. Most of the fixes should be quite straight. Regards, Alessio Fabiani == GeoServer Professional Services from the experts! Visit http://go

Re: [Geoserver-devel] Severe issue on DataStoreFileController

2017-10-11 Thread Alessio Fabiani
In particular: 1) here https://github.com/geoserver/geoserver/blob/master/src/ restconfig/src/main/java/org/geoserver/rest/catalog/ AbstractStoreUploadController.java#L109 ZIP file containing the shapefiles are extracted on a folder named *$GEOSERVER_DATA_DIR\data\{$workspace}\{$store_name}* wit

Re: [Geoserver-devel] Severe issue on DataStoreFileController

2017-10-11 Thread Alessio Fabiani
Hi Andrea, currently I tested only version 2.12.x, but I guess the same happens on 2.11 and 2.13. Cannot say if that worked before. I noticed this behavior while trying to update the GeoServer version for GeoNode from 2.10 to 2.12. On GeoNode there were no changes on the REST calls, and we never f

Re: [Geoserver-devel] Severe issue on DataStoreFileController

2017-10-11 Thread Andrea Aime
Hi Alessio, looking at the mail I have a hint of what you're talking about, but it would be useful to add some details to understand where to look into. What exact REST request are you running? (important as there are several ways to create a store, like, I would believe that pointing the code to a

[Geoserver-devel] Severe issue on DataStoreFileController

2017-10-10 Thread Alessio Fabiani
Dear all, while testing REST upload of resources against a PostGIS DataStore I faced on a quite severe issue on DataStoreFileController. If you look at the code workflow, in the unlucky case you would like to add a shapefile to a datastore, this methods either fails if the shapefile is not the fir