Re: [Geoserver-devel] patch review for (GEOS-4817) Add Connect and Read Timeout values to Cascaded WMS Store Metadata

2011-10-25 Thread Gabriel Roldan
Thanks Andrea. Gabriel On Tue, Oct 25, 2011 at 3:50 AM, Andrea Aime wrote: > On Mon, Oct 24, 2011 at 8:45 PM, Gabriel Roldan wrote: > >> Andrea, may I bother you to look at the patch attached to >> http://jira.codehaus.org/browse/GEOS-4817 ? >> No rush. >> > > I did not have time to try it out,

Re: [Geoserver-devel] patch review for (GEOS-4817) Add Connect and Read Timeout values to Cascaded WMS Store Metadata

2011-10-24 Thread Andrea Aime
On Mon, Oct 24, 2011 at 8:45 PM, Gabriel Roldan wrote: > Andrea, may I bother you to look at the patch attached to > http://jira.codehaus.org/browse/GEOS-4817 ? > No rush. > I did not have time to try it out, but from the patch file it looks good Cheers Andrea --

[Geoserver-devel] patch review for (GEOS-4817) Add Connect and Read Timeout values to Cascaded WMS Store Metadata

2011-10-24 Thread Gabriel Roldan
Andrea, may I bother you to look at the patch attached to http://jira.codehaus.org/browse/GEOS-4817 ? No rush. TIA, Gabriel On Mon, Oct 24, 2011 at 2:33 PM, Jeffrey Johnson (JIRA) wrote: > Add Connect and Read Timeout values to Cascaded WMS Store Metadata > -

Re: [Geoserver-devel] patch review

2009-06-08 Thread Andrea Aime
Justin Deoliveira ha scritto: > > I think I agree with Gabriel in that adding a derived property which > just used other properties is one thing, but adding a method that does a > full blown resource lookup is another, and something I would like to > avoid on model objects themselves. > > As

Re: [Geoserver-devel] patch review

2009-06-08 Thread Justin Deoliveira
> I'm not sure I fully understand the issue. You mean if a ft _unrelated_ > to the request under execution can't be computed? if so, it shouldn't, > ok. If the ft is related to the request (say a request involving more > than one ft) the request should obviously fail. > > By the patches at GEO

Re: [Geoserver-devel] patch review

2009-06-05 Thread Gabriel Roldan
Andrea Aime wrote: > Gabriel Roldan ha scritto: >> hey, >> >> when you have a second could you please take a look at the patch at >> http://jira.codehaus.org/browse/GEOS-3106. >> Asking for review 'cause though I think it is what we just agreed, it >> touches the interfaces so a review would be h

Re: [Geoserver-devel] patch review

2009-06-05 Thread Andrea Aime
Gabriel Roldan ha scritto: > hey, > > when you have a second could you please take a look at the patch at > http://jira.codehaus.org/browse/GEOS-3106. > Asking for review 'cause though I think it is what we just agreed, it > touches the interfaces so a review would be handy. Gabriel, thanks for

[Geoserver-devel] patch review

2009-06-04 Thread Gabriel Roldan
hey, when you have a second could you please take a look at the patch at http://jira.codehaus.org/browse/GEOS-3106. Asking for review 'cause though I think it is what we just agreed, it touches the interfaces so a review would be handy. Cheers, Gabriel -- Gabriel Roldan OpenGeo - http://openg