Re: [Geotools-devel] Java 6 coding style

2011-07-25 Thread Michael Bedward
Like Ben, my preference would be to use the annotation, especially for the "dead code" protection which I find useful and much more reliable than my memory. Jody: did you mean that there are Java 6 compilers that don't handle the annotation on an interface method ? That would make them badly broke

Re: [Geotools-devel] Java 6 coding style

2011-07-25 Thread Ben Caradoc-Davies
Java 6 @Override on an interface method is useful for detecting unpatched implementations when a method is removed from an interface. Without this, implementers will just be left with dead code. Another case where it is useful is interface extension that narrows a return type, such as GeoAPI Co

Re: [Geotools-devel] Java 6 coding style

2011-07-25 Thread Jody Garnett
No @Override on methods from an interface; they show up as errors on some compilers (depending on how you have things set up). @Overrides is an annotation designed to freak out when a super class changes (so you notice that it changes). Interfaces already have a compile error produced in this case

Re: [Geotools-devel] Java 6 coding style

2011-07-25 Thread Ben Caradoc-Davies
On 26/07/11 11:48, Michael Bedward wrote: > On 26 July 2011 13:17, Ben Caradoc-Davies wrote: >> +1. I was doing this before the switch. > > Oh, but I thought that would have broken the Java 5 build on Hudson ? Oh, my bad, you are right. I missed the crucial word "interface" in your original post

Re: [Geotools-devel] Java 6 coding style

2011-07-25 Thread Michael Bedward
On 26 July 2011 13:17, Ben Caradoc-Davies wrote: > +1. I was doing this before the switch. > Oh, but I thought that would have broken the Java 5 build on Hudson ? Michael -- Magic Quadrant for Content-Aware Data Loss Pr

Re: [Geotools-devel] Java 6 coding style

2011-07-25 Thread Ben Caradoc-Davies
+1. I was doing this before the switch. On 26/07/11 10:36, Michael Bedward wrote: > Hi folks, > > Just want to check on coding style following the move to Java 6. > > Should we always put an @Override annotation on methods implemented > from an interface in new GeoTools code now ? And should we a

[Geotools-devel] Java 6 coding style

2011-07-25 Thread Michael Bedward
Hi folks, Just want to check on coding style following the move to Java 6. Should we always put an @Override annotation on methods implemented from an interface in new GeoTools code now ? And should we add the annotation to existing code ? Michael --

[Geotools-devel] [jira] Created: (GEOT-3758) Inconsistent Fill BGCOLOR when using StyleFactoryImpl.createFill() and StyleFactoryImpl.getDefaultFill()

2011-07-25 Thread Milton Jonathan (JIRA)
Inconsistent Fill BGCOLOR when using StyleFactoryImpl.createFill() and StyleFactoryImpl.getDefaultFill() Key: GEOT-3758 URL: https://jira.codehaus.org/browse/

Re: [Geotools-devel] Aggregating (wfs) datastore back from the ashes

2011-07-25 Thread Chris Holmes
Sounds awesome Andrea. On Mon, Jul 25, 2011 at 6:58 AM, Andrea Aime wrote: > Hi, > a long long time ago, in a svn revision far away, Lisasoft contributed > an aggregating WFS data store: > > http://svn.osgeo.org/geotools/branches/2.4.x/modules/unsupported/aggregating-wfs/src/main/java/org/geotool

Re: [Geotools-devel] Aggregating (wfs) datastore back from the ashes

2011-07-25 Thread Ian Turton
On 25 July 2011 11:58, Andrea Aime wrote: > Hi, > a long long time ago, in a svn revision far away, Lisasoft contributed > an aggregating WFS data store: > http://svn.osgeo.org/geotools/branches/2.4.x/modules/unsupported/aggregating-wfs/src/main/java/org/geotools/data/aggregating/ I must have mis

Re: [Geotools-devel] FOSS4G Code Sprint

2011-07-25 Thread Andrea Aime
On Sat, Jul 23, 2011 at 11:12 AM, Jody Garnett wrote: > In the past we have had successful code sprints based around either: > a) some kind of major work where all hands on deck makes sense - this takes > a bit of prep (rolling out a Query Join implementation would be a good > candidate here) Kil

Re: [Geotools-devel] Sexier JCRSChooser dialog

2011-07-25 Thread Andrea Aime
On Mon, Jul 25, 2011 at 1:03 PM, Michael Bedward wrote: > Hi Andrea, > > Thanks for that - much appreciated. > > Speaking of lines, if you could look at the line generation bits that > I added to the vector grids module and give me some feedback that > would be great. I'm keen to get that module o

Re: [Geotools-devel] Sexier JCRSChooser dialog

2011-07-25 Thread Michael Bedward
Hi Andrea, Thanks for that - much appreciated. Speaking of lines, if you could look at the line generation bits that I added to the vector grids module and give me some feedback that would be great. I'm keen to get that module out of unsupported and merged into gt-main (or wherever) once it's up

[Geotools-devel] Aggregating (wfs) datastore back from the ashes

2011-07-25 Thread Andrea Aime
Hi, a long long time ago, in a svn revision far away, Lisasoft contributed an aggregating WFS data store: http://svn.osgeo.org/geotools/branches/2.4.x/modules/unsupported/aggregating-wfs/src/main/java/org/geotools/data/aggregating/ Today I need something quite similar, yet, different enough that I

Re: [Geotools-devel] Sexier JCRSChooser dialog

2011-07-25 Thread Andrea Aime
On Sun, Jul 24, 2011 at 9:55 AM, Michael Bedward wrote: > Hi Jody, > > I've just committed some changes to JCRSChooser. If you have a chance, > could you cast your eyes over the code please and also give it a > whirl, perhaps with the CRSLab app. Looks good. Btw, for the CRS lab you probably want