[Geotools-devel] [jira] (GEOT-4181) FeatureCollection revolution / simplification

2012-06-20 Thread Jody Garnett (JIRA)
Jody

Re: [Geotools-devel] [jira] (GEOT-4179) Postgis 2.0 support

2012-06-20 Thread Justin Deoliveira
Hey Brett, On Tue, Jun 19, 2012 at 8:58 PM, Brett Walker brett.wal...@geometryit.comwrote: Hi Justin, ** ** I’ve looked into this also and have sent some of my findings to Andrea. I could forward some of my finding to you if that would be helpful. ** Sounds good. Have you taken

Re: [Geotools-devel] [jira] (GEOT-4179) Postgis 2.0 support

2012-06-20 Thread Brett Walker
Hi Justin, I didn't notice the attached patch. I'll have a look latter and provide some feedback. Brett Sent from my iPad On 20/06/2012, at 11:48 PM, Justin Deoliveira jdeol...@opengeo.orgmailto:jdeol...@opengeo.org wrote: Hey Brett, On Tue, Jun 19, 2012 at 8:58 PM, Brett Walker

[Geotools-devel] Proposal (old) ready for review and deprecation patch for 8.x patch

2012-06-20 Thread Jody Garnett
A very old proposal removing the methods that assume an in memory model: - http://docs.codehaus.org/display/GEOTOOLS/FeatureCollection+revolution I have a small non-destructive patch providing the remaining deprecations outlined in the proposal: - https://jira.codehaus.org/browse/GEOT-4181 Can

Re: [Geotools-devel] [jira] (GEOT-4179) Postgis 2.0 support

2012-06-20 Thread Brett Walker
Hi Justin, I’m being a bit picky, but the method PostGISTestSetup.isVersion2() I would rename to PostGISTestSetup.isAtleastVersion2() as it is a minimum test not an equality test. And the following typical block of code: run(INSERT INTO GEOMETRY_COLUMNS VALUES('', 'public', 'ft1',