[Geotools-devel] Regression introduced by ReferencedEnvelope3D work

2012-11-28 Thread Jody Garnett
TLDR: I have found a regression: The constructor ReferencedEnvelope( CoordinateReferenceSystem ) can now fail (previously it would always work). This change is introducing issues in downstream software (such as https://jira.codehaus.org/browse/GEOS-5474). Discussion: Andrea has commented

Re: [Geotools-devel] Regression introduced by ReferencedEnvelope3D work

2012-11-28 Thread Jody Garnett
I notice that the ReferencedEnvelope3D issue (https://jira.codehaus.org/browse/GEOS-5148) is still marked as in progress. Do you have anything to add to the discussion Niels? I do not want to step on your toes, but I also need to sort out a fix promptly. -- Jody Garnett On Wednesday, 28

[Geotools-devel] [jira] (GEOT-4326) Restore SDOOnlineTest from GeoTools 2.4

2012-11-28 Thread Jody Garnett (JIRA)
Jody

[Geotools-devel] [jira] (GEOT-4327) Build failure in gt-epsq-hsql caused by URN_EPSG_Test

2012-11-28 Thread Davide Savazzi (JIRA)
Davide

[Geotools-devel] [jira] (GEOT-4328) ReferencedEnvelope(3D) transform needs to call correct constructor

2012-11-28 Thread Jody Garnett (JIRA)
Jody

Re: [Geotools-devel] Proposing Davide Savazzi for commit rights

2012-11-28 Thread Ian Turton
+1 from me - I haven't had a chance to look at the latest pull requests but the NeoJ stuff looked good to me Ian On 28 November 2012 13:20, Andrea Aime andrea.a...@geo-solutions.it wrote: Hi, Davide (cc'ed) has been making a number of pull requests lately with good quality and tests

Re: [Geotools-devel] Regression introduced by ReferencedEnvelope3D work

2012-11-28 Thread Jody Garnett
Yeah not very happy trying to pass the following test case - any suggestions? public void testTransformToWGS84() throws Exception { String wkt = GEOGCS[\GDA94\, + DATUM[\Geocentric Datum of Australia 1994\, + SPHEROID[\GRS 1980\, 6378137.0,

Re: [Geotools-devel] Regression introduced by ReferencedEnvelope3D work

2012-11-28 Thread Jody Garnett
Okay sorted out my next approach (for when the dimensions do not match): a) For ReferencedEnvelope3D - transform to DefaultGeographic.WGS84_3D and drop down to WGS84 manually, and then transform to the target CRS b) For ReferencedEnvelope - Transform to WGS84 and then and in NaN when manually

Re: [Geotools-devel] Regression introduced by ReferencedEnvelope3D work

2012-11-28 Thread Niels Charlier
Hi Jody, That issue should have already been resolved ages ago, sorry about that. Your solution sounds perfect. Kind Regards Niels Charlier On 28/11/12 10:05, Jody Garnett wrote: I notice that the ReferencedEnvelope3D issue (https://jira.codehaus.org/browse/GEOS-5148) is still marked as in

Re: [Geotools-devel] Proposing Davide Savazzi for commit rights

2012-11-28 Thread Ben Caradoc-Davies
+1. Welcome, Davide. On 28/11/12 21:20, Andrea Aime wrote: Hi, Davide (cc'ed) has been making a number of pull requests lately with good quality and tests (contentFeatureCollection.isEmpty optimization, dpi rescale visitors, wfs store, filter splitters bugs, referencing build fix, and he's

Re: [Geotools-devel] Proposing Davide Savazzi for commit rights

2012-11-28 Thread Jody Garnett
+1 from me, Andrea can you point Davide in the direction of the code contribution agreement and so forth? We need an email from him, confirming he has sent something in. On a related note, I have a couple of outstanding emails going back and forth with OSGeo trying to confirm they received