Re: [Geotools-devel] Graduating gt-transform to supported status

2013-06-14 Thread Andrea Aime
On Sat, Jun 15, 2013 at 8:21 AM, Jody Garnett wrote: > Ah, the final location is a bit of a mystery... this thing is not a plugin > in the strict sense, there is no factory and no store, you are supposed to > call TransformFactory.transform(source, targetName, > listOfAttributeDefinitions) in orde

Re: [Geotools-devel] Graduating gt-transform to supported status

2013-06-14 Thread Jody Garnett
> All of the above is achieved by associating the new set of attributes each > with a OGC Expression, like in the test cases, see the three methods setting > up some transformations: > > https://github.com/geotools/geotools/blob/master/modules/unsupported/transform/src/test/java/org/geotools/dat

Re: [Geotools-devel] Graduating gt-transform to supported status

2013-06-14 Thread Justin Deoliveira
On Fri, Jun 14, 2013 at 6:22 AM, Andrea Aime wrote: > Hi, > I'm writing you to start the process to graduate the gt-transform module > to supported status. > > For those that don't know, the gt-transform module provides a way to > create wrappers around SimpleFeatureSource/SimpleFeatureStore that

[Geotools-devel] Graduating gt-transform to supported status

2013-06-14 Thread Andrea Aime
Hi, I'm writing you to start the process to graduate the gt-transform module to supported status. For those that don't know, the gt-transform module provides a way to create wrappers around SimpleFeatureSource/SimpleFeatureStore that do alter the attributes exposed via: * attribute selection * att

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Jody
Emailed. -- Jody Garnett On Friday, 14 June 2013 at 5:36 PM, Andrea Aime wrote: > On Fri, Jun 14, 2013 at 8:57 AM, Ben Caradoc-Davies > mailto:ben.caradoc-dav...@csiro.au)> wrote: > > Jody, > > > > here is an update for the contributor guide to reflect the small patch > > policy, as discus

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Andrea Aime
On Fri, Jun 14, 2013 at 9:53 AM, Ben Caradoc-Davies < ben.caradoc-dav...@csiro.au> wrote: > On 14/06/13 15:49, Andrea Aime wrote: > >> Do app-schema tests have headers? None of the modules I'm familiar with >> has headers in test classes, that I remember at least >> > > Every one I wrote or cleane

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Ben Caradoc-Davies
On 14/06/13 15:53, Andrea Aime wrote: > Nice. Should we ask them to cc the devel list when they send the > contributor agreement? > meh, as I write it I realize that would make their signature > public, which is bad. > The idea was to get immediate confirmation that the agreement was > actuall

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Andrea Aime
On Fri, Jun 14, 2013 at 9:38 AM, Ben Caradoc-Davies < ben.caradoc-dav...@csiro.au> wrote: > Yes. We have confirmed that there is no need to send the original. Nice. Should we ask them to cc the devel list when they send the contributor agreement? meh, as I write it I realize that would make

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Ben Caradoc-Davies
On 14/06/13 15:49, Andrea Aime wrote: > Do app-schema tests have headers? None of the modules I'm familiar with > has headers in test classes, that I remember at least Every one I wrote or cleaned up has them. But headers are not required to enforce copyright; without them, no rights are lost. I

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Andrea Aime
On Fri, Jun 14, 2013 at 9:48 AM, Ben Caradoc-Davies < ben.caradoc-dav...@csiro.au> wrote: > Yes. We are redistributing tests, just not to end users. > > In my view, tests are code too and need headers and copyright. > Do app-schema tests have headers? None of the modules I'm familiar with has hea

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Ben Caradoc-Davies
On 14/06/13 15:45, Andrea Aime wrote: > One more thing. You say new file, should we qualify new non testing file? > If someone is adding a testing resource, or a new test class, stuff that > does not get redistributed > along with the binaries... should they sign anyways? Yes. We are redistributin

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Andrea Aime
On Fri, Jun 14, 2013 at 9:38 AM, Ben Caradoc-Davies < ben.caradoc-dav...@csiro.au> wrote: > Yes. We have confirmed that there is no need to send the original. One more thing. You say new file, should we qualify new non testing file? If someone is adding a testing resource, or a new test class, s

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Ben Caradoc-Davies
Yes. We have confirmed that there is no need to send the original. On 14/06/13 15:36, Andrea Aime wrote: > Very quick recap, there is one thing I don't remember. > The new contribution agreement can be faxed or e-mailed, right? -- Ben Caradoc-Davies Software Engineer CSIRO Earth Science and Res

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Andrea Aime
On Fri, Jun 14, 2013 at 8:57 AM, Ben Caradoc-Davies < ben.caradoc-dav...@csiro.au> wrote: > Jody, > > here is an update for the contributor guide to reflect the small patch > policy, as discussed at Monday's committee meeting: > https://github.com/geotools/geotools/pull/212 Very quick recap, the

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Ben Caradoc-Davies
Thanks. Merged. On 14/06/13 15:23, Jody wrote: > +1 > > -- > Jody Garnett > > On Friday, 14 June 2013 at 4:57 PM, Ben Caradoc-Davies wrote: > >> Jody, >> >> here is an update for the contributor guide to reflect the small patch >> policy, as discussed at Monday's committee meeting: >> https://gith

Re: [Geotools-devel] Updated contributor guide to reflect small-patch policy

2013-06-14 Thread Jody
+1 -- Jody Garnett On Friday, 14 June 2013 at 4:57 PM, Ben Caradoc-Davies wrote: > Jody, > > here is an update for the contributor guide to reflect the small patch > policy, as discussed at Monday's committee meeting: > https://github.com/geotools/geotools/pull/212 > > - Patches that add n