Re: [Geotools-devel] Backport GEOT-5186 (DB2 SELECTIVITY CLAUSE) to 13.x

2015-08-16 Thread Ben Caradoc-Davies
+1. Looks like a useful addition with few potential side-effects as it is off by default. The only thing that seems to be missing is unit test coverage for the new functionality. Kind regards, Ben. On 17/08/15 04:18, Christian Mueller wrote: > Hi all > > The issue is hiere > > https://osgeo-org

Re: [Geotools-devel] Backport GEOT-5186 (DB2 SELECTIVITY CLAUSE) to 13.x

2015-08-16 Thread Andrea Aime
No objection here Cheers Andrea On Sun, Aug 16, 2015 at 6:18 PM, Christian Mueller < christian.muel...@os-solutions.at> wrote: > Hi all > > The issue is hiere > > https://osgeo-org.atlassian.net/browse/GEOT-5186 > > I would like to backport https://github.com/geotools/geotools/pull/929. > > Only

[Geotools-devel] Backport GEOT-5186 (DB2 SELECTIVITY CLAUSE) to 13.x

2015-08-16 Thread Christian Mueller
Hi all The issue is hiere https://osgeo-org.atlassian.net/browse/GEOT-5186 I would like to backport https://github.com/geotools/geotools/pull/929. Only DB2 specific classes are affected and one of my customers has performance problems. The change does not change the default behavior and there i

Re: [Geotools-devel] SLD Stroke Dasharray Property

2015-08-16 Thread Igor Volkov
In order to clarify the essence of my doubts about the expected behavior of the method float[] Stroke.getDashArray() I have add new test in SLDStyleTest: Stroke stroke = sf.createStroke(null, null); assertNull(stroke.getDashArray()); List dashArray = stroke.dashArray(); dashArray.