Re: [Geotools-devel] Copyright header policy

2016-04-24 Thread Jody Garnett
The part that is making me uneasy is the few times I have done code audits on this codebase the headers were very useful. While I did have to duck out to git history on a few occasions it was a rare occurrence - in part because the team here has done a good job. -- Jody Garnett On 24 April 2016 a

Re: [Geotools-devel] Copyright header policy

2016-04-24 Thread Jody Garnett
The main thing about the author tag is the "name in lights" effect of being able to show your boss your contribution on the published geotools javadocs, and our author tags often also note the employer if appropriate. This kind of encouragement can be very encouraging when starting out in open sour

Re: [Geotools-devel] Copyright header policy

2016-04-24 Thread Ben Caradoc-Davies
Torben, I think these are strong arguments and I am now tempted to avoid @author. It seems cleaner and more elegant to me to keep all metadata (authorship, version history, and copyright) outside the source code itself. The downside is that this information is not visible to non-revision-aware

Re: [Geotools-devel] Copyright header policy

2016-04-24 Thread Justin Deoliveira
What is it specifically that is making you uneasy? I thought Ben made a pretty strong argument that any dates in the copyright don’t really mean anything when it comes to actual legal stuff. Doing it periodically via a script does seem like a better compromise… although from everything I have hear

Re: [Geotools-devel] Copyright header policy

2016-04-24 Thread Ian Turton
Could we not come up with some sort of post-commit hook to make the change for us, it's the remembering to do the change that is the issue for me (at least) Ian On 24 April 2016 at 02:21, Jody Garnett wrote: > Yeah the longer I think about this one the more I am made uncomfortable. > We would b