Re: [Geotools-devel] JDK11 GT repackaging and the Logging utility

2018-10-25 Thread Torben Barsballe
Sure, I have no objections to something like that. I will note that we didn't see any cases where this was actually being done in the GeoTools or GeoServer codebases. Torben On Thu, Oct 25, 2018 at 5:09 PM Jody Garnett wrote: > Technically people can use the String approach to make loggers on a

Re: [Geotools-devel] JDK11 GT repackaging and the Logging utility

2018-10-25 Thread Jody Garnett
Technically people can use the String approach to make loggers on a specific "topic" like rendering, rather than by implementation (which is what package is documenting). Perhaps a getTopic( final String topic ) Using "topic" as "subject" could be mistaken for the "subject" class being logged. --

[Geotools-devel] JDK11 GT repackaging and the Logging utility

2018-10-25 Thread Torben Barsballe
The org.geotools.util.logging.Logging class provides two public methods to get a logger: - public static Logger getLogger(final Class classe) - public static Logger getLogger(final String name) The latter is primarily used to provide a package name manually, while the former infers the pack

Re: [Geotools-devel] JDK 11: GeoTools restructure to address split-package restriction

2018-10-25 Thread Jody Garnett
James has been able to perform some command line magic, as a result we are adding class by class repackaging to the spreadsheet as we go: Yesterday's restructure, only resulted in the following repackaging visible to downstream code: org.geotools.decorate.* org.geotools.util.decorate.* org.geotoo

Re: [Geotools-devel] repackaging the geotools library updates and PMC feedback needed

2018-10-25 Thread Nuno Oliveira GeoSolutions
Please see my answers bellow: On Wed, Oct 24, 2018 at 7:26 PM Jody Garnett wrote: > Sent a proposal out with the high level plan for this week - it has not > been approved: > https://github.com/geotools/geotools/wiki/Restructure-GeoTools-into-Jigsaw-modules > Andrea had a question to see if we c

Re: [Geotools-devel] JDK 11: GeoTools restructure to address split-package restriction

2018-10-25 Thread Andrea Aime
On Thu, Oct 25, 2018 at 8:51 AM Jody Garnett wrote: > - recording refactoring script and placed into user guide for later > Gentle reminder that the Eclipse popularity took a nosedive in the last few years, so in the instructions for using the scripts it's best not to assume Eclipse familiarity: