Re: [Geotools-devel] Thinking about static analysis

2018-12-26 Thread Andrea Aime
Hi Brad, looks like we overlapped a bit, I also took a stab at removing all un-necessary object wrapper constructions (including booleans). Sorry for not going public about that sooner! I've integrated your work and made a public branch here: https://github.com/geotools/geotools/tree/qa In privat

Re: [Geotools-devel] Thinking about static analysis

2018-12-26 Thread bradh
I sent a PR for the PMD branch that adds the ruleset as a local file. Because the ruleset has to be an absolute path to work in the PMD maven plugin, you now have to run at least the “initialize” goal in maven, something like: mvn initialize pmd:check -Ppmd I took the default ruleset and commen