That sounds great +1
--
Jody Garnett
On Tue, 26 Feb 2019 at 11:03, Justin Deoliveira wrote:
> Hi folks,
>
> Following up on a post from a few months back I've been working on a
> module that supports reading rasters from a postgis database. I'd like to
> contribute it as an unsupported module m
Ok, build checks all passed and PR merged.
On Wed, Feb 27, 2019 at 8:47 AM Justin Deoliveira
wrote:
> Cool. I did add it to the unsupported/pom.xml as one of the modules
> included in a normal build. So fingers crossed :)
>
> On Wed, Feb 27, 2019 at 8:44 AM Andrea Aime
> wrote:
>
>> On Wed, Feb
Cool. I did add it to the unsupported/pom.xml as one of the modules
included in a normal build. So fingers crossed :)
On Wed, Feb 27, 2019 at 8:44 AM Andrea Aime
wrote:
> On Wed, Feb 27, 2019 at 4:34 PM Justin Deoliveira
> wrote:
>
>> One thing I forgot as usual is the copyright headers... I'll
On Wed, Feb 27, 2019 at 4:34 PM Justin Deoliveira
wrote:
> One thing I forgot as usual is the copyright headers... I'll add those too
> :)
>
If you put the module in the build, CheckStyle will complain :-p
Cheers
Andrea
==
GeoServer Professional Services from the experts! Visit http://goo.gl/
Haha, all good , thanks Andrea. I'll submit a pull request shortly and if
all the build checks are happy I'll go ahead and merge. One thing I forgot
as usual is the copyright headers... I'll add those too :)
On Wed, Feb 27, 2019 at 7:34 AM Andrea Aime
wrote:
> On Wed, Feb 27, 2019 at 3:30 PM And
On Wed, Feb 27, 2019 at 3:30 PM Andrea Aime
wrote:
> Hi Justin,
> I don't have time to review the code
>
As in, no time "right now" :-p
Cheers
Andrea
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information. == Ing. Andrea Aime @geowolf Technical Le
Hi Justin,
I don't have time to review the code, but I'd say, let's get it in and in
the build in the meantime? No harm done there?
And thank you for sharing!
Cheers
Andrea
On Tue, Feb 26, 2019 at 8:04 PM Justin Deoliveira
wrote:
> Hi folks,
>
> Following up on a post from a few months back I'
