Re: [Geotools-devel] MySQL 8 spatial functions are not supported

2020-09-02 Thread mark
On 2020-09-01 19:24, Nikolaos Pringouris wrote: Hi All, A couple of years ago I worked on jdbc-mysql module and provided support for the newly introduced ST_ functions in Mysql5.6 & Mysql 5.7. I think these functions are also supported in Mysql8.0 with the same signature so I do not think the

Re: [Geotools-devel] MySQL 8 spatial functions are not supported

2020-09-02 Thread Nikolaos Pringouris
Hmm probably I have missed/overlooked these 2 functions when adding support for ST_... functions in geotools 19.x. In any case as you already mentioned the flag is direct available there so you easily add support for the corresponding ST_ functions at that point. Concerning Mysql v5.5 I think you

Re: [Geotools-devel] Counting in GeoTools: going beyond the integer range

2020-09-02 Thread Andrea Aime
Hi, any other opinion on this? Personally I would not like breaking all existing store implementations and clients, for a "clean break" it seems quite bloody :-D But Jody suggests to go that way. Some tie breaker, or even multiple votes leading to another tie, would be appreciated, ha! Cheers An

Re: [Geotools-devel] GeoTools 24-RC progress

2020-09-02 Thread Jody Garnett
Andrea: Thanks, I am aware (and watched that build go :D ). The checks I was looking into were the packaging ones (links going to "stable", including license files, etc...). The jobs are all mostly happy, geotools-master-java11 is the only one that is still failing. I will be working on the blo

Re: [Geotools-devel] Counting in GeoTools: going beyond the integer range

2020-09-02 Thread Ian Turton
On Wed, 2 Sep 2020 at 14:44, Andrea Aime wrote: > Hi, any other opinion on this? > > Personally I would not like breaking all existing store implementations > and clients, for a "clean break" it seems quite bloody :-D > But Jody suggests to go that way. > If we can manage to do it without an API

Re: [Geotools-devel] Counting in GeoTools: going beyond the integer range

2020-09-02 Thread Jody Garnett
Here is another softer approach: /** * @return Returns the number of features in this collection, if this collection contains more than Integer.MAX_VALUE elements, returns Integer.MAX_VALUE. * @deprecated Please use count() */ public int getCount(); public long size(); This gives us a clear ap

Re: [Geotools-devel] Counting in GeoTools: going beyond the integer range

2020-09-02 Thread Andrea Aime
Hi Jody, I like this road, works fine for FeatureSource. What about FeatureCollection though? It's already using "int size()", from the interface: /** * Please note this operation may be expensive when working with remote content. * * @see java.util.Collection#size() */ int size(); Cheers An

Re: [Geotools-devel] Counting in GeoTools: going beyond the integer range

2020-09-02 Thread Jim Hughes
Hi all, The JavaDoc on this method reminded me of one of the points I wanted to suggest.  If there are multiple methods for counting records, it may be good to discuss the semantics.  If I recall, some of the methods in GeoTools have the idea that returning a -1 is suitable way to communicate

Re: [Geotools-devel] Counting in GeoTools: going beyond the integer range

2020-09-02 Thread Emilio Lahr-Vivaz
In regards to returning -1, I believe the relevant count methods are detailed below. It may make sense, if the API is changing anyway, to allow for an 'exact' (or equivalent) parameter to force the count evaluation, and remove the somewhat un-intuitive (to me at least) differentiation between co

Re: [Geotools-devel] Counting in GeoTools: going beyond the integer range

2020-09-02 Thread Emilio Lahr-Vivaz
Or, have a separate method, such as in java.util.Spliterator#estimateSize() Thanks, Emilio On 9/2/20 3:44 PM, Emilio Lahr-Vivaz wrote: In regards to returning -1, I believe the relevant count methods are detailed below. It may make sense, if the API is changing anyway, to allow for an 'exact'