Re: [Geotools-devel] [Geoserver-devel] jai-ext initialisation

2016-12-16 Thread Niels Charlier
Hello Andrea, I definitely wouldn't want to move all initialisation code to static, if anything I'd prefer moving things the other way as Ben suggested. My question was rather about those specific lines of code (initialising the OperationRegistry). My assumption was ImageWorker was going to b

Re: [Geotools-devel] [Geoserver-devel] jai-ext initialisation

2016-12-14 Thread Andrea Aime
On Mon, Dec 12, 2016 at 1:58 PM, Niels Charlier wrote: > I have another question though - why is geoserver doing this thing in > GeoServerInitStartupListener? I'm not just asking about the place it is > doing, why is it doing this at all? What was the original idea behind it > and does it still c

Re: [Geotools-devel] [Geoserver-devel] jai-ext initialisation

2016-12-14 Thread Jody Garnett
2 cents: Andrea, I would appreciate your view on whether GeoTools could benefit > from some sort of configuration API. I know little about JAI and JAIExt, > but could a configuration API be used to inject some sort of manager > into GeoTools? Or do dependencies and cycles mean we will end up > rei

Re: [Geotools-devel] [Geoserver-devel] jai-ext initialisation

2016-12-12 Thread Niels Charlier
Hello, I think this is a misunderstanding. I did not intend my email as a complaint or criticism (and especially not to make myself "feel better", I don't see it that way at all). It was merely intended as an entirely neutral issue report, like "hey, I found this thing that seemed to have sli

Re: [Geotools-devel] [Geoserver-devel] jai-ext initialisation

2016-12-10 Thread Andrea Aime
On Fri, Dec 9, 2016 at 10:19 PM, Ben Caradoc-Davies wrote: > > I think this was a fair comment. > Our community provided a guideline as to what constructive criticism is, that is not, it's simply criticism (without the constructive part). The voting guidelines for anything are clear, one can vot

Re: [Geotools-devel] [Geoserver-devel] jai-ext initialisation

2016-12-09 Thread Ben Caradoc-Davies
On 10/12/16 09:07, Andrea Aime wrote: > On Fri, Dec 9, 2016 at 5:40 PM, Niels Charlier wrote: >> I do think that this is a bit of dodgy situation in general. I think this was a fair comment. I have dealt with at least three other examples where the decoupled nature of GeoTools classes (a good p

Re: [Geotools-devel] [Geoserver-devel] jai-ext initialisation

2016-12-09 Thread Andrea Aime
On Fri, Dec 9, 2016 at 5:40 PM, Niels Charlier wrote: > I do think that this is a bit of dodgy situation in general. > Thank you for the non constructive criticism. Maybe try again with some suggestion on how to improve the situation instead? Regards Andrea -- == GeoServer Professional Servic