Hey all,
The ArcGrid module is failing the extensive testing. Seems like a
central module. Apparently Simone will be around later so I'm delaying
the release until he has a look.
--adrian
Simone,
Several issues for you:
1) The test failure:
-------------------
The problem appears to be when running the
writeEsriUnCompressed(.) and writeGrassUncompressed(.)
methods for the
GiantRowsImage.asc
file since when I skip those tests, the build is successful. This diff
file, from within plugin/arcgrid/, gets the build to work:
logipod:/soft/SVN/geotools/branches/2.3.x/plugin/arcgrid> \
svn diff test/org/geotools/gce/arcgrid/ArcGridReadWriteTest.java
************************************************************************
Index: test/org/geotools/gce/arcgrid/ArcGridReadWriteTest.java
===================================================================
--- test/org/geotools/gce/arcgrid/ArcGridReadWriteTest.java
(revision 23164)
+++ test/org/geotools/gce/arcgrid/ArcGridReadWriteTest.java (working
copy)
@@ -62,7 +62,7 @@
*/
public void runMe(final File testFile) throws Exception {
if
(testFile.getName().equalsIgnoreCase("GiantRowsImage.asc")
- && !TestData.isExtensiveTest())
+ )//&& !TestData.isExtensiveTest())
return;
// create a temporary output file
************************************************************************
Can you fix this? I'm running on gnu/linux btw in case this is a case of
difference in the end of line characters between platforms.
2) The tmp/ files you create:
----------------------------
It's pretty serious that you are writing massive files and then not
cleaning up. You do some cleanup which is cool but I'm sure you could do
better. :-)
However, it's INEXCUSABLE that you make such a mess. When I have to
clean up, instead of wiping out one directory, say
geotools-testrun-TIMESTAMP/
I have to do something like
rm 1* 2* 3* 4* 5* 6* 7* 8* 9*
just for the arcgrid plugin!
In my copy, I add a "gt-test-" in line 71 of ArcGridReadWriteTest.java,
just below the above change, i.e.
tmpFile = File.createTempFile("gt-test-"+Long.toString(Math
which at least gets things slightly cleaner.
Could you eventually move your output into a temporary test run file, or
at least prepend all the files with the same string so they are easy to
wipe out later?
3) The geotiff spew:
-------------------
During an extensive test run, the geotiff module (and possibly others)
spews a bunch of WKT stuff. This clutters the maven output for no
visibly useful gain.
Is that something you could clean up eventually?
ciao,
adrian
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
