Re: [Geotools-devel] Adding a kerning vendor option and enable it by default

2017-04-24 Thread Andrea Aime
Nothing standing out on the naked eye, do you have time to run benchmarks? For the moment I expect the dominator is still in the refactoring that pushed the per char conflict resolution, which slowed down the labeler more than an order of magnitude. Unfortunately I was not available for review ba

Re: [Geotools-devel] Adding a kerning vendor option and enable it by default

2017-04-24 Thread Dave Blasby
Hi, I could just barely notice the difference between those images - and only because Ben pointed out some examples. What is the performance difference for this? I expect its low... Thanks, Dave On Sat, Apr 22, 2017 at 9:59 PM, Ben Caradoc-Davies wrote: > Merged on master. > > Kind regards,

Re: [Geotools-devel] Adding a kerning vendor option and enable it by default

2017-04-22 Thread Ben Caradoc-Davies
Merged on master. Kind regards, Ben. On 22/04/17 21:18, Andrea Aime wrote: > Pull request here: > > https://github.com/geotools/geotools/pull/1561 > > Cheers > Andrea > > > On Sun, Mar 26, 2017 at 10:57 PM, Ben Caradoc-Davies > wrote: > >> +1 to enable by default. For good examples, have a look

Re: [Geotools-devel] Adding a kerning vendor option and enable it by default

2017-04-22 Thread Andrea Aime
Pull request here: https://github.com/geotools/geotools/pull/1561 Cheers Andrea On Sun, Mar 26, 2017 at 10:57 PM, Ben Caradoc-Davies wrote: > +1 to enable by default. For good examples, have a look at Vesy St and > West St and Park Pl West on the left. W/e and V/e pairs are some of those > mo

Re: [Geotools-devel] Adding a kerning vendor option and enable it by default

2017-03-26 Thread Ben Caradoc-Davies
+1 to enable by default. For good examples, have a look at Vesy St and West St and Park Pl West on the left. W/e and V/e pairs are some of those most in need of kerning, and the improvement looks great to me. Kind regards, Ben. On 27/03/17 03:49, Andrea Aime wrote: > Hi, > a question on stackov

Re: [Geotools-devel] Adding a kerning vendor option and enable it by default

2017-03-26 Thread Justin Deoliveira
I think anything that makes rendering look better out of the box is a big win. I would say as long as the performance hit isn't catastrophic this would be worth it. $0.02 On Sun, Mar 26, 2017 at 8:49 AM Andrea Aime wrote: > Hi, > a question on stackoverflow [1] prompted me to look into font kerni

[Geotools-devel] Adding a kerning vendor option and enable it by default

2017-03-26 Thread Andrea Aime
Hi, a question on stackoverflow [1] prompted me to look into font kerning in java. After a few attempts I managed to enable it and imho indeed the result looks prettier... but one has to look carefully :-) I've created a before and after example, with a "difference" image highlighting in red what