Re: [Geotools-devel] Customization of the CREATE TABLE

2016-03-08 Thread Andrea Aime
On Tue, Mar 8, 2016 at 10:57 PM, Justin Deoliveira wrote: > Hi Sayon, > > Generally we ask that any new feature or bug fix come with a test case. > However the change in this case is being made to an abstract base class so > I imagine will be hard to test. > Thinking out loud, an easy way to mak

Re: [Geotools-devel] Customization of the CREATE TABLE

2016-03-08 Thread Justin Deoliveira
Hi Sayon, Generally we ask that any new feature or bug fix come with a test case. However the change in this case is being made to an abstract base class so I imagine will be hard to test. I suggest you submit the changes you have currently as a pull request and we can see if there might be an ea

[Geotools-devel] Customization of the CREATE TABLE

2016-03-08 Thread Sayon Kumar
Hey guys, I have been developing a SAP HANA data-store plugin for Geotools. The SQLDialect interface as currently written doesn’t allow for customization to the CREATE TABLE statement. I have modified the SQLDialect interface and added a new method named “encodeCreateTable” whose default behavour