Re: [Geotools-devel] DefaultFeatureResults QA review & blog

2007-02-23 Thread Jody Garnett
This cycle of work is now complete, Trunk has been updated (and I will post a follow up on Monday when when I update the javadocs) - http://weblogs.java.net/blog/jive/archive/2007/02/the_code_always_2.html Jody > Jody Garnett ha scritto: >> Thanks Andrea >> >> A couple of blog posts as I do this Q

Re: [Geotools-devel] DefaultFeatureResults QA review & blog

2007-02-21 Thread Andrea Aime
Jody Garnett ha scritto: > Thanks Andrea > > A couple of blog posts as I do this QA run: > - http://weblogs.java.net/blog/jive/archive/2007/02/the_code_always.html > - http://weblogs.java.net/blog/jive/archive/2007/02/the_code_always_1.html > > Cheers, > Jody >> Thanks Andrea I like that one a *l

[Geotools-devel] DefaultFeatureResults QA review & blog

2007-02-21 Thread Jody Garnett
Thanks Andrea A couple of blog posts as I do this QA run: - http://weblogs.java.net/blog/jive/archive/2007/02/the_code_always.html - http://weblogs.java.net/blog/jive/archive/2007/02/the_code_always_1.html Cheers, Jody > Thanks Andrea I like that one a *lot* ... I did not want to throw an > exce

Re: [Geotools-devel] DefaultFeatureResults QA review

2007-02-21 Thread Jody Garnett
Andrea Aime wrote: >> The last two statements can be commented out (the DefaultQuery >> constructor copes the coordinateSystem and coordinateSystemReproject. >> The trouble is changing the typeName .. this used to not exist; and >> then it used to be an exception. And then this code carefully ign

Re: [Geotools-devel] DefaultFeatureResults QA review

2007-02-21 Thread Andrea Aime
Jody Garnett ha scritto: > Hi Andrea I am walking through some test case code looking into that > Query thing > > The following code looks suspect (and svn blame lists you as the author > - may be an accident of Jalopy): >public DefaultFeatureResults(FeatureSource source, Query query) {

[Geotools-devel] DefaultFeatureResults QA review

2007-02-20 Thread Jody Garnett
Hi Andrea I am walking through some test case code looking into that Query thing The following code looks suspect (and svn blame lists you as the author - may be an accident of Jalopy): public DefaultFeatureResults(FeatureSource source, Query query) { this.featureSource = source;