Re: [Geotools-devel] Filter Performance Changes

2010-04-29 Thread Charles Ballance
Scratch AttributeExpressionImpl from the list of offenders in my last email...it's fine. -- ___ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.so

Re: [Geotools-devel] Filter Performance changes

2010-04-29 Thread Jody Garnett
Cool - can you raise a Jira issue and attach a patch? Jody On 29/04/2010, at 11:00 PM, Charles Ballance wrote: > While redoing the FidFilterImpl, i noticed the common pitfall of not > using Logging properly, ie., > not using > if( LOGGER.isLoggable(Level.FINEST) ) { > do log... > } > For calls

[Geotools-devel] Filter Performance changes

2010-04-29 Thread Charles Ballance
While redoing the FidFilterImpl, i noticed the common pitfall of not using Logging properly, ie., not using if( LOGGER.isLoggable(Level.FINEST) ) { do log... } For calls where one constructs the logger's arguments dynamically(most often string concatenation). This forces the jvm to do extra wo