Re: [Geotools-devel] GEOT-6386 Polyconic Spherical Case

2020-07-27 Thread Joseph Miller via GeoTools-Devel
Sorry, just realised that was unclear. I was trying to ask if it makes sense for me to do the abstracting (by making a parent S3 module) as part of creating the requested S3 Shapefile module. I wasn't asking anyone else to do the work. Thanks, Joe Miller On Mon, Jul 27, 2020 at 4:18 PM Joseph M

Re: [Geotools-devel] GEOT-6386 Polyconic Spherical Case

2020-07-27 Thread Joseph Miller via GeoTools-Devel
Yup, thanks Andrea. I ran mvn -pl 'org.geotools:gt-referencing' install -Dqa -Dall to validate things. While I wait for the PR review I was thinking of tackling this one if no one else is looking at it: https://osgeo-org.atlassian.net/projects/GEOT/issues/GEOT-6157 (support for authenticated S3 l

Re: [Geotools-devel] GEOT-6386 Polyconic Spherical Case

2020-07-23 Thread Andrea Aime
Doh, bizarre, the Travis build is a no show for the moment? ... well, the QA checks can be run also locally, within the limits of the module you modified (gt-referencing) Cheers Andrea On Thu, Jul 23, 2020 at 3:53 PM Andrea Aime wrote: > Hi Joseph, > thanks for the pull request. It might be a w

Re: [Geotools-devel] GEOT-6386 Polyconic Spherical Case

2020-07-23 Thread Andrea Aime
Hi Joseph, thanks for the pull request. It might be a while before it gets looked at, between vacations and deadlines I won't have much time in the next 3-4 weeks. In the meantime I suggest you look at the PR checks (the travis one has several sub-checks) and monitor failures, with particular atten

Re: [Geotools-devel] GEOT-6386 Polyconic Spherical Case

2020-07-23 Thread Joseph Miller via GeoTools-Devel
Thanks Andrea. Looking forward to the review process and future bug fixes. The PR can be found here: https://github.com/geotools/geotools/pull/3087 Joe Miller On Tue, Jul 21, 2020 at 2:11 AM Andrea Aime wrote: > Hi Joseph, > I believe no one is working, and it would be welcomed. > More often

Re: [Geotools-devel] GEOT-6386 Polyconic Spherical Case

2020-07-20 Thread Andrea Aime
Hi Joseph, I believe no one is working, and it would be welcomed. More often than not, we just port over the equivalent code from PROJ... probably this class: https://github.com/OSGeo/PROJ/blob/master/src/projections/poly.cpp When you'll open the PR the following template will appear: https://gith

[Geotools-devel] GEOT-6386 Polyconic Spherical Case

2020-07-20 Thread Joseph Miller via GeoTools-Devel
I am interested in developing a patch to address GEOT-6386, the Polyconic Spherical Case ( https://osgeo-org.atlassian.net/projects/GEOT/issues/GEOT-6386) but wanted to make sure that nobody is currently working on it or that it hasn't been rejected for reasons that I am not seeing at first glance.