Re: [Geotools-devel] Improving parsing GML files without a reference to the schema

2016-02-15 Thread Andrea Aime
On Tue, Feb 9, 2016 at 8:19 PM, Jody Garnett wrote: > Wonder if that is a functionality change since I wrote > GML.decodeFeatureCollection (hard to know). > Don't know honestly... Anyways, I wanted to make a pull request, but I pushed to master instead... oh well, review still welcomed: https:

Re: [Geotools-devel] Improving parsing GML files without a reference to the schema

2016-02-09 Thread Jody Garnett
Wonder if that is a functionality change since I wrote GML.decodeFeatureCollection (hard to know). Still the point of a facade class is to hook up these methods to the best available implementation, and the changes you are making sound like an improvement. -- Jody Garnett On 5 February 2016 at 1

Re: [Geotools-devel] Improving parsing GML files without a reference to the schema

2016-02-05 Thread Jody Garnett
Looks like from your code example that you are doing a much smarter job then the GML utility class decodeFeatureCollection(InputStream in) method. When a schema is not available the parser r

Re: [Geotools-devel] Improving parsing GML files without a reference to the schema

2016-02-05 Thread Andrea Aime
On Fri, Feb 5, 2016 at 7:25 PM, Jody Garnett wrote: > Looks like from your code example that you are doing a much smarter job > then the GML > > utility class decodeFeatureCollection(InputS

Re: [Geotools-devel] Improving parsing GML files without a reference to the schema

2016-01-31 Thread Justin Deoliveira
On Sun, Jan 31, 2016 at 2:37 AM Andrea Aime wrote: > On Fri, Jan 29, 2016 at 4:00 PM, Justin Deoliveira > wrote: > >> These could be added as new methods to the GML facade class: >>> SimpleFeatureType GML.decodeSchema(InputStream in) >>> SimpleFeatureCollection GML.decodeFeatureCollection(InputS

Re: [Geotools-devel] Improving parsing GML files without a reference to the schema

2016-01-31 Thread Andrea Aime
On Fri, Jan 29, 2016 at 4:00 PM, Justin Deoliveira wrote: > These could be added as new methods to the GML facade class: >> SimpleFeatureType GML.decodeSchema(InputStream in) >> SimpleFeatureCollection GML.decodeFeatureCollection(InputStream in) >> >> I wonder if you could handle both the scan on

Re: [Geotools-devel] Improving parsing GML files without a reference to the schema

2016-01-29 Thread Justin Deoliveira
Hey Andrea, Some comments/questions inline. On Fri, Jan 29, 2016 at 4:44 AM Andrea Aime wrote: > Hi, > I'm looking into improving our ability to parse GML files whose reference > to the schema is invalid or unreachable, in other words, not usable. > > Right now the parser generates a feature co

[Geotools-devel] Improving parsing GML files without a reference to the schema

2016-01-29 Thread Andrea Aime
Hi, I'm looking into improving our ability to parse GML files whose reference to the schema is invalid or unreachable, in other words, not usable. Right now the parser generates a feature collection by reflecting the schema out of the first feature, which causes issues some cases, like missing ele