Re: [Geotools-devel] Issue with mosaic of indexed png's

2019-10-31 Thread Justin Deoliveira
Thanks for the input guys. Your suggestions make sense. I'll try removing the seek and see how that works with all of the geotools/geoserver unit tests and also do some smoke testing. I'll file a bug in jira with all of the details as well. On Thu, Oct 31, 2019 at 3:55 AM Daniele Romagnoli < danie

Re: [Geotools-devel] Issue with mosaic of indexed png's

2019-10-31 Thread Daniele Romagnoli
Hi Justin, I tracked a bit the git history and it looks like that this seek(0) is there since 2012 (that is where the git history ends more or less). Not sure if that seek(0) has been put there for a real reason (since JAI uses deferred execution and reader can start the actual read only once need)

Re: [Geotools-devel] Issue with mosaic of indexed png's

2019-10-31 Thread Andrea Aime
Hi Justin, before we add a flag to work around it, I was wondering if the issue could be fixed in a different way, like, at the source. Looking at the FileImageInputStreamImpl, I've noticed one oddball thing, but it's probably not related: the lines do not seem matching up. https://github.com/geos

[Geotools-devel] Issue with mosaic of indexed png's

2019-10-30 Thread Justin Deoliveira
Hi folks, I am working on upgrading an application from a much older version of geotools (15.1) to the latest stable. I've hit a roadblock regarding image mosaics consisting of indexed PNG files that I think I have narrowed down to this change: https://github.com/geotools/geotools/commit/585b021d