Re: [Geotools-devel] JDBC-NG: making primary key lookup more flexible

2009-12-03 Thread Christian Müller
Yep, Deal :-) Andrea Aime writes: > Christian Müller ha scritto: >> Yep, I am >> First, I meant DB2 does not allow an underscore as the first character of >> a table name. Sorry. >> Second, I talked only about meta information. >> >> About Sequences: >> The method >> public String getSeque

Re: [Geotools-devel] JDBC-NG: making primary key lookup more flexible

2009-12-03 Thread Andrea Aime
Christian Müller ha scritto: > Yep, I am > First, I meant DB2 does not allow an underscore as the first character > of a table name. Sorry. > Second, I talked only about meta information. > > About Sequences: > The method > public String getSequenceForColumn(String schemaName, String tableName,

Re: [Geotools-devel] JDBC-NG: making primary key lookup more flexible

2009-12-03 Thread Christian Müller
Yep, I am First, I meant DB2 does not allow an underscore as the first character of a table name. Sorry. Second, I talked only about meta information. About Sequences: The method public String getSequenceForColumn(String schemaName, String tableName, String columnName, Connection cx) th

Re: [Geotools-devel] JDBC-NG: making primary key lookup more flexible

2009-12-03 Thread Justin Deoliveira
Andrea Aime wrote: > Justin Deoliveira ha scritto: >> I wonder if we really need an interface? Could we just roll support >> for a primary key metadata table into the regular lookup chain? What >> sorts of alternative strategies might be used? > > I'm not sure actually, but someone might not w

Re: [Geotools-devel] JDBC-NG: making primary key lookup more flexible

2009-12-03 Thread Andrea Aime
Christian Müller ha scritto: > A big +1 for interface or base class,I think a base class would be fine. > > @Justin, asfaik , DB2 does not allow underlines in table names. I am not > a friend of such default assumptions. DB2 does not allow for underscore? Odd? > @Andrea, look at http://jira.cod

Re: [Geotools-devel] JDBC-NG: making primary key lookup more flexible

2009-12-03 Thread Christian Müller
A big +1 for interface or base class,I think a base class would be fine. @Justin, asfaik , DB2 does not allow underlines in table names. I am not a friend of such default assumptions. @Andrea, look at http://jira.codehaus.org/browse/GEOT-2015, it would be a good idea to have an additional me

Re: [Geotools-devel] JDBC-NG: making primary key lookup more flexible

2009-12-03 Thread Andrea Aime
Justin Deoliveira ha scritto: > I wonder if we really need an interface? Could we just roll support for > a primary key metadata table into the regular lookup chain? What sorts > of alternative strategies might be used? I'm not sure actually, but someone might not want to pollute their schema wi

Re: [Geotools-devel] JDBC-NG: making primary key lookup more flexible

2009-12-03 Thread Justin Deoliveira
I wonder if we really need an interface? Could we just roll support for a primary key metadata table into the regular lookup chain? What sorts of alternative strategies might be used? Not against the idea, I like the design but like to avoid adding abstractions unless its necessary. A few comme

[Geotools-devel] JDBC-NG: making primary key lookup more flexible

2009-12-03 Thread Andrea Aime
Hi, recently I've had a few requests to make primary key lookup more flexible in JDBC-NG datastores, and finally I've got someone that could be interested in sponsoring some improvements (provided they stay inside a small budget). The current code uses a set of heuristics to find out what a pk is