Re: [Geotools-devel] Line endings checks on Jenkins and Travis CI

2018-06-29 Thread Chris Snider
-Devel list Subject: Re: [Geotools-devel] Line endings checks on Jenkins and Travis CI On Fri, Jun 29, 2018 at 3:10 PM, Ian Turton mailto:ijtur...@gmail.com>> wrote: I think if we set it to auto it should spot for them and convert back. I'd need to resurrect my windows machine to check

Re: [Geotools-devel] Line endings checks on Jenkins and Travis CI

2018-06-29 Thread Andrea Aime
On Fri, Jun 29, 2018 at 3:10 PM, Ian Turton wrote: > I think if we set it to auto it should spot for them and convert back. I'd > need to resurrect my windows machine to check though, And we'd need to work > out all the binary file endings we'd need to protect. > Is there a way to list the ones

Re: [Geotools-devel] Line endings checks on Jenkins and Travis CI

2018-06-29 Thread Ian Turton
I think if we set it to auto it should spot for them and convert back. I'd need to resurrect my windows machine to check though, And we'd need to work out all the binary file endings we'd need to protect. Ian On Fri, 29 Jun 2018 at 14:04, Andrea Aime wrote: > Yep, sounds like it might :-) > Won

Re: [Geotools-devel] Line endings checks on Jenkins and Travis CI

2018-06-29 Thread Andrea Aime
Yep, sounds like it might :-) Wondering if it's going to cause trouble for people on Windows though, like, editor wise (well, instead of them causing trouble to the rest :-p) Cheers Andrea On Thu, Jun 28, 2018 at 11:06 AM, Ian Turton wrote: > From this >

Re: [Geotools-devel] Line endings checks on Jenkins and Travis CI

2018-06-28 Thread Ian Turton
>From this it looks we can set up a *.gitattributes* file to automagically convert them on check in/out. Might be worth experimenting with? Ian On Wed, 27 Jun 2018 at 22:21, Ben Caradoc-Davies wrote: > In yes

[Geotools-devel] Line endings checks on Jenkins and Travis CI

2018-06-27 Thread Ben Caradoc-Davies
In yesterday's meeting we noticed a pull request that tried to convert many line endings from LF to CRLF. This was not detected by fmt-maven-plugin. There is a fmt-maven-plugin feature request: https://github.com/coveo/fmt-maven-plugin/issues/32 We could add a separate check. Kind regards, --