Re: [Geotools-devel] Online testing for Oracle, some questions on failing test

2020-04-25 Thread Andrea Aime
Then I would say... go ahead :-D Cheers Andrea On Sat, Apr 25, 2020 at 11:37 AM Mark Prins wrote: > Fails on master with an old driver, fixed in the PR by adding a getter for > the expected. > > Op za 25 apr. 2020 10:31 schreef Andrea Aime >: > >> But first the question: was it failing before?

Re: [Geotools-devel] Online testing for Oracle, some questions on failing test

2020-04-25 Thread Mark Prins
Fails on master with an old driver, fixed in the PR by adding a getter for the expected. Op za 25 apr. 2020 10:31 schreef Andrea Aime : > But first the question: was it failing before? > Tests are often added to the base JDBC*Test classes, and tested on a bunch > of them only... like, > NOT Oracl

Re: [Geotools-devel] Online testing for Oracle, some questions on failing test

2020-04-25 Thread Andrea Aime
But first the question: was it failing before? Tests are often added to the base JDBC*Test classes, and tested on a bunch of them only... like, NOT Oracle :-D Cheers Andrea On Sat, Apr 25, 2020 at 3:10 AM Jody Garnett wrote: > My first thought is the previous driver also had to wrestle with Ora

Re: [Geotools-devel] Online testing for Oracle, some questions on failing test

2020-04-24 Thread Jody Garnett
My first thought is the previous driver also had to wrestle with Oracle's representation of Numbers and was able to sort things out. * Can we find any logic that handled this previously? * Can we step through the old code with a debugger and see how it made the decision to convert from BigDecimal

Re: [Geotools-devel] Online testing for Oracle, some questions on failing test

2020-04-23 Thread Mark Prins
Op di 21 apr. 2020 om 17:51 schreef Mark Prins : > While working on this PR https://github.com/geotools/geotools/pull/2890 > to have Online testing of the Oracle JDBC module I'm running into some > failing tests. > > OracleFeatureSourceOnlineTest>OnlineTestCase.run:112->JDBCFeatureSourceOnlineTes

[Geotools-devel] Online testing for Oracle, some questions on failing test

2020-04-21 Thread Mark Prins
While working on this PR https://github.com/geotools/geotools/pull/2890 to have Online testing of the Oracle JDBC module I'm running into some failing tests. Some may have to do with how the user is defined in Oracle, but one of the failures definitely isn't and the failure line is slightly cr