Re: [Geotools-devel] Problem with General Oblique transform latitude?

2016-06-04 Thread Maciej Filocha
Ben, I'm glad to hear that. Thank you! Maciej W dniu 04.06.2016 o 07:44, Ben Caradoc-Davies pisze: > Maciej, > > I thought you might like to know that I have just submitted pull > requests to add support for your Rotated Pole projection to the GeoTools > NetCDF module and the GeoServer

Re: [Geotools-devel] Problem with General Oblique transform latitude?

2016-06-03 Thread Ben Caradoc-Davies
Maciej, I thought you might like to know that I have just submitted pull requests to add support for your Rotated Pole projection to the GeoTools NetCDF module and the GeoServer NetCDF output module: https://github.com/geotools/geotools/pull/1205 https://github.com/geoserver/geoserver/pull/1631

Re: [Geotools-devel] Problem with General Oblique transform latitude?

2016-04-11 Thread Ben Caradoc-Davies
Maciej, that looks great. I agree that this new projection is the best way to maintain backwards compatibility. In the test script, for "source pt = (0, 0)", the "target pt" latitude matches the projection latitude_of_origin, as I expect for a Rotated Pole projection. I repurposed my Jira

Re: [Geotools-devel] Problem with General Oblique transform latitude?

2016-04-11 Thread Maciej Filocha
Ben, in order not to break API, I propose to add new transformation first (named RotatedPole) with this PR: https://github.com/geotools/geotools/pull/1168 and then remove (by depreciation?) the GeneralOblique one. This should be safer because of somehow "fundamental" change in one of the key

Re: [Geotools-devel] Problem with General Oblique transform latitude?

2016-04-04 Thread Ben Caradoc-Davies
On 05/04/16 08:27, Maciej Filocha wrote: > W dniu 02.04.2016 o 02:34, Ben Caradoc-Davies pisze: >> I have created a Jira issue for this problem: >> [GEOT-5396] Incorrect General Oblique transform >> https://osgeo-org.atlassian.net/browse/GEOT-5396 > I'll prepare fix for it this week. Thanks very

Re: [Geotools-devel] Problem with General Oblique transform latitude?

2016-04-04 Thread Maciej Filocha
Ben, W dniu 02.04.2016 o 02:34, Ben Caradoc-Davies pisze: > I have created a Jira issue for this problem: > > [GEOT-5396] Incorrect General Oblique transform > https://osgeo-org.atlassian.net/browse/GEOT-5396 I'll prepare fix for it this week. > > One other question: is General_Oblique the most

Re: [Geotools-devel] Problem with General Oblique transform latitude?

2016-04-01 Thread Ben Caradoc-Davies
Maciej, I have created a Jira issue for this problem: [GEOT-5396] Incorrect General Oblique transform https://osgeo-org.atlassian.net/browse/GEOT-5396 One other question: is General_Oblique the most appropriate name for this MapProjection? Although the implementation methods could be used be

[Geotools-devel] Problem with General Oblique transform latitude?

2016-03-19 Thread Ben Caradoc-Davies
Maciej, thank you for your contribution of the General Oblique Transform to GeoTools. https://github.com/geotools/geotools/blob/master/modules/library/referencing/src/main/java/org/geotools/referencing/operation/projection/GeneralOblique.java https://osgeo-org.atlassian.net/browse/GEOT-5190

Re: [Geotools-devel] Problem with General Oblique transform latitude?

2016-03-19 Thread Maciej Filocha
Ben, W dniu 18.03.2016 o 03:49, Ben Caradoc-Davies pisze: > I note that (lambda_g^N, phi_g^N) is the North Pole of the rotated grid, > so phi_g^N is not latitudeOfOrigin, which is measured from the equator. You're right here. Proj's "+o_lat_p" parameter (undocumented, of course) used in my

Re: [Geotools-devel] Problem with General Oblique transform latitude?

2016-03-19 Thread Ben Caradoc-Davies
Maciej, I am looking at equations 3.74 on page 25 (PDF page 31) of part one of the COSMO manual: http://www.cosmo-model.org/content/model/documentation/core/cosmoDyncsNumcs.pdf I note that (lambda_g^N, phi_g^N) is the North Pole of the rotated grid, so phi_g^N is not latitudeOfOrigin, which is