Re: [Geotools-devel] Promoting gt-ysld to a supported module

Pull request here: https://github.com/geotools/geotools/pull/1448 Torben On Thu, Jan 26, 2017 at 5:28 PM, Jody Garnett wrote: > somewhere - http://docs.geotools.org/latest/userguide/welcome/ > architecture.html > > -- > Jody Garnett > > On 26 January 2017 at 17:18, Torben Barsballe > wrote: >

Re: [Geotools-devel] Promoting gt-ysld to a supported module

somewhere - http://docs.geotools.org/latest/userguide/welcome/architecture.html -- Jody Garnett On 26 January 2017 at 17:18, Torben Barsballe wrote: > Okay, in that case gt-ysld would become an extension. > Thanks Jody. That should probably be documented somewhere. > > On Thu, Jan 26, 2017 at 5

Re: [Geotools-devel] Promoting gt-ysld to a supported module

Okay, in that case gt-ysld would become an extension. Thanks Jody. That should probably be documented somewhere. On Thu, Jan 26, 2017 at 5:13 PM, Jody Garnett wrote: > plugins extend factory SPI somehow > extensions add more stuff on top of the core geotools library > > -- > Jody Garnett > > On

Re: [Geotools-devel] Promoting gt-ysld to a supported module

plugins extend factory SPI somehow extensions add more stuff on top of the core geotools library -- Jody Garnett On 26 January 2017 at 15:16, Ben Caradoc-Davies wrote: > +1. Thanks, Torben, that is quite thorough. > > Jody, do we have a policy for which supported modules are plugins and > which

Re: [Geotools-devel] Promoting gt-ysld to a supported module

Thanks, Torben. It does look to me like gt-ysld meets the definition of a plugin. Jody, any opinion? Kind regards, Ben. On 27/01/17 12:48, Torben Barsballe wrote: > Ben: > > With respect to plugins vs extensions, I did find some "definitions" here: > http://docs.geotools.org/latest/developer/pro

Re: [Geotools-devel] Promoting gt-ysld to a supported module

Ben: With respect to plugins vs extensions, I did find some "definitions" here: http://docs.geotools.org/latest/developer/procedures/check.html Torben On Thu, Jan 26, 2017 at 3:40 PM, Justin Deoliveira wrote: > +1. Great work on this Torben. > On Thu, Jan 26, 2017 at 4:17 PM Ben Caradoc-Davies

Re: [Geotools-devel] Promoting gt-ysld to a supported module

+1. Great work on this Torben. On Thu, Jan 26, 2017 at 4:17 PM Ben Caradoc-Davies wrote: > +1. Thanks, Torben, that is quite thorough. > > Jody, do we have a policy for which supported modules are plugins and > which are extensions? I noticed that Torben used the term "plugin" and > realised that

Re: [Geotools-devel] Promoting gt-ysld to a supported module

+1. Thanks, Torben, that is quite thorough. Jody, do we have a policy for which supported modules are plugins and which are extensions? I noticed that Torben used the term "plugin" and realised that I do not know if we have rules. Is there a difference, or is this just an historical oddity? Ki

Re: [Geotools-devel] Promoting gt-ysld to a supported module

+1 -- Jody Garnett On 26 January 2017 at 10:41, Torben Barsballe wrote: > The gt-ysld module is now ready to be considered for a supported module. > > I would like to request that this module be approved for inclusion as a > supported plugin in the upcoming 16.2 / 17-beta releases. > The module

Re: [Geotools-devel] Promoting gt-ysld to a supported module

The gt-ysld module is now ready to be considered for a supported module. I would like to request that this module be approved for inclusion as a supported plugin in the upcoming 16.2 / 17-beta releases. The module conforms to the requirements

Re: [Geotools-devel] Promoting gt-ysld to a supported module

Thanks for the feedback. Class javadocs have been updated in the PR. Torben On Wed, Jan 25, 2017 at 9:56 AM, Jody Garnett wrote: > Thanks, formatting changes look good. I looked for the null returns - and > the "return null" statements I found were not especially documented. > > General feedbac

Re: [Geotools-devel] Promoting gt-ysld to a supported module

Thanks, formatting changes look good. I looked for the null returns - and the "return null" statements I found were not especially documented. General feedback is we could take one run at class javadocs (usual Class/Responsibility/Collaboration info) and we should be good. -- Jody Garnett On 25

Re: [Geotools-devel] Promoting gt-ysld to a supported module

Based on Matt's analysis, we have put together a pull request fixing up the outstanding issues in gt-ysld bringing it up to compliance with the developers guide: https://github.com/geotools/geotools/pull/1440 Null returns are documented, and are used sparingly. Torben On Tue, Jan 24, 2017 at 9:5

Re: [Geotools-devel] Promoting gt-ysld to a supported module

I am not as keen as Martin was, I expect that Optionals will take the place of the idea of null objects long term. What I am keen on is making our developer guide not suck; so if we are not being strict about null we should relax the guide (citing returning a null collection). I am kind of okay wi

Re: [Geotools-devel] Promoting gt-ysld to a supported module

Thanks Andrea -- agreed. I tried to note that returning null actually seemed valid in most of these particular cases, but I didn't know how strictly the "rule" (from the developer guide) is enforced. On Tue, Jan 24, 2017 at 12:57 PM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: > I agre

Re: [Geotools-devel] Promoting gt-ysld to a supported module

I agree that strictly not returning null ever is overkill. Given that, we should probably update the dev guide: http://docs.geotools.org/latest/developer/conventions/code/null.html Torben On Tue, Jan 24, 2017 at 10:11 AM, Andrea Aime wrote: > On Tue, Jan 24, 2017 at 6:57 PM, Matt Kruszewski < >

Re: [Geotools-devel] Promoting gt-ysld to a supported module

On Tue, Jan 24, 2017 at 6:57 PM, Matt Kruszewski < mkruszew...@boundlessgeo.com> wrote: > Hello everyone, > > I've started applying the developer guide standards to the gt-ysld module, > keeping notes in this gist: > > https://gist.github.com/mattkrusz/b010eb29aa784025a639c473b768801e > I don't a

Re: [Geotools-devel] Promoting gt-ysld to a supported module

Hello everyone, I've started applying the developer guide standards to the gt-ysld module, keeping notes in this gist: https://gist.github.com/mattkrusz/b010eb29aa784025a639c473b768801e Please take a look and provide any perspective you have on the current design -- things that definitely need t

Re: [Geotools-devel] Promoting gt-ysld to a supported module

I have performed an IP review of the gt-ysld codebase. Results here: https://github.com/geotools/geotools/pull/1438 This is my first time actually doing a proper IP review, so a reveiw would be appreciated before I merge it into the codebase. Thanks, Torben On Fri, Jan 20, 2017 at 3:13 PM, Torb

Re: [Geotools-devel] Promoting gt-ysld to a supported module

I've added some documentation to the user manual (mostly pulled from the YSLD README.md). YSLD Documentation PR here: https://github.com/geotools/geotools/pull/1437 Justin - thanks for the response. Torben On Fri, Jan 20, 2017 at 1:44 PM, Justin Deoliveira wrote: > Hey Torben, > > Thanks for p

Re: [Geotools-devel] Promoting gt-ysld to a supported module

Hey Torben, Thanks for pushing this forward. I am happy to keep my name on as module maintainer list as long as others see fit. I know I haven’t been the most active maintainer over the past while but unfortunately my involvement is driven by requirements from project work. That said if someone el

[Geotools-devel] Promoting gt-ysld to a supported module

Hello All, I am hoping to promote gt-ysld to a supported module. There are still a number of things that need to be done before this module is ready to be promoted; I will be tackling these over the next few weeks, with the aim of having gt-ysld be a supported module for GeoTools 16.2 next month.