Re: [Geotools-devel] Pushing GeoGit module out of the build?

2012-12-18 Thread Andrea Aime
On Tue, Dec 18, 2012 at 4:16 AM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au wrote: Thanks, Gabriel. I see you have removed geogit-versioned (and the dependency in the top-level pom). I do not think it was a problem since Mark disabled it in September, but it is clearer to have one copy.

[Geotools-devel] Pushing GeoGit module out of the build?

2012-12-17 Thread Andrea Aime
Hi, the geogit module tests are currently blocking the improvement contained in https://jira.codehaus.org/browse/GEOT-4351 Given that an intention to remove the module from GeoTools has already been expressed, and that we cannot get a feedback from the people involved in GeoGit, I'd say we just

Re: [Geotools-devel] Pushing GeoGit module out of the build?

2012-12-17 Thread Ben Caradoc-Davies
Andrea, tl;dr: please go ahead I do not understand why geogit-versioned is still in your build (unless you are building with -Pgeogit-versioned). I build with -Dall and geogit-versioned is not built for me (on master). According to the git logs, Mark kicked geogit-versioned out of the -Dall

Re: [Geotools-devel] Pushing GeoGit module out of the build?

2012-12-17 Thread christian . mueller
As an aside, this exemplifies a principle: unsupported modules cannot block necessary changes to supported modules and are kicked out of the build if nobody cares enough to keep them building. This is my understanding too. Christian

Re: [Geotools-devel] Pushing GeoGit module out of the build?

2012-12-17 Thread Andrea Aime
On Mon, Dec 17, 2012 at 10:32 AM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au wrote: Andrea, tl;dr: please go ahead I do not understand why geogit-versioned is still in your build (unless you are building with -Pgeogit-versioned). I build with -Dall and geogit-versioned is not built

Re: [Geotools-devel] Pushing GeoGit module out of the build?

2012-12-17 Thread Ben Caradoc-Davies
On 17/12/12 17:50, Andrea Aime wrote: Regardless, the store seems to be in their repo so this change would likely end up breaking their build. Ah! They are downstream and consuming GeoTools master artifacts whose behaviour you are about to change? This is master, where behaviour and APIs

Re: [Geotools-devel] Pushing GeoGit module out of the build?

2012-12-17 Thread Andrea Aime
On Mon, Dec 17, 2012 at 11:15 AM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au wrote: On 17/12/12 17:50, Andrea Aime wrote: Regardless, the store seems to be in their repo so this change would likely end up breaking their build. Ah! They are downstream and consuming GeoTools master

Re: [Geotools-devel] Pushing GeoGit module out of the build?

2012-12-17 Thread Jody Garnett
That is fine Gabriel, Mark should of removed it when work was stopped, but wanted to coordinate with you so the work was not lost. Thanks for removing now, and apologises if communication was haphazard on this one. -- Jody Garnett On Tuesday, 18 December 2012 at 12:50 AM, Gabriel Roldan

Re: [Geotools-devel] Pushing GeoGit module out of the build?

2012-12-17 Thread Ben Caradoc-Davies
Thanks, Gabriel. I see you have removed geogit-versioned (and the dependency in the top-level pom). I do not think it was a problem since Mark disabled it in September, but it is clearer to have one copy. Kind regards, Ben. On 17/12/12 22:50, Gabriel Roldan wrote: I'm currently waiting for