Re: [Geotools-devel] RasterSymbolizerHelper: 16-bit raster content, change proposal

2015-10-21 Thread Simone Giannecchini
Ciao Ville, let me know if you need some directions on this. The change in GeoServer might not be _that_ trivial. Regards, Simone Giannecchini == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Simone Giannecchini @simogeo Founder/Dire

Re: [Geotools-devel] RasterSymbolizerHelper: 16-bit raster content, change proposal

2015-10-19 Thread Ville Karppinen
Ciao Simone, This change would give 16-bit target images only for GS queries that use GS style similar to &style=raster and &format=image/tiff or geotiff or png. So, this should only have an effect on tiff/geotiff/png image formats and only if GS style uses RasterSymbolizer without ColorMap.

Re: [Geotools-devel] RasterSymbolizerHelper: 16-bit raster content, change proposal

2015-10-18 Thread Simone Giannecchini
Ciao Ville, I have recently reviewed work on the rastersymbolizer to enhance contrast stretch capabilities (more should come shortly) and I also tried to hack in again the support for 16 bits in a comprehensive way. You change is ok but of my memory serves me right is not enough. Couple of questi

Re: [Geotools-devel] RasterSymbolizerHelper: 16-bit raster content, change proposal

2015-10-16 Thread Daniele Romagnoli
Hi Ville, I'm one of the devs involved with raster processing. As reported by Andrea, I'm a bit busy with setting up a couple of proposals for GT and GS and preparing pull requests. I would like to reserve some time on monday to take a look at your code. Hopefully, I'll be back with some feedbacks

Re: [Geotools-devel] RasterSymbolizerHelper: 16-bit raster content, change proposal

2015-10-16 Thread Ville Karppinen
Hi Jody, I am not aware of any JIRA ticket related to this issue and I have not created one. I was thinking that I just ask green light here before sending the pull request in GitHub. I would say this is just a small regression fix in the implementation point of view and there is no need for

Re: [Geotools-devel] RasterSymbolizerHelper: 16-bit raster content, change proposal

2015-10-15 Thread Andrea Aime
Hi Ville, the raster devs are pretty slammed these days, I think what you're proposing is fine but do allow some days for them to look into it Cheers Andrea On Wed, Oct 14, 2015 at 11:29 AM, Ville Karppinen wrote: > Hi, > > I have a change proposal for you on how GeoTools should handle 16-bit >

Re: [Geotools-devel] RasterSymbolizerHelper: 16-bit raster content, change proposal

2015-10-15 Thread Jody Garnett
I am all for fixing a regression in functionality, do you have a specific bug report in mind here? It sounds like you have a fix in mind, if this is just a regression I do not think a change request will be required. If you need an API change then we can go through the usual channels (make a wiki

[Geotools-devel] RasterSymbolizerHelper: 16-bit raster content, change proposal

2015-10-14 Thread Ville Karppinen
Hi, I have a change proposal for you on how GeoTools should handle 16-bit raster content. At the moment, geotools rescales 16-bit (ushort) source raster content to 8-bit. In case of 16-bit source raster data, this may result to target image that has lost valuable information, which in some use