Re: [Geotools-devel] SLD utility vs SLDStyleFactory internal methods

2010-03-04 Thread Michael Bedward
On 4 March 2010 18:34, Andrea Aime wrote: > The new StyleBuilder was originally developed by me, but I stopped > when it was in an incomplete state because... well, because I don't > need it, I just wanted to explore a little a complex builder. > > Jody took it over and I think he pushed it much fu

Re: [Geotools-devel] SLD utility vs SLDStyleFactory internal methods

2010-03-03 Thread Andrea Aime
Michael Bedward ha scritto: > Ah, I meant your new StyleBuilder Jody > > On 4 March 2010 12:57, Jody Garnett wrote: >> I had a brief chat with andrea. He has not interest in proceeding with >> StyleBuilder (I am going to look over it critically myself). The new StyleBuilder was originally develo

Re: [Geotools-devel] SLD utility vs SLDStyleFactory internal methods

2010-03-03 Thread Michael Bedward
Ah, I meant your new StyleBuilder Jody On 4 March 2010 12:57, Jody Garnett wrote: > I had a brief chat with andrea. He has not interest in proceeding with > StyleBuilder (I am going to look over it critically myself). --

Re: [Geotools-devel] SLD utility vs SLDStyleFactory internal methods

2010-03-03 Thread Jody Garnett
I had a brief chat with andrea. He has not interest in proceeding with StyleBuilder (I am going to look over it critically myself). I am going to split uDig way from the SLD class; leaving Andrea to change to returning float. Jody On Thu, Mar 4, 2010 at 11:56 AM, Michael Bedward wrote: > It wou

Re: [Geotools-devel] SLD utility vs SLDStyleFactory internal methods

2010-03-03 Thread Michael Bedward
It would be great to use the new StyleBuilder but there will still be a need for those methods in SLD that query Styles won't there ? In other words, should the plan be to pull out all of the building methods from SLD, once StyleBuilder is in business, and tidy up the remaining query methods ? Mi

Re: [Geotools-devel] SLD utility vs SLDStyleFactory internal methods

2010-03-03 Thread Jody Garnett
Okay next suggestion (helpful this time). uDig actually uses a subclass of SLD (called SLDs ... sigh). I will just copy the methods over and break that link; leaving GeoTools free to change. As I said I would like to migrate away from using this class. Now that still may not be a useful suggest

Re: [Geotools-devel] SLD utility vs SLDStyleFactory internal methods

2010-03-03 Thread Michael Bedward
I'd vote to fix the offending methods at the expense of backwards compatibility. It seems unlikely that this will cause anything other than minor inconvenience for users. As an aside, I remember that the SLD class grew larger when the FOSS4G tutorials were being prepared and we're advertising it (

Re: [Geotools-devel] SLD utility vs SLDStyleFactory internal methods

2010-03-03 Thread Andrea Aime
Jody Garnett ha scritto: > So far uDig is the major user of the SLD class. I am trying to migrate away > from it to a StyleBuilder :-( > > Can you change the return type to a float (cannot remember which direction > automatic casting is allowed). > > int width = SLD.width( stroke ); // does th

Re: [Geotools-devel] SLD utility vs SLDStyleFactory internal methods

2010-03-03 Thread Jody Garnett
So far uDig is the major user of the SLD class. I am trying to migrate away from it to a StyleBuilder :-( Can you change the return type to a float (cannot remember which direction automatic casting is allowed). int width = SLD.width( stroke ); // does this work when SLD returns a float? If n

[Geotools-devel] SLD utility vs SLDStyleFactory internal methods

2010-03-03 Thread Andrea Aime
Hi, today I've stumbled into a class that I did not know existed, the SLD utility class (well, I actually made a commit on that class three years ago but haven't used it since). The SLD utility has utility methods that return, for example, the width of a stroke. Unfortunately they are also broken,