Re: [Geotools-devel] SLDParser and internal usage of FilterFactory(2) & ExpressionDOMParser

Jody, thanks for the links to proposal. I've had a look at CommonFactoryFinder.getFilterFactory2() an expected something different. My expectetion was a service registration as org.opengis.filter.FilterFactory2 (META-INF/services) but could not find any. My read of the hint

Re: [Geotools-devel] SLDParser and internal usage of FilterFactory(2) & ExpressionDOMParser

Frank here is a propsal https://github.com/geotools/geotools/wiki/Simplify-FilterFactory if you think this is something we can work on. While writing this up I found the original proposal to clean up the difference between the two

Re: [Geotools-devel] SLDParser and internal usage of FilterFactory(2) & ExpressionDOMParser

Frank I expect this is a case of not being aggressive enough with updating interfaces in GeoTools. When FilterFactory2 was added we were very cautious about updating interfaces because of GeoAPI approval/review/feedback. Since that time we have added additional methods (such as the temporal

Re: [Geotools-devel] SLDParser and internal usage of FilterFactory(2) & ExpressionDOMParser

> The class has a setter, which would have to be removed (instead of just being deprecated). > That's not our normal API removal cycle (first deprecate, then remove), but it is allowed in exceptional cases. > In this case I don't see a valid enough reason to break downstream apps that might be

Re: [Geotools-devel] SLDParser and internal usage of FilterFactory(2) & ExpressionDOMParser

On Mon, May 17, 2021 at 8:48 AM Frank Gasdorf via GeoTools-Devel < geotools-devel@lists.sourceforge.net> wrote: > Hi folks, > > I stumbled about the SLDParser while I wass looking for final field > initializations with CommonFactoryFinder.getXXX > > However, I'm not sure about whether it was by

[Geotools-devel] SLDParser and internal usage of FilterFactory(2) & ExpressionDOMParser

Hi folks, I stumbled about the SLDParser while I wass looking for final field initializations with CommonFactoryFinder.getXXX However, I'm not sure about whether it was by intension but internally ther is a cast from FilterFactory to FilterFactory2 on initailization an ExpressionDOMParser. This