Re: [Geotools-devel] Understanding JTS last minute upgrade

2019-02-21 Thread Ian Turton
Yes, I agree. Ian On Thu, 21 Feb 2019 at 06:13, Andrea Aime wrote: > That sounds good to me... We can have it sit on master for some time and > then backport if there are no issues? > > Cheers > Andrea > > Il mer 20 feb 2019, 23:19 Jody Garnett ha > scritto: > >> Reviewing release notes: >> ht

Re: [Geotools-devel] Understanding JTS last minute upgrade

2019-02-20 Thread Andrea Aime
That sounds good to me... We can have it sit on master for some time and then backport if there are no issues? Cheers Andrea Il mer 20 feb 2019, 23:19 Jody Garnett ha scritto: > Reviewing release notes: > https://github.com/locationtech/jts/releases/tag/jts-1.16.1 show > HilbertCode and MortonC

Re: [Geotools-devel] Understanding JTS last minute upgrade

2019-02-20 Thread Jody Garnett
Reviewing release notes: https://github.com/locationtech/jts/releases/tag/jts-1.16.1 show HilbertCode and MortonCode (new functionality), improved InteriorPointArea performance/robustness and some bug fixes. While we took on this upgrade to solve a bug reported during our RC testing I I am not int

Re: [Geotools-devel] Understanding JTS last minute upgrade

2019-02-20 Thread Nuno Oliveira
Hi all, This is indeed quite a big change, I quickly pick up a few commits, that didn't look like documentation or tests changes: * https://github.com/locationtech/jts/commit/a65cc2fac737e7741b43b1558bc84c32b007f33c * https://github.com/locationtech/jts/commit/d663567a6a0091a750351c9b3e87074025

Re: [Geotools-devel] Understanding JTS last minute upgrade

2019-02-20 Thread Simone Giannecchini
The joy of the last-minute-change-that-is-not-supposed-to-break-anything! Regards, Simone Giannecchini == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services for more information. == Ing. Simone Giannecchini @simogeo Founder/Director GeoSolutions S.A.S. Via di Montra

Re: [Geotools-devel] Understanding JTS last minute upgrade

2019-02-20 Thread Ian Turton
This does look like a big change at the last minute. However on a quick review it does look like most of the changes are to tests or are documentation changes. But there are some actual code changes too, so without a longer review I would be against this change just before the release. Ian On Wed

[Geotools-devel] Understanding JTS last minute upgrade

2019-02-19 Thread Andrea Aime
Hi, so Jody is releasing GeoTools 21.0 after upgrading from JTS 1.16.0 to 1.16.1, last minute, without having the changes around for any useful amount of time: https://github.com/geotools/geotools/commit/7e0fa08aa877616662eba8baec30f0a1776f9434 I was against it, but Jody claims it's only a bug fix