Re: [Geotools-devel] Upgrading our connection pool library

2014-06-04 Thread Andrea Aime
On Wed, Jun 4, 2014 at 8:48 AM, Ben Caradoc-Davies < ben.caradoc-dav...@csiro.au> wrote: > Connections must be idle for at least 5 minutes (and up to 10) with these > settings: > > minEvictableIdleTimeMillis="30" > timeBetweenEvictionRunsMillis="30" > > If requests are very infrequent, the

Re: [Geotools-devel] Upgrading our connection pool library

2014-06-03 Thread Ben Caradoc-Davies
Connections must be idle for at least 5 minutes (and up to 10) with these settings: minEvictableIdleTimeMillis="30" timeBetweenEvictionRunsMillis="30" If requests are very infrequent, then I agree that they will be much slower. For more frequent requests there should be no loss of perfo

Re: [Geotools-devel] Upgrading our connection pool library

2014-06-03 Thread Andrea Aime
On Wed, Jun 4, 2014 at 8:37 AM, Ben Caradoc-Davies < ben.caradoc-dav...@csiro.au> wrote: > What about minIdle=0? That seemed to fix my problems with firewalls > between GeoServer and the database. > Yes, that combination would work, but the cure will imho damage the patient in the process, as it

Re: [Geotools-devel] Upgrading our connection pool library

2014-06-03 Thread Ben Caradoc-Davies
What about minIdle=0? That seemed to fix my problems with firewalls between GeoServer and the database. (Still supporting upgrade to DBCP 2.0.) On 04/06/14 14:35, Andrea Aime wrote: > Those are supported, but they are not useful, as the pool won't evict > connections > below the minIdle threshol

Re: [Geotools-devel] Upgrading our connection pool library

2014-06-03 Thread Andrea Aime
On Wed, Jun 4, 2014 at 3:19 AM, Ben Caradoc-Davies < ben.caradoc-dav...@csiro.au> wrote: > So DBCP 1.4 does not support > minEvictableIdleTimeMillis/timeBetweenEvictionRunsMillis > or equivalent? > http://docs.geoserver.org/latest/en/user/data/app- > schema/data-stores.html#jndi Those are suppo

Re: [Geotools-devel] Upgrading our connection pool library

2014-06-03 Thread Ben Caradoc-Davies
So DBCP 1.4 does not support minEvictableIdleTimeMillis/timeBetweenEvictionRunsMillis or equivalent? http://docs.geoserver.org/latest/en/user/data/app-schema/data-stores.html#jndi +1 for upgrade to DBCP 2.0 based on our positive experience with 1.4. Kind regards, Ben. On 03/06/14 16:40, Andrea

Re: [Geotools-devel] Upgrading our connection pool library

2014-06-03 Thread Christian Mueller
+1 from here On Tue, Jun 3, 2014 at 1:19 PM, Ian Turton wrote: > +1 from me > > Ian > > > On 3 June 2014 09:40, Andrea Aime wrote: > >> On Mon, Apr 28, 2014 at 4:31 PM, Justin Deoliveira < >> jdeol...@boundlessgeo.com> wrote: >> >>> I'll take the conservative approach of "if it ain't broke don

Re: [Geotools-devel] Upgrading our connection pool library

2014-06-03 Thread Ian Turton
+1 from me Ian On 3 June 2014 09:40, Andrea Aime wrote: > On Mon, Apr 28, 2014 at 4:31 PM, Justin Deoliveira < > jdeol...@boundlessgeo.com> wrote: > >> I'll take the conservative approach of "if it ain't broke don't fix it". >> With the java7 upgrade still ongoing we already have enough moving

Re: [Geotools-devel] Upgrading our connection pool library

2014-06-03 Thread Andrea Aime
On Mon, Apr 28, 2014 at 4:31 PM, Justin Deoliveira < jdeol...@boundlessgeo.com> wrote: > I'll take the conservative approach of "if it ain't broke don't fix it". > With the java7 upgrade still ongoing we already have enough moving parts so > perhaps we should put this one off for now since it does

Re: [Geotools-devel] Upgrading our connection pool library

2014-04-28 Thread Justin Deoliveira
I'll take the conservative approach of "if it ain't broke don't fix it". With the java7 upgrade still ongoing we already have enough moving parts so perhaps we should put this one off for now since it doesn't actually fix a known issue. But no strong opinion, just my $0.02 On Mon, Apr 28, 2014 at

Re: [Geotools-devel] Upgrading our connection pool library

2014-04-28 Thread Andrea Aime
On Mon, Apr 28, 2014 at 2:53 PM, Nuno Oliveira < nuno-miguel-olive...@telecom.pt> wrote: > Hi, > > (I think) Commons DBCP (incluing 2.0 version) is deprecated in favour of > tomcat-jdbc (a new connection pool implemented by tomcat guys ...): > > https://tomcat.apache.org/tomcat-7.0-doc/jdbc-pool.

Re: [Geotools-devel] Upgrading our connection pool library

2014-04-27 Thread Andrea Aime
On Sun, Apr 27, 2014 at 9:38 AM, Jody Garnett wrote: > Well if they are equal, and both require coding to upgrade we may be able > to check what is faster. > Yes, except my intention is asking was to see if anybody already knows or has had experiences with them. I have no mandate to work on a co

Re: [Geotools-devel] Upgrading our connection pool library

2014-04-27 Thread Jody Garnett
Well if they are equal, and both require coding to upgrade we may be able to check what is faster. Jody Garnett On Sun, Apr 27, 2014 at 5:33 PM, Andrea Aime wrote: > Hi, > I was checking the commons-dbcp web site and noticed DBCP 2.0 is out. > While they claim DBCP has higher performance, versi

[Geotools-devel] Upgrading our connection pool library

2014-04-27 Thread Andrea Aime
Hi, I was checking the commons-dbcp web site and noticed DBCP 2.0 is out. While they claim DBCP has higher performance, version 2.0 is not binary compatible with the 1.x series (and it requires Java 7, no big deal here). Since an upgrade would take some coding, I'm wondering about switching to the