Re: [Geotools-devel] base directory for file datastores

2013-07-10 Thread Andrea Aime
On Wed, Jul 10, 2013 at 12:23 AM, Niels Charlier wrote: > Jody, > > There is an additional issue. A lot of unit tests use paths with the > property data store, relative to the start-up directory rather than the > data directory. We need to avoid having to edit all those tests. > > I have found a

Re: [Geotools-devel] base directory for file datastores

2013-07-09 Thread Jody Garnett
Thanks Niels: I admit to being very sensitive about PropertyDataStore as its original goal is as a teaching aid for new GeoTools developers. As such I want it to be a very clear example, with few workarounds. I actually have a property-ng DataStore in the wings (based on ContentDataStore foun

Re: [Geotools-devel] base directory for file datastores

2013-07-09 Thread Niels Charlier
Jody, There is an additional issue. A lot of unit tests use paths with the property data store, relative to the start-up directory rather than the data directory. We need to avoid having to edit all those tests. I have found another solution working only from geoserver. Justin pointed me to t

Re: [Geotools-devel] base directory for file datastores

2013-07-09 Thread Jody Garnett
Hi Niels: Well what you describe is a valid use case, and worth adding to GeoTools (just in a way that does not break the Factory). The easiest thing I can think of is to make: final File base; And to set it to the current directory in the no-argument constructor (use by FactoryFinder), and

Re: [Geotools-devel] base directory for file datastores

2013-07-09 Thread Niels Charlier
Hello Jody, Thank you for the reviewing the code. The issue came from setting up a data directory for the csw cite tests using property files. I found that there was no way to set up the data configuration using a relative path to refer to the directory with properties files. I admit I simp

Re: [Geotools-devel] base directory for file datastores

2013-07-09 Thread Justin Deoliveira
On Tue, Jul 9, 2013 at 6:26 AM, Andrea Aime wrote: > On Tue, Jul 9, 2013 at 6:00 AM, Jody Garnett wrote: > >> I have been having an interesting time reviewing a recent pull request >> for PropertyDataStore: >> - https://github.com/geotools/geotools/pull/221 >> >> The concept introduces the idea o

Re: [Geotools-devel] base directory for file datastores

2013-07-09 Thread Andrea Aime
On Tue, Jul 9, 2013 at 6:00 AM, Jody Garnett wrote: > I have been having an interesting time reviewing a recent pull request > for PropertyDataStore: > - https://github.com/geotools/geotools/pull/221 > > The concept introduces the idea of a base directory (apparently shared > with HT DataStore .

[Geotools-devel] base directory for file datastores

2013-07-08 Thread Jody Garnett
I have been having an interesting time reviewing a recent pull request for PropertyDataStore: - https://github.com/geotools/geotools/pull/221 The concept introduces the idea of a base directory (apparently shared with HT DataStore .. and others?). Rough idea is to provide a geotools specific al