Re: [Geotools-devel] imagemosaic-jdbc pgraster blobAttributeName (and fix)

2016-07-19 Thread Frank Gevaerts
Hi Christian, I've added issues for both bugfixes. They're GEOT-5462 and GEOT-5463. I've updated the PR to mention those ids in the commit messages. Frank On Mon, Jul 18, 2016 at 06:38:20PM +0200, Christian Mueller wrote: > Hi Frank > > Thanks for the PR, I will check it within this week. > Do

Re: [Geotools-devel] imagemosaic-jdbc pgraster blobAttributeName (and fix)

2016-07-18 Thread Christian Mueller
Hi Frank Thanks for the PR, I will check it within this week. Do we have a JIRA isssue for this fix ?. If not please add one. Cheers On Mon, Jul 18, 2016 at 12:41 PM, Frank Gevaerts wrote: > On Sat, Jul 16, 2016 at 09:44:56AM +0200, Christian Mueller wrote: > > Hi Frank > > > > I have read thi

Re: [Geotools-devel] imagemosaic-jdbc pgraster blobAttributeName (and fix)

2016-07-18 Thread Frank Gevaerts
On Sat, Jul 16, 2016 at 09:44:56AM +0200, Christian Mueller wrote: > Hi Frank > > I have read this mail after reading the mail about the class cast > exception. Please prepare a "bugfix" pull request containing all the bugs > you have found. I've created PR#1240 with the two of them. Frank > Th

Re: [Geotools-devel] imagemosaic-jdbc pgraster blobAttributeName (and fix)

2016-07-16 Thread Christian Mueller
Hi Frank I have read this mail after reading the mail about the class cast exception. Please prepare a "bugfix" pull request containing all the bugs you have found. Thanks Christian On Fri, Jul 15, 2016 at 11:06 PM, Jody Garnett wrote: > Pull request is probably easier, since we can track comm

Re: [Geotools-devel] imagemosaic-jdbc pgraster blobAttributeName (and fix)

2016-07-15 Thread Jody Garnett
Pull request is probably easier, since we can track comments line by line. Goes without saying that any fix needs test case and docs (for a functionality change). Have you checked who the module maintainer is for imagemosaic-jdbc? -- Jody Garnett On 14 July 2016 at 08:33, Frank Gevaerts wrote:

[Geotools-devel] imagemosaic-jdbc pgraster blobAttributeName (and fix)

2016-07-14 Thread Frank Gevaerts
Hi, One place (getNoDataValue()) in the pgraster driver in imagemosaic-jdbc assumes that the raster column in the database is named 'rast', so setting blobAttributeName to something different doesn't work. I'm attaching a proposed fix. I can submit a PR if needed, but I'll wait for comments firs