See https://osgeo-org.atlassian.net/browse/GEOT-5515

Consider the following line in VariableAdapter

https://github.com/geotools/geotools/blob/master/modules/plugin/coverage-multidim/netcdf/src/main/java/org/geotools/imageio/netcdf/VariableAdapter.java#L1100

as compared to

https://github.com/geotools/geotools/blob/master/modules/plugin/coverage-multidim/netcdf/src/main/java/org/geotools/imageio/netcdf/VariableAdapter.java#L1076

I believe that, in the getTIndex method, tDimensionsIndex should be used instead of zDimensionIndex.

I wanted to ask the module maintainers: what kind of test coverage would you expect for this change? Currently this class is not being tested in an isolated way, and neither of these two methods are ever called from any of the unit tests. I kindly ask for your advise.


Kind Regards
Niels
------------------------------------------------------------------------------
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to