Hi Andrea,
Last time I tried I got the "license exceeded for geotools" error from
Jira/Atlassian. Today, when I try to login, I get a parachute, with text
"Joining Jira. Hang on a sec...", which is later appended by a "try again"
button.
I tried that three times, all the same affect. First going
Hi Michael,
anyone should be able to create a Jira ticket, given an account (which can
also be freely created).
Did you create the account and it still does not work?
Cheers
Andrea
On Mon, Nov 29, 2021 at 7:01 PM Michael Jung
wrote:
> Issued a pull request. I couldn't issue a Jira issue accordi
Issued a pull request. I couldn't issue a Jira issue accordingly, license
issues it says.
Michael
On Tue, Oct 19, 2021 at 09:05:42AM -0700, Jody Garnett wrote:
> Not really, you can also make such a method package visible (which
> depending on your viewpoint on encapsulation is slightly less visi
I have one testcase now that verifies the patch. (The private method
now calls a package method prepareForScaledAlphaChannel.)
+@Test(expected = Test.None.class /* No IllegalArgumentException */)
+public void testReattachScaledAlphaChannel() {
+BufferedImage bi = new BufferedImage
Not really, you can also make such a method package visible (which
depending on your viewpoint on encapsulation is slightly less visible than
protected).
--
Jody Garnett
On Mon, 18 Oct 2021 at 11:55, Michael Jung wrote:
> I guess hanging out means waiting here?
> I think, I can extract another
I guess hanging out means waiting here?
I think, I can extract another private method, turn it protected and test
it. (Is there a better approach to test private methods these days?)
Michael
On Fri, Oct 15, 2021 at 05:11:46PM -0700, Jody Garnett wrote:
> I am not that familiar with image workers
I am not that familiar with image workers myself, I think we should hang
out for a bit and ask for help in how to write test cases.
--
Jody Garnett
On Fri, 15 Oct 2021 at 03:39, Michael Jung wrote:
> I understand your policy, and I have tried complying. However, it is
> not that simple.
>
> The
I understand your policy, and I have tried complying. However, it is
not that simple.
The scale method is deeply entrenched in the ImageWorker and testing
this safety check would require me to refactor a lot of code that
I am not familiar with - or to reverse engineer my "big"
example until I find
Thanks for contacting us, it appears your fix is good safety check.
We do have the policy of only accepting pull requests with a test case; to
prevent regressions from occurring and prove to the review that the change
addresses the issue in questions. We have had too much technical debt
accumulate
