[PATCH] osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-05-05 Thread blobb
Hello Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2465 to look at the new patch set (#7). Introduce artifacts holding dependencies to speed up builds. Basically, osmo-build.sh holds logic to check whether the necessary artifact

osmo-gsm-tester[master]: fix: handle dbus signals outside of the glib main loop

2017-05-05 Thread Neels Hofmeyr
Patch Set 1: Code-Review-1 I was hoping to solve the issue where a given interface is not present yet despite the signal for its appearance being received, but in fact manual tests show that this still appears despite deferring signal handling in this patch. So the stupid wait loop for appeara

[PATCH] osmo-bts[master]: Signal to BSC when PCU disconnects

2017-05-05 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2288 to look at the new patch set (#3). Signal to BSC when PCU disconnects While at it - do not serialize NULL as a string when delivering OML Failure Report. Change-Id: I41a731bd719aee0bbb

[MERGED] osmo-gsm-tester[master]: ofono_client: drop explicit exception catching

2017-05-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: ofono_client: drop explicit exception catching .. ofono_client: drop explicit exception catching For some reason the code there catches exceptions ha

osmo-gsm-tester[master]: ofono_client: drop explicit exception catching

2017-05-05 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2485 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7731ed6ff3cad44ff437137abe2d6a424fcaa4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[PATCH] osmo-gsm-tester[master]: fix: handle dbus signals outside of the glib main loop

2017-05-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2486 fix: handle dbus signals outside of the glib main loop Collect incoming signals in a defer queue and handle them once the DBus polling is through. Related: OS#2220 Change-Id: Ic7520f2165888a4ee0f83b779cd58d20c4e45fa0 --- M src/osmo_gsm_tester/ofono_cl

[PATCH] osmo-gsm-tester[master]: ofono_client: drop explicit exception catching

2017-05-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2485 ofono_client: drop explicit exception catching For some reason the code there catches exceptions happening while interfaces are being established. That's not a good idea, drop it. Related: OS#2220 Change-Id: Ida7731ed6ff3cad44ff437137abe2d6a424fcaa4 --

openbsc[master]: Make BTS type and variant converters shareable

2017-05-05 Thread Max
Patch Set 9: > So all of them are osmo-bts but have various limitations/features in the Phy Well, yes - that's the motivation behind it - see 1614 for details. The thing to keep in mind though is that different phys might have different features enabled depending on sw/fw version. > Maybe do

[PATCH] openbsc[master]: Make BTS type and variant converters shareable

2017-05-05 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2286 to look at the new patch set (#9). Make BTS type and variant converters shareable * move value_string definition and corresponding functions for BTS type to shared heade

osmo-pcu[master]: fix PACCH paging: don't return early in case of NULL TBF

2017-05-05 Thread Neels Hofmeyr
Patch Set 3: https://osmocom.org/issues/2241 -- To view, visit https://gerrit.osmocom.org/2420 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib79f4a945e211a13ac7d1e511cc37b0940ac6202 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Br

[PATCH] osmo-pcu[master]: fix PACCH paging: don't return early in case of NULL TBF

2017-05-05 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2420 to look at the new patch set (#3). fix PACCH paging: don't return early in case of NULL TBF Commit b78a4a6dfef217c538d45949a6ae725e22a36b05 tried to fix a

[MERGED] osmo-gsm-tester[master]: resources: Fix path for gobi_3

2017-05-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: resources: Fix path for gobi_3 .. resources: Fix path for gobi_3 Change-Id: I10e5e56b6bec6c0b25db15af75d4cbd60fbbc7d9 --- M example/resources.conf 1

osmo-gsm-tester[master]: resources: Fix path for gobi_3

2017-05-05 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2483 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e5e56b6bec6c0b25db15af75d4cbd60fbbc7d9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[PATCH] osmo-gsm-tester[master]: ofono_client: Implement network registration during connect()

2017-05-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/2484 ofono_client: Implement network registration during connect() Also add a new simple test to check network registration is working Change-Id: I3092edc3dd76131da9aeeef6ad5082d1a9009342 --- M src/osmo_gsm_tester/ofono_client.py M src/osmo_gsm_tester/osmo_

[PATCH] osmo-gsm-tester[master]: resources: Fix path for gobi_3

2017-05-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/2483 resources: Fix path for gobi_3 Change-Id: I10e5e56b6bec6c0b25db15af75d4cbd60fbbc7d9 --- M example/resources.conf 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/83/2483/1 diff --git

[PATCH] openbsc[master]: Gb: use textual representation for parse log

2017-05-05 Thread Max
Gb: use textual representation for parse log Use textual representation for message type and protocol descriminator in case of Gb parsing errors. Change-Id: Ida925258be119619d8705361730c554a130b75bc Related: SYS#3610 --- M openbsc/src/gprs/gprs_gb_parse.c 1 file changed, 2 insertions(+), 3 delet

[PATCH] openbsc[master]: Gb: use textual representation instead for log

2017-05-05 Thread Max
Review at https://gerrit.osmocom.org/2482 Gb: use textual representation instead for log Use textual representation for message type and protocol descriminator in case of Gb parsing errors. Change-Id: Ida925258be119619d8705361730c554a130b75bc Related: SYS#3610 --- M openbsc/src/gprs/gprs_gb_pa

osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-05-05 Thread blobb
Patch Set 6: Fix formatting and adding link to test run of patchset 5: https://jenkins.blobb.me/job/openBSC_multi-configuration_withArtifacts_testRefactoring/65/ -- To view, visit https://gerrit.osmocom.org/2465 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: com

[MERGED] osmo-iuh[master]: contrib: Add systemd service file for osmo-hnbgw

2017-05-05 Thread daniel
daniel has submitted this change and it was merged. Change subject: contrib: Add systemd service file for osmo-hnbgw .. contrib: Add systemd service file for osmo-hnbgw Change-Id: I650bb5650b6d4f474e2040b57e6f78ee9d013825 --- A

[MERGED] osmo-iuh[master]: examples: Adjust IP address of example config

2017-05-05 Thread daniel
daniel has submitted this change and it was merged. Change subject: examples: Adjust IP address of example config .. examples: Adjust IP address of example config Change-Id: Ide4f1592c314f7a764bef30b76bdb21ce0fb6dc2 --- M doc/e

[PATCH] osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-05-05 Thread blobb
Hello Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2465 to look at the new patch set (#6). Introduce artifacts holding dependencies to speed up builds. Basically, osmo-build.sh holds logic to check whether the necessary artifact

osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-05-05 Thread blobb
Patch Set 5: I've merged both scripts, added documentation and changed code_style of variables, functions remain in camelCase. -- To view, visit https://gerrit.osmocom.org/2465 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifee0a2f837d

[PATCH] osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-05-05 Thread blobb
Hello Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2465 to look at the new patch set (#5). Introduce artifacts holding dependencies to speed up builds. Basically, osmo-build.sh holds logic to check whether the necessary artifact

osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-05-05 Thread blobb
Patch Set 4: (4 comments) Thanks for the review! I will collapse the two scripts to one (good point about the sourcing in different directory). Documentation will be added, especially about the "what need the script to provide, which sources osmo-build.sh" topic. The code_style will be cha