Max has submitted this change and it was merged.
Change subject: ctrl: cleanup trap creation
..
ctrl: cleanup trap creation
Move common trap create/send code into separate function.
Change-Id: Iaadc921b951aeb9b3ad5ab796e13d520
Patch Set 4:
> this should be merged in 2410. I think there's little point in
> first adding a (known) wrong table and then fix it up in a later
> commit?
2416 (this commit) touches the following lookup tables. These tables were
already they. They just get the offeset added:
static const uint
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2669
to look at the new patch set (#3).
Add JUnit XML reports; refactor test reporting
* Add Junit output file support
* Differentiate between an expected failure test and an
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2670
to look at the new patch set (#2).
Handle termination signals to exit gracefully and prevent resource leak
Make sure we free the reserved resources and kill launched subprocesses
before
Review at https://gerrit.osmocom.org/2672
Add JUnit XML reports; refactor test reporting
* Add Junit output file support
* Differentiate between an expected failure test and an error in the
test, as described in JUnit.
* In case of an error/exception during test, record and attach it to the
Tes
Pau Espin Pedrol has abandoned this change.
Change subject: Add JUnit XML reports; refactor test reporting
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2672
To unsubscribe, visit https://gerrit.osmocom.org/setting
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2416
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I471a767c7974bdacadc3233d0c3e7b7965f6eafa
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2410
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23fba50f48415314da40cf5bf86fce2ed3e66af6
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2389
to look at the new patch set (#5).
measurement: Improve log output
The debug log does not print much information about the measured
rxlev and rxqual values. This commit ad
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2416
to look at the new patch set (#5).
measurement: exclude idle channels from uplink measurement.
The DATA-IND, received from the physical layer does not only include the act
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2412
to look at the new patch set (#5).
measurement: fix measurement computation
Timing advance is currently not taken into account when computing
the measurement results, this
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2417
to look at the new patch set (#5).
octphy: integrate channel measurement handling
recent octphy firmware versions do support proper channel measurement handling.
The new implementation
Review at https://gerrit.osmocom.org/2673
Fix typo in logging
DL-TBD was errorneously printed as UL-TBF.
Change-Id: I94a224c0339a062e4c8d5aa6c4c858f3f0298a0d
---
M src/bts.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/73/267
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2654
to look at the new patch set (#2).
Cleanup FN scheduling
* replace magic number with defined constant
* move copy-pasted code to inline functions
* remove unused code
Change-Id: I6fee0
Review at https://gerrit.osmocom.org/2675
libosmocoding: decode MCS-0 properly
As MCS-0 is effectively CS-0, call corresponding decode function instead
of returning error code.
Change-Id: I424f7b5494846d2d5cf890f99251dae4ad5bd7d1
---
M src/coding/gsm0503_coding.c
1 file changed, 2 insertions(+
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2416
to look at the new patch set (#6).
measurement: exclude idle channels from uplink measurement
The DATA-IND, received from the physical layer does not only include the actu
Review at https://gerrit.osmocom.org/2676
ofono_client: Discover modem path from imsi
Change-Id: Ib9f4de81abc18e8db0c15df965e4811b6513e1b1
---
M example/resources.conf
M src/osmo_gsm_tester/ofono_client.py
M src/osmo_gsm_tester/osmo_nitb.py
3 files changed, 65 insertions(+), 14 deletions(-)
Patch Set 1: Code-Review-1
There's been issue observed with egprs (with and without this patch), let's not
merge this until it's clarified.
--
To view, visit https://gerrit.osmocom.org/2675
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/2677
Remove errorneous include
The gsm_data_shared.h header is installable and used by OsmoBTS so it
should not include any private (non-installable headers) to avoid
OsmoBTS' build failures.
Change-Id: Ic25031101fc01bd732fe691132c081ad05fa6a4b
---
M openbs
Patch Set 3: Code-Review-1
(14 comments)
Thanks! I still have some complaints though, sorry if I'm a bit pedantic, but
trying to make optimal choices for later code maintenance...
https://gerrit.osmocom.org/#/c/2669/3/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 124:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2670/1/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 313: finally:
> what do you mind? can I have a "finally:" clause without a "try:" ?
I meant: do you really need to register signal handlers? isn't this
't
Patch Set 1: Code-Review-1
(8 comments)
some code structuring issues, looks good otherwise.
https://gerrit.osmocom.org/#/c/2676/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 84: def modem_is_powered(modem_obj, val):
first reflex: if it requires a mode
Patch Set 1:
one more thing: also remove "modem[].path" from resource.py:RESOURCES_SCHEMA
--
To view, visit https://gerrit.osmocom.org/2676
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f4de81abc18e8db0c15df965e4811b6513e1b1
Gerrit-P
Patch Set 3:
(13 comments)
https://gerrit.osmocom.org/#/c/2669/1//COMMIT_MSG
Commit Message:
Line 7: Add JUnit XML reports; refactor test reporting
> ah yes, and let's make this 'add JUnit XML reports; refactor test reporting
Done
https://gerrit.osmocom.org/#/c/2669/3/src/osmo_gsm_tester/suit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2670/1/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 313: finally:
> I meant: do you really need to register signal handlers? isn't this 'try:..
The default signal handler (KeyboardInterrupt) doesn't work in
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2677
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic25031101fc01bd732fe691132c081ad05fa6a4b
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Neels Hofmeyr has submitted this change and it was merged.
Change subject: Remove errorneous include
..
Remove errorneous include
The gsm_data_shared.h header is installable and used by OsmoBTS so it
should not include any priv
Patch Set 1:
(4 comments)
I guess I'm not removing "modem[].path" from resource.py:RESOURCES_SCHEMA
because it can still be used as explained on my other comments.
https://gerrit.osmocom.org/#/c/2676/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 96:
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2676
to look at the new patch set (#2).
ofono_client: Discover modem path from imsi
Change-Id: Ib9f4de81abc18e8db0c15df965e4811b6513e1b1
---
M example/resources.conf
M src/osm
Review at https://gerrit.osmocom.org/2678
apply rename of resource nitb_iface to eth_iface
See osmo-gsm-tester change-id I829903d7b2111ab5ee106bce52d6121204a5a401
Change-Id: Icbbb7d921e7340739883650f778d5a7341840875
---
M OsmoGSMTester/chapters/config.adoc
M OsmoGSMTester/chapters/intro.adoc
2
Review at https://gerrit.osmocom.org/2681
rename resource nitb_iface to eth_iface
I would like to use the interface addresses also for OsmoBSC processes. The
only real distinction we need is public versus loopback interface. So 'eth'
indicates public, while 'lo_iface' or 'loopback_iface' can be
Review at https://gerrit.osmocom.org/2679
contrib: add jenkins-build-osmo-msc.sh
Change-Id: I46e34f70d66558b755426b456562df08d1a3b62c
---
A contrib/jenkins-build-osmo-msc.sh
1 file changed, 78 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes
Review at https://gerrit.osmocom.org/2680
add test api to run OsmoMSC and OsmoBSC
Change-Id: I6397dafc8b7aa75cc09c6f74cf0616cc3840b996
---
A src/osmo_gsm_tester/osmo_msc.py
1 file changed, 173 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes
Neels Hofmeyr has abandoned this change.
Change subject: add test api to run OsmoMSC and OsmoBSC
..
Abandoned
it's a bit too soon, accidental push
--
To view, visit https://gerrit.osmocom.org/2680
To unsubscribe, visit https:
Neels Hofmeyr has abandoned this change.
Change subject: contrib: add jenkins-build-osmo-msc.sh
..
Abandoned
it's a bit too soon, accidental push
--
To view, visit https://gerrit.osmocom.org/2679
To unsubscribe, visit https:/
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2681
to look at the new patch set (#2).
rename resource nitb_iface to eth_iface
I would like to use the interface addresses also for OsmoBSC processes. The
only real distinction we need is p
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2669
to look at the new patch set (#4).
Add JUnit XML reports; refactor test reporting
* Add Junit output file support
* Differentiate between an expected failure test and an
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2669
to look at the new patch set (#5).
Add JUnit XML reports; refactor test reporting
* Add Junit output file support
* Differentiate between an expected failure test and an
Patch Set 3:
(10 comments)
some more comments. I thought this would be quick, but I must see that I was
wrong; the junit composition is quick, but the changes needed to handle things
are more complex than I initially expected.
The comments are spread across two patch-sets, because answering t
Patch Set 5:
(10 comments)
will my comments ever end!? I feel apologetic to complain about so many things
... but I'd rather have a high coding standard. (Please be as strict with me in
turn)
I promise to merge soon so we can carry on with other tasks.
https://gerrit.osmocom.org/#/c/2669/5/s
Review at https://gerrit.osmocom.org/2682
tests/Makefile.am: do not test disabled features
Compiling tests for disabled features breaks build.
Change-Id: Iebcc24b493092a5a8e3561d7642a0b4608a8beae
---
M tests/Makefile.am
1 file changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit
Patch Set 2: Code-Review-1
(3 comments)
In general, looks fine to me. As soon as my warnings
would be addressed, I'll give CR+1.
P.S. Thanks! This is the final step in GSM 05.03 migration.
https://gerrit.osmocom.org/#/c/2674/2/src/osmo-bts-trx/scheduler_trx.c
File src/osmo-bts-trx/scheduler_tr
42 matches
Mail list logo
