Review at https://gerrit.osmocom.org/2690
ssedetect: call __builtin_cpu_supports() only if supported
Some compilers don't support the __builtin_cpu_supports built-in,
so let's make them able to compile the project anyway.
Change-Id: I0c90402d8e4c9f196c54b066ff30891c8de3ad2b
---
M Transceiver52
Review at https://gerrit.osmocom.org/2686
buildenv: actually strip unused cpuid functionality
Despite the macro message says, that cpuid functionality was stripped
it was still partially preset and wasn't used anyhow.
Change-Id: I380bc9c13d29319685781ef27973afe6744fcf3d
---
D config/ax_gcc_x86
Review at https://gerrit.osmocom.org/2688
buildenv: cosmetic changes
Change-Id: I9c52f2981513fa6322bdf992215e3e099ac3ddee
---
M config/ax_sse.m4
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/88/2688/1
diff --git a/config/ax_ss
Review at https://gerrit.osmocom.org/2689
buildenv: check for __builtin_cpu_supports call support
The '__builtin_cpu_supports' is a GCC's built-in function which
returns a positive integer if the run-time CPU supports specified
SIMD feature and returns 0 otherwise.
This change adds a new check
Review at https://gerrit.osmocom.org/2687
buildenv: fix build on systems without SIMD support
HAVE_SSE3 and HAVE_SSE4_1 were never defined if CPU architecture
doesn't match the (86*|x86_64*|amd64*) condition.
Change-Id: I3350b14dbc91e9b388d0b04a0ed22ba27d436313
---
M config/ax_sse.m4
1 file ch
Review at https://gerrit.osmocom.org/2685
buildenv: correct the ax_sse macro description
Change-Id: I4ce65443c8a33ae9add8f6da9d911c3178472ab2
---
M config/ax_sse.m4
1 file changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/85/2685/1
diff
Patch Set 9:
(1 comment)
https://gerrit.osmocom.org/#/c/2454/9/src/viterbi_sse.c
File src/viterbi_sse.c:
PS9, Line 68: M3 = _mm_or_si128(_mm_cmpgt_epi16(M3, M4), _mm_cmpeq_epi16(M3,
M4));
> Same >= vs > handling that we saw in the non-SSE case. SSE does not provide
Great! Thank you very much a
Patch Set 9:
(1 comment)
https://gerrit.osmocom.org/#/c/2454/9/src/viterbi_sse.c
File src/viterbi_sse.c:
PS9, Line 68: M3 = _mm_or_si128(_mm_cmpgt_epi16(M3, M4), _mm_cmpeq_epi16(M3,
M4));
Same >= vs > handling that we saw in the non-SSE case. SSE does not provide a
signed 16-bit integer great
Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2454
to look at the new patch set (#9).
core/conv: add x86 SSE support for Viterbi decoder
Fast convolutional decoding is provided through x86 intrinsic based
Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2454
to look at the new patch set (#8).
core/conv: add x86 SSE support for Viterbi decoder
Fast convolutional decoding is provided through x86 intrinsic based
Tom Tsou has submitted this change and it was merged.
Change subject: radioInterface: Remove UmTRX 'diversity' option
..
radioInterface: Remove UmTRX 'diversity' option
The 'diversity' option was an experimental 2 antenna recei
Tom Tsou has submitted this change and it was merged.
Change subject: debian: remove obsolete dependency
..
debian: remove obsolete dependency
This should fix package build for Ubuntu 17.04: obsolete package
hardening-wrapper w
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2400
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf
Gerrit-PatchSet: 3
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2186
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46752ccf5dbcffbec806081dec03e69a0fbdcdb7
Gerrit-PatchSet: 4
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit
Tom Tsou has submitted this change and it was merged.
Change subject: cosmetic: Add info about SSE support
..
cosmetic: Add info about SSE support
The osmo-trx binary outputs no info about its SSE support status.
This commits a
Tom Tsou has submitted this change and it was merged.
Change subject: buildenv: Split up SSE3 and SSE4.1 code
..
buildenv: Split up SSE3 and SSE4.1 code
Currently we find SSE3 and SSE4.1 code mixed togehter along with
generic c
Tom Tsou has submitted this change and it was merged.
Change subject: buildenv: Make build CPU invariant
..
buildenv: Make build CPU invariant
Currently the build environment checks which extension the current
CPU supports and
Tom Tsou has submitted this change and it was merged.
Change subject: cosmetic: remove code duplication
..
cosmetic: remove code duplication
The ARM and the X86 implementation of the conversion functions share
the same, non cpu
Tom Tsou has submitted this change and it was merged.
Change subject: ssedetect: Add runtime CPU detection
..
ssedetect: Add runtime CPU detection
The current implementation can select the SSE support level during
compiletime o
Tom Tsou has submitted this change and it was merged.
Change subject: Add test program to verify convolution implementation
..
Add test program to verify convolution implementation
Convolution is a complex process and we should
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2674
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b41bb1a8de655639107ec1f3b75afc240fd316f
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2676
to look at the new patch set (#3).
ofono_client: Discover modem path from imsi
Change-Id: Ib9f4de81abc18e8db0c15df965e4811b6513e1b1
---
M example/resources.conf
M src/osm
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2675
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I424f7b5494846d2d5cf890f99251dae4ad5bd7d1
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2683
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb8caf62ac653a39a7a82f2225e8edeab7f5afb5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 2:
(1 comment)
What about naming it "public_iface" rather than "eth_iface"? Then we have
public_iface vs lo_iface or private_iface. Instead of "public_iface" at some
point (msc+bsc split) we may want to have "uplink_iface" and "downlink_iface"
(which could be set to the same OS ifac
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2674
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b41bb1a8de655639107ec1f3b75afc240fd316f
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 2:
(1 comment)
The main issue is that it's a chicken-egg problem. I cannot properly identify a
modem until I use it, because we are identifying them using the IMSI and to
check which is the one I need to potentially power on all of them.
So, I guess to solve that, we would need at s
Patch Set 7:
(6 comments)
Thanks a lot for your review!
https://gerrit.osmocom.org/#/c/2465/7/scripts/osmo-build.sh
File scripts/osmo-build.sh:
Line 49: # # in jenkins' $WORKSPACE per default.
> like what. cd foo? ./configure && make install?
yes. Maybe a short real example of suc
Patch Set 1: Code-Review-1
Not to be merged. I have a newer version but still facing some issues sometimes
regarding the mt being unregistered.
--
To view, visit https://gerrit.osmocom.org/2484
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change
Pau Espin Pedrol has abandoned this change.
Change subject: Handle termination signals to exit gracefully and prevent
resource leak
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2670
To unsubscribe, visit https://
Review at https://gerrit.osmocom.org/2684
Handle termination signals to exit gracefully and prevent resource leak
Make sure we free the reserved resources and kill launched subprocesses
before stopping. Before this patch it was not the case for instance if we
received a SIGTREM signal from kill
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix '/include/openbsc ' to have no trailing space
..
fix '/include/openbsc ' to have no trailing space
The newline and $NULL manage to append a trailing
Neels Hofmeyr has abandoned this change.
Change subject: sysmo: use abspath of run dir, to fix scp of cfg to sysmobts
..
Abandoned
problem fixed by another abspath patch
--
To view, visit https://gerrit.osmocom.org/2606
To un
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Add JUnit XML reports; refactor test reporting
..
Add JUnit XML reports; refactor test reporting
* Add Junit output file support
* Differentiate betw
Patch Set 9: Code-Review+2
yay!
--
To view, visit https://gerrit.osmocom.org/2669
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedf6d912b3ccea187a4ac6d5c6b70fe9d5c5
Gerrit-PatchSet: 9
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2669
to look at the new patch set (#9).
Add JUnit XML reports; refactor test reporting
* Add Junit output file support
* Differentiate between an expected failure test and an
Review at https://gerrit.osmocom.org/2683
Remove redundant test
After switching to libosmocoding there's no need in low-level bursts
test which is part of libosmocoding anyway.
Change-Id: Icb8caf62ac653a39a7a82f2225e8edeab7f5afb5
---
M .gitignore
M configure.ac
M tests/Makefile.am
D tests/burs
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2669
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedf6d912b3ccea187a4ac6d5c6b70fe9d5c5
Gerrit-PatchSet: 8
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/2670/2/src/osmo-gsm-tester.py
File src/osmo-gsm-tester.py:
Line 200: except Exception:
> this is made stricter to not catch SystemExit? because we don't want to del
Indeed, otherwise SystemExit is dropped here (there's no raise, a
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2669
to look at the new patch set (#8).
Add JUnit XML reports; refactor test reporting
* Add Junit output file support
* Differentiate between an expected failure test and an
Patch Set 7:
(3 comments)
https://gerrit.osmocom.org/#/c/2669/7/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 109: self.fail_message = ''
> set these to None instead?
Done
Line 151: self.duration = round(time.time() - self.start_timestamp)
> you are roun
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/2676/2/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 70: def _wait(condition, condition_args, condition_kwargs, timeout,
timestep):
I'm confused, didn't I write this code? are you moving
Patch Set 1: -Code-Review
Ok, turned out to be local configuration issue. It doesn't fix the issue I've
aimed for but I still think it's a nice addition overall.
--
To view, visit https://gerrit.osmocom.org/2675
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: com
Patch Set 2: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/2670/2/src/osmo-gsm-tester.py
File src/osmo-gsm-tester.py:
Line 200: except Exception:
this is made stricter to not catch SystemExit? because we don't want to delay
by writing to a log file? (maybe place a comment)
Patch Set 7: Code-Review+1
(4 comments)
I like this now. Minor comments...
https://gerrit.osmocom.org/#/c/2669/7/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 109: self.fail_message = ''
set these to None instead?
Line 151: self.duration = round(time.ti
Patch Set 7: Code-Review-1
(12 comments)
thanks for working on this! Here is some more review...
https://gerrit.osmocom.org/#/c/2465/7/scripts/osmo-build.sh
File scripts/osmo-build.sh:
Line 23: # More information about those function are given in the following
template:
This is an example for
Hello Max, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2652
to look at the new patch set (#2).
Add missing _CFLAGS and _LIBS
These missing pieces go unnoticed if dependencies are not installed in
distinct directories.
Change-
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2669
to look at the new patch set (#7).
Add JUnit XML reports; refactor test reporting
* Add Junit output file support
* Differentiate between an expected failure test and an
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2669
to look at the new patch set (#6).
Add JUnit XML reports; refactor test reporting
* Add Junit output file support
* Differentiate between an expected failure test and an
Patch Set 4:
(3 comments)
https://gerrit.osmocom.org/#/c/2669/4/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 32: def __init__(self, fail_type='', fail_msg=''):
> * what exactly is the fail_type? is it junit specific? let's document here,
fail_type is just a keyword t
Patch Set 3:
(13 comments)
https://gerrit.osmocom.org/#/c/2669/3/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 124: if self.status == Test.UNKNOWN:
> ah I was assuming the failure is coming in here as an exception? ... it wou
Handling this duality is not a big
Patch Set 2:
> We don't need this test
I know, but it's better to remove it in separate commit to make sure that
migration does not introduce any regressions.
--
To view, visit https://gerrit.osmocom.org/2674
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comme
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2682
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcc24b493092a5a8e3561d7642a0b4608a8beae
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
53 matches
Mail list logo
