osmo-gsm-manuals[master]: OsmoGSMTester: add rtprio conf, tweak core dump conf

2017-05-24 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/2722/1/OsmoGSMTester/chapters/install.adoc File OsmoGSMTester/chapters/install.adoc: Line 328: sudo -s > I think specyfing sudo -s here is not needed. It's obvious you will need ro The reason to add it was that this does not work: sudo

[PATCH] osmo-gsm-tester[master]: default suites: enable osmo-bts-trx

2017-05-24 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2735 default suites: enable osmo-bts-trx Change-Id: I5dce732ed21f34988aa014add4d2d611dd0c44fc --- M example/default-suites.conf 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/35/2735/1

osmo-gsm-tester[master]: rename resource nitb_iface to ip_address

2017-05-24 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/2712/1//COMMIT_MSG Commit Message: Line 20: type: loopback > Do we really need the type? Cannot we just infer it is a loopback addr by a the question is if we want to reserve a loopback address, how do we indicate that. (But we really

osmo-gsm-tester[master]: nitb config: set: logging color 1, category 1

2017-05-24 Thread Neels Hofmeyr
Patch Set 2: ah, you meant the one in template_test/ ... it appears that this file is not used and orphaned? maybe that needs a separate fix. -- To view, visit https://gerrit.osmocom.org/2706 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-I

osmo-gsm-tester[master]: nitb config: set: logging color 1, category 1

2017-05-24 Thread Neels Hofmeyr
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/2706/2/src/osmo_gsm_tester/templates/osmo-nitb.cfg.tmpl File src/osmo_gsm_tester/templates/osmo-nitb.cfg.tmpl: Line 6: logging color 1 does it? -- To view, visit https://gerrit.osmocom.org/2706 To unsubscribe, visit https://gerrit.osmo

osmo-gsm-tester[master]: resource error logging that is easier to understand

2017-05-24 Thread Neels Hofmeyr
Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/2705/1/src/osmo_gsm_tester/resource.py File src/osmo_gsm_tester/resource.py: Line 500: def counts(self): > Do we need this? doesn't seem to be used, but OK with keeping it if it can I thought I was using it somewhere... https://ger

[MERGED] osmo-gsm-tester[master]: remove bts_ocpthy.py

2017-05-24 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: remove bts_ocpthy.py .. remove bts_ocpthy.py We're not currently paying attention to the octphy in osmo-gsm-tester. So instead of maintaining dead code,

[MERGED] osmo-gsm-tester[master]: resources.conf: remove unused example BTS

2017-05-24 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: resources.conf: remove unused example BTS .. resources.conf: remove unused example BTS Change-Id: I370789a4dc048cf71c1951f2eb70bfec261583a2 --- M exampl

[MERGED] osmo-gsm-tester[master]: osmo_nitb.py: remove unused imports

2017-05-24 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: osmo_nitb.py: remove unused imports .. osmo_nitb.py: remove unused imports Change-Id: I55c118c6b277a2c8cddc251e3d36571b12504266 --- M src/osmo_gsm_teste

osmo-gsm-tester[master]: contrib/jenkins: don't package /share/doc/libosmocore

2017-05-24 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2701 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd2674c3f65f820a72d77c40a9e9df3e094bb41d Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[MERGED] osmo-gsm-tester[master]: contrib/jenkins: don't package /share/doc/libosmocore

2017-05-24 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: contrib/jenkins: don't package /share/doc/libosmocore .. contrib/jenkins: don't package /share/doc/libosmocore Change-Id: Ibd2674c3f65f820a72d77c40a9e9d

osmo-gsm-tester[master]: contrib/jenkins: don't package /share/doc/libosmocore

2017-05-24 Thread Neels Hofmeyr
Patch Set 2: (but for now let's apply this patch to not have to copy N times the amount of data as artifacts around) -- To view, visit https://gerrit.osmocom.org/2701 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd2674c3f65f820a72d77

osmo-gsm-tester[master]: contrib/jenkins: don't package /share/doc/libosmocore

2017-05-24 Thread Neels Hofmeyr
Patch Set 2: > --disable-doc I wish, but it does not exist AFAICT. Let's add that and then drop this again. -- To view, visit https://gerrit.osmocom.org/2701 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd2674c3f65f820a72d77c40a9e9df

[PATCH] osmo-gsm-tester[master]: log: change 'log_all_origins' from bool to a list of levels ...

2017-05-24 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2731 to look at the new patch set (#2). log: change 'log_all_origins' from bool to a list of levels to apply to The idea is to see the full origin list for log level ERR, while the rest of t

[PATCH] osmo-gsm-tester[master]: bts: add remote_addr() function

2017-05-24 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2715 to look at the new patch set (#4). bts: add remote_addr() function To start an MGCPGW, we so far need the BTS address in advance (should get fixed at some point, but s

osmo-gsm-tester[master]: default-suites.conf: run aoip

2017-05-24 Thread Neels Hofmeyr
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/2721/2/example/default-suites.conf File example/default-suites.conf: Line 1: - aoip_sms:sysmo > I'd rather run both, this way we also know if something was broken in one o ah yes, that was just the branch status -- To view, visit https:

[PATCH] osmo-gsm-tester[master]: MSC+BSC: add test api to run OsmoMSC and OsmoBSC with AoIP

2017-05-24 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2719 to look at the new patch set (#4). MSC+BSC: add test api to run OsmoMSC and OsmoBSC with AoIP Change-Id: I5842e8f1cba8e8e6bedfc08540efcafe207159cb --- M doc/README.txt

[PATCH] osmo-gsm-tester[master]: MSC+BSC: add separate suites for AoIP: aoip_sms, aoip_debug

2017-05-24 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2720 to look at the new patch set (#4). MSC+BSC: add separate suites for AoIP: aoip_sms, aoip_debug It would be nicer to select the network programs as scenarios, i.e. inde

[PATCH] osmo-gsm-tester[master]: cosmetic: comment and SMS token tweak

2017-05-24 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2734 cosmetic: comment and SMS token tweak Change-Id: I66b8f30303e21ad781d16f3aa9fe30067d6a0e20 --- M src/osmo_gsm_tester/ofono_client.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes

[PATCH] osmo-gsm-tester[master]: fix: refresh dbus object when interfaces have changed

2017-05-24 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2733 to look at the new patch set (#3). fix: refresh dbus object when interfaces have changed This solves the KeyError problems when we attempt to use new Interfaces that have come up. The s

[PATCH] osmo-gsm-tester[master]: fix: refresh dbus object when interfaces have changed

2017-05-24 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2733 to look at the new patch set (#2). fix: refresh dbus object when interfaces have changed This solves the KeyError problems when we attempt to use new Interfaces that have come up. The s

[PATCH] osmo-gsm-tester[master]: MSC+BSC: add test api to run OsmoMSC and OsmoBSC with AoIP

2017-05-24 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2719 to look at the new patch set (#3). MSC+BSC: add test api to run OsmoMSC and OsmoBSC with AoIP Change-Id: I5842e8f1cba8e8e6bedfc08540efcafe207159cb --- M doc/README.txt

[PATCH] osmo-gsm-tester[master]: default-suites.conf: run aoip

2017-05-24 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2721 to look at the new patch set (#3). default-suites.conf: run aoip Change-Id: I0f7d6feec5062c2aaf07eb9a7f543a4a84cb1ff7 --- M example/default-suites.conf 1 file changed,

osmo-gsm-tester[master]: MSC+BSC: add test api to run OsmoMSC and OsmoBSC with AoIP

2017-05-24 Thread Neels Hofmeyr
Patch Set 2: (7 comments) thanks for the excellent review! https://gerrit.osmocom.org/#/c/2719/2/example/defaults.conf File example/defaults.conf: Line 14: short_name: osmo-gsm-tester-msc > Shall both msc and bsc have a short_name and long_name? I'm not sure at all :P -- I haven't configur

osmo-gsm-tester[master]: bts: add remote_addr() function

2017-05-24 Thread Neels Hofmeyr
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/2715/2/src/osmo_gsm_tester/bts_osmotrx.py File src/osmo_gsm_tester/bts_osmotrx.py: Line 47: return '127.0.0.1' > You can just do as in sysmobts, conf.get('addr') then set it to 127.0.0.1 the point is that this address should be r

osmo-gsm-tester[master]: ofono_client: Discover modem path from imsi

2017-05-24 Thread Neels Hofmeyr
Patch Set 1: Code-Review-1 I'm starting to get why this needs to be complicated... :/ The modem path becomes a dynamic property of the modem resource, yet it is the single ofono handle that *defines* which resource is reserved. And we must only query unreserved modems' properties. I hate to s

osmo-gsm-tester[master]: fix: refresh dbus object when interfaces have changed

2017-05-24 Thread Neels Hofmeyr
Patch Set 1: Code-Review-1 (2 comments) argh some WIP code crept itself in here https://gerrit.osmocom.org/#/c/2733/1/src/osmo_gsm_tester/bts_sysmo.py File src/osmo_gsm_tester/bts_sysmo.py: Line 63: #self.run_remote('rm-remote-dir', ('test', '!', '-d', SysmoBts.REMOTE_DIR, '||', '

[PATCH] osmo-gsm-tester[master]: event_loop: Create a global event loop to poll and wait for ...

2017-05-24 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2695 to look at the new patch set (#2). event_loop: Create a global event loop to poll and wait for events Tweaked-by: nhofmeyr Change-Id: Iaa78bae0f053496377609b24a11ebaef3fd77598 --- A src

[PATCH] osmo-gsm-tester[master]: fix: refresh dbus object when interfaces have changed

2017-05-24 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2733 fix: refresh dbus object when interfaces have changed This solves the KeyError problems when we attempt to use new Interfaces that have come up. The solution is to get a fresh pydbus object when interfaces have been added. Another key solution is to no

osmocom-bb[master]: host/mobile: use talloc for ms->name allocation

2017-05-24 Thread Vadim Yanitskiy
Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/2667/3/src/host/layer23/src/mobile/vty_interface.c File src/host/layer23/src/mobile/vty_interface.c: Line 1268: osmo_talloc_replace_string(ms, &ms->name, argv[1]); > please use osmo_talloc_replace_string() in situations like this. Don

libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-24 Thread Harald Welte
Patch Set 3: will you take care of respective jenkins changes as outlined in the commit message? thanks! -- To view, visit https://gerrit.osmocom.org/2727 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e07fb9e60830dbd585f22d9c658c4625

[MERGED] libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Introduce build script for arm-none-eabi cross-compilations .. Introduce build script for arm-none-eabi cross-compilations This is a necessary step to us

libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-24 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2727 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e07fb9e60830dbd585f22d9c658c46252ce399f Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[MERGED] osmocom-bb[master]: mobile/gsm322.c: fix mcc/mnc typo

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mobile/gsm322.c: fix mcc/mnc typo .. mobile/gsm322.c: fix mcc/mnc typo Change-Id: I4a3aaa0465598b17ccd30ec4cbeb90429216540e --- M src/host/layer23/src/mo

[MERGED] osmocom-bb[master]: sap_interface.c: drop meaningless condition

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sap_interface.c: drop meaningless condition .. sap_interface.c: drop meaningless condition If sap_state is equal to SAP_NOT_CONNECTED, it cannot be equal

[MERGED] osmocom-bb[master]: host/app_mobile.c: do not exit in mobile_new()

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: host/app_mobile.c: do not exit in mobile_new() .. host/app_mobile.c: do not exit in mobile_new() Previously, if there was any error during a new osmocom_

[MERGED] osmocom-bb[master]: mobile/gsm480_ss.c: gsm480_mmss_ind: return rc

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mobile/gsm480_ss.c: gsm480_mmss_ind: return rc .. mobile/gsm480_ss.c: gsm480_mmss_ind: return rc Change-Id: Iabaccdbdfc5a5eb6424bd1603f405241650f13d8 ---

[MERGED] osmocom-bb[master]: mobile/gsm48_mm.c: strip unused variable

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mobile/gsm48_mm.c: strip unused variable .. mobile/gsm48_mm.c: strip unused variable Change-Id: I2708628263bec4bc6bf53a357928e23609b40c64 --- M src/host/

[MERGED] osmocom-bb[master]: mobile/gsm322.c: check fwrite() return value

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mobile/gsm322.c: check fwrite() return value .. mobile/gsm322.c: check fwrite() return value Change-Id: I74ad6e540c98ab4914e7a2ea725dd23f5a2fd034 --- M s

[MERGED] osmocom-bb[master]: mobile/gsm480_ss.c: fix copy-paste error

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mobile/gsm480_ss.c: fix copy-paste error .. mobile/gsm480_ss.c: fix copy-paste error Change-Id: I23287c0f31bee9c1b710f17f932633d2c621dab0 --- M src/host/

[MERGED] osmocom-bb[master]: mobile/gsm48_rr.c: fix BA range exceed check

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mobile/gsm48_rr.c: fix BA range exceed check .. mobile/gsm48_rr.c: fix BA range exceed check Change-Id: Ic2ebe9faeeda7ce812527962d209e6049f2dfc75 --- M s

[PATCH] osmocom-bb[master]: host/mobile: use talloc for ms->name allocation

2017-05-24 Thread Vadim Yanitskiy
Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2667 to look at the new patch set (#4). host/mobile: use talloc for ms->name allocation The approach of talloc memory management reduces memory usage, and prevents some buffer overflows, which

[MERGED] osmocom-bb[master]: osmocon.c: strip unused variable

2017-05-24 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. Change subject: osmocon.c: strip unused variable .. osmocon.c: strip unused variable Change-Id: I295785295c108798e0c235e78bd8fd8f3c585d16 --- M src/host/osmocon/osmoc

[MERGED] libosmo-netif[master]: somo_stream_srv_fd_cb(): close socket if NODELAY fails

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: somo_stream_srv_fd_cb(): close socket if NODELAY fails .. somo_stream_srv_fd_cb(): close socket if NODELAY fails We didn't check for cases where setsocko

libosmo-netif[master]: somo_stream_srv_fd_cb(): close socket if NODELAY fails

2017-05-24 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2610 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0adbc4cec35be7c36bdf01d4d8fefd6097e9be5d Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master G

osmo-bts[master]: measurement: fix measurement computation of reported timing ...

2017-05-24 Thread Harald Welte
Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2412 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e0dfd13b53e8aa2822985f12bf2985e683ab553 Gerrit-PatchSet: 7 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

[PATCH] osmo-bts[master]: measurement: fix measurement computation of reported timing ...

2017-05-24 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2412 to look at the new patch set (#7). measurement: fix measurement computation of reported timing offset Timing advance is currently not taken into account when computing the measurement r

osmocom-bb[master]: host/mobile: use talloc for ms->name allocation

2017-05-24 Thread Harald Welte
Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/2667/3/src/host/layer23/src/mobile/vty_interface.c File src/host/layer23/src/mobile/vty_interface.c: Line 1268: talloc_free(ms->name); please use osmo_talloc_replace_string() in situations like this. -- To view, visit

osmo-pcu[master]: Cleanup FN scheduling

2017-05-24 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2654 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fee0714453d0c3c3f3f875f88daea2d9c477331 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit

[MERGED] osmo-pcu[master]: Fix typo in logging

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Fix typo in logging .. Fix typo in logging DL-TBD was errorneously printed as UL-TBF. Change-Id: I94a224c0339a062e4c8d5aa6c4c858f3f0298a0d --- M src/bts

osmo-pcu[master]: Fix typo in logging

2017-05-24 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2673 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94a224c0339a062e4c8d5aa6c4c858f3f0298a0d Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit

osmo-bts[master]: octphy: integrate channel measurement handling

2017-05-24 Thread Harald Welte
Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2417 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f053bb10b1cb112a8814ee591969d607888e686 Gerrit-PatchSet: 6 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

osmo-bts[master]: measurement: exclude idle channels from uplink measurement

2017-05-24 Thread Harald Welte
Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2416 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I471a767c7974bdacadc3233d0c3e7b7965f6eafa Gerrit-PatchSet: 6 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

[MERGED] osmo-bts[master]: measurement: exclude idle channels from uplink measurement

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: measurement: exclude idle channels from uplink measurement .. measurement: exclude idle channels from uplink measurement The DATA-IND, received from the

osmo-bts[master]: measurement: Improve log output

2017-05-24 Thread Harald Welte
Patch Set 6: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/2389/6/src/common/measurement.c File src/common/measurement.c: Line 140: DEBUGP(DMEAS, I think we can simply pass the lchan into "is_meas_complete" and replace the pchan, ts and subch arguments wih it. At that point,

libosmocore[master]: Add human-readable names for signal_ns

2017-05-24 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2693 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id664355eb8305fb287e4dae0800fb20dc2f9b8cd Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[MERGED] libosmocore[master]: Add human-readable names for signal_ns

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add human-readable names for signal_ns .. Add human-readable names for signal_ns Change-Id: Id664355eb8305fb287e4dae0800fb20dc2f9b8cd Related: SYS#3610 -

libosmocore[master]: Distinguish between unsupported and invalid MCS

2017-05-24 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2694 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id665d5c0cf50efa18b1bcbf4f17359418a380f9e Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[MERGED] libosmocore[master]: Distinguish between unsupported and invalid MCS

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Distinguish between unsupported and invalid MCS .. Distinguish between unsupported and invalid MCS Previously MCS0 was incorrectly set for some of type1

[MERGED] osmo-hlr[master]: install hlr.sql in prefix/doc/osmo-hlr/

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: install hlr.sql in prefix/doc/osmo-hlr/ .. install hlr.sql in prefix/doc/osmo-hlr/ In particular I need this to start a fresh osmo-hlr instance on the os

osmo-hlr[master]: install hlr.sql in prefix/doc/osmo-hlr/

2017-05-24 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2700 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e48375814ab93691892299d34909c6d0bf12a2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit

osmo-bts[master]: Implement basic Get Attribute responder

2017-05-24 Thread Harald Welte
Patch Set 6: (3 comments) https://gerrit.osmocom.org/#/c/2545/6/src/common/oml.c File src/common/oml.c: Line 174: uint16_t i, r = 1; /* byte 0 is reserved for unsupported attributes counter */ i think the variables are named un-intuitive. Using 'i' as a loop counter in a for loop, ok.

[MERGED] osmo-pcu[master]: Print human-readable BSSGP PDU type

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Print human-readable BSSGP PDU type .. Print human-readable BSSGP PDU type Change-Id: Ief4b5ce4e4020edaf771eaa24f4382ec368dd18c --- M src/gprs_bssgp_pcu.

osmo-gsm-manuals[master]: apply rename of resource nitb_iface to ip_address

2017-05-24 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2678 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbbb7d921e7340739883650f778d5a7341840875 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: maste

osmo-pcu[master]: Print human-readable BSSGP PDU type

2017-05-24 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2725 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief4b5ce4e4020edaf771eaa24f4382ec368dd18c Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit

[MERGED] libosmocore[master]: core/conv: add x86 SSE support for Viterbi decoder

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: core/conv: add x86 SSE support for Viterbi decoder .. core/conv: add x86 SSE support for Viterbi decoder Fast convolutional decoding is provided through

libosmocore[master]: core/conv: add x86 SSE support for Viterbi decoder

2017-05-24 Thread Harald Welte
Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2454 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1da6d71ed0564f1d684f3a836e998d09de5f0351 Gerrit-PatchSet: 9 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[PATCH] libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-24 Thread blobb
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2727 to look at the new patch set (#2). Introduce build script for arm-none-eabi cross-compilations This is a necessary step to use libosmocore-arm dep in OsmocomBB. After this patch is sub

[MERGED] osmo-bts[master]: phy_link: Fix typo in state being printed

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: phy_link: Fix typo in state being printed .. phy_link: Fix typo in state being printed Change-Id: I312eefa6738f8abdeedd2efb574f3e45cd2e8aa3 --- M src/com

osmo-bts[master]: phy_link: Fix typo in state being printed

2017-05-24 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2732 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I312eefa6738f8abdeedd2efb574f3e45cd2e8aa3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

osmocom-bb[master]: Introduce contrib/jenkins.sh to enable gerrit verification[1]

2017-05-24 Thread Harald Welte
Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2726 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife88be9022fc1fc1baee7f11872e5b8db4215682 Gerrit-PatchSet: 7 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerr

[MERGED] osmocom-bb[master]: Introduce contrib/jenkins.sh to enable gerrit verification[1]

2017-05-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Introduce contrib/jenkins.sh to enable gerrit verification[1] .. Introduce contrib/jenkins.sh to enable gerrit verification[1] First, jenkins.sh builds l

[PATCH] osmocom-bb[master]: Introduce contrib/jenkins.sh to enable gerrit verification[1]

2017-05-24 Thread blobb
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2726 to look at the new patch set (#7). Introduce contrib/jenkins.sh to enable gerrit verification[1] First, jenkins.sh builds libosmocore dependency. Then it compiles the "host" (PC) part o

osmocom-bb[master]: Introduce contrib/jenkins.sh to enable gerrit verification[1]

2017-05-24 Thread blobb
Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/2726/6/contrib/jenkins.sh File contrib/jenkins.sh: Line 2: > Why bash and not sh? Do you use bash-specific features? no, libosmo-netif/contrib/jenkins.sh [1] has been taken as a "template" and modified to suite osmocom-bb. hmm, libosmo

osmo-gsm-tester[master]: ofono_client: Discover modem path from imsi

2017-05-24 Thread Neels Hofmeyr
Patch Set 1: (1 comment) so far just a hint on the KeyError problem. In general I'm not following why this patch is so complex; need to take a look later and discuss with you... https://gerrit.osmocom.org/#/c/2696/1/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py:

[PATCH] osmo-bts[master]: phy_link: Fix typo in state being printed

2017-05-24 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/2732 phy_link: Fix typo in state being printed Change-Id: I312eefa6738f8abdeedd2efb574f3e45cd2e8aa3 --- M src/common/phy_link.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/2732/1 diff --

[PATCH] osmo-gsm-tester[master]: log: change 'log_all_origins' from bool to a list of levels ...

2017-05-24 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2731 log: change 'log_all_origins' from bool to a list of levels to apply to Change-Id: I0277782652548fa321f767da79b207d70678fad1 --- M src/osmo-gsm-tester.py M src/osmo_gsm_tester/log.py M src/osmo_gsm_tester/trial.py 3 files changed, 9 insertions(+), 8 del

[PATCH] osmo-gsm-tester[master]: contrib/jenkins: cosmetic: add some spacing in log output

2017-05-24 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2729 to look at the new patch set (#2). contrib/jenkins: cosmetic: add some spacing in log output Change-Id: Ie7238d8610f2be3e074f366861782e010d814e94 --- M contrib/jenkins-build-osmo-bts-sy

[PATCH] osmo-gsm-tester[master]: fix osmo-bts-trx: add config: 'osmotrx tx-attenuation oml'

2017-05-24 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2730 fix osmo-bts-trx: add config: 'osmotrx tx-attenuation oml' Before this, the network opened up by osmo-bts-trx would be invisible through the attenuation of the osmo-gsm-tester hardware, because tx-attenuation would apparently default to 50, meaning maxi

[MERGED] osmo-gsm-tester[master]: fix: contrib/jenkins sysmobts build: proper PKG_CONFIG_PATH

2017-05-24 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fix: contrib/jenkins sysmobts build: proper PKG_CONFIG_PATH .. fix: contrib/jenkins sysmobts build: proper PKG_CONFIG_PATH Change-Id: I94b706d664ba89b2e

[PATCH] osmo-gsm-tester[master]: fix: contrib/jenkins sysmobts build: proper PKG_CONFIG_PATH

2017-05-24 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2728 to look at the new patch set (#2). fix: contrib/jenkins sysmobts build: proper PKG_CONFIG_PATH Change-Id: I94b706d664ba89b2ea999601ba67348973c3639c --- M contrib/jenkins-build-osmo-bts-

osmo-gsm-tester[master]: fix: contrib/jenkins sysmobts build: proper PKG_CONFIG_PATH

2017-05-24 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2728 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94b706d664ba89b2ea999601ba67348973c3639c Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[PATCH] osmo-gsm-tester[master]: contrib/jenkins: cosmetic: add some spacing in log output

2017-05-24 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2729 contrib/jenkins: cosmetic: add some spacing in log output Change-Id: Ie7238d8610f2be3e074f366861782e010d814e94 --- M contrib/jenkins-build-osmo-bts-sysmo.sh M contrib/jenkins-build-osmo-bts-trx.sh M contrib/jenkins-build-osmo-nitb.sh 3 files changed, 30

[PATCH] osmo-gsm-tester[master]: fix sysmobts build: proper PKG_CONFIG_PATH

2017-05-24 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2728 fix sysmobts build: proper PKG_CONFIG_PATH Change-Id: I94b706d664ba89b2ea999601ba67348973c3639c --- M contrib/jenkins-build-osmo-bts-sysmo.sh 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester ref

osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-05-24 Thread Max
Patch Set 8: (1 comment) https://gerrit.osmocom.org/#/c/2465/8/scripts/osmo-build.sh File scripts/osmo-build.sh: Line 1: #!/bin/bash Why bash and not sh? Do you use bash-specific features? -- To view, visit https://gerrit.osmocom.org/2465 To unsubscribe, visit https://gerrit.osmocom.org/sett

osmocom-bb[master]: Introduce contrib/jenkins.sh to enable gerrit verification[1]

2017-05-24 Thread Max
Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/2726/6/contrib/jenkins.sh File contrib/jenkins.sh: Line 2: Why bash and not sh? Do you use bash-specific features? -- To view, visit https://gerrit.osmocom.org/2726 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-Mess

libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-24 Thread Max
Patch Set 1: Why the need for separate file and change in jenkins job? Is there reason why this check ("$JOB_NAME" == *"..) can't be performed inside jenkins.sh which would than choose proper compilation options? I thought the general direction was to move as much of the job description as po

[PATCH] osmocom-bb[master]: Introduce contrib/jenkins.sh to enable gerrit verification[1]

2017-05-24 Thread blobb
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2726 to look at the new patch set (#6). Introduce contrib/jenkins.sh to enable gerrit verification[1] First, jenkins.sh builds libosmocore dependency. Then it compiles the "host" (PC) part o

[PATCH] osmocom-bb[master]: Introduce contrib/jenkins.sh to enable gerrit verification[1]

2017-05-24 Thread blobb
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2726 to look at the new patch set (#5). Introduce contrib/jenkins.sh to enable gerrit verification[1] First, jenkins.sh builds libosmocore dependency. Then it compiles the "host" (PC) part o

[PATCH] libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-24 Thread blobb
Review at https://gerrit.osmocom.org/2727 Introduce build script for arm-none-eabi cross-compilations This is a necessary step to use libosmocore-arm dep in OsmocomBB. After this patch is submitted the "./contrib/jenkins.sh" line in libosmocore jenkins jobs [1][2] needs to be replaced with:

[PATCH] osmocom-bb[master]: Introduce contrib/jenkins.sh to enable gerrit verification[1]

2017-05-24 Thread blobb
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2726 to look at the new patch set (#4). Introduce contrib/jenkins.sh to enable gerrit verification[1] First, jenkins.sh builds libosmocore dependency. Then it compiles the "host" (PC) part o

[PATCH] osmocom-bb[master]: Introduce contrib/jenkins.sh to enable gerrit verification[1]

2017-05-24 Thread blobb
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2726 to look at the new patch set (#3). Introduce contrib/jenkins.sh to enable gerrit verification[1] First, jenkins.sh builds libosmocore dependency. Then it compiles the "host" (PC) part o

[PATCH] osmocom-bb[master]: Introduce contrib/jenkins.sh to enable gerrit verification[1]

2017-05-24 Thread blobb
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2726 to look at the new patch set (#2). Introduce contrib/jenkins.sh to enable gerrit verification[1] First, jenkins.sh builds libosmocore dependency. Then it compiles the "host" (PC) part o

[PATCH] osmocom-bb[master]: Introduce contrib/jenkins.sh to enable gerrit verification

2017-05-24 Thread blobb
Review at https://gerrit.osmocom.org/2726 Introduce contrib/jenkins.sh to enable gerrit verification First, jenkins.sh builds libosmocore dependency. Then it compiles the "host" (PC) part of OsmocomBB. After "libosmocore embedded"-build has been introduced this script will use it instead of th

[MERGED] osmo-gsm-tester[master]: trial.py: Remove accidental double creation of file

2017-05-24 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: trial.py: Remove accidental double creation of file .. trial.py: Remove accidental double creation of file This file is already created in run_suites().

osmo-gsm-tester[master]: trial.py: Remove accidental double creation of file

2017-05-24 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2724 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibec14a1ef5fd029aa37ce666d00236bb872d636e Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[MERGED] osmo-gsm-tester[master]: Exit with failure if not enough resources are found

2017-05-24 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Exit with failure if not enough resources are found .. Exit with failure if not enough resources are found Change-Id: I9e38435ff71416585a259c823053bd07c

osmo-gsm-tester[master]: Exit with failure if not enough resources are found

2017-05-24 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2723 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e38435ff71416585a259c823053bd07c670d495 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-05-24 Thread blobb
Patch Set 8: Thanks again for your review! I tried to address all your concerns. -- To view, visit https://gerrit.osmocom.org/2465 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifee0a2f837d23b19aa5326f810234d5452e47484 Gerrit-PatchSet:

[PATCH] osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-05-24 Thread blobb
Hello Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2465 to look at the new patch set (#8). Introduce artifacts holding dependencies to speed up builds. Basically, osmo-build.sh holds logic to check whether the necessary artifact

  1   2   >