Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.04/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/i586 Package network:osmocom:nightly/libosmocore failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of b

Build failure of network:osmocom:nightly/libosmocore in Debian_8.0/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/x86_64 Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of buil

Build failure of network:osmocom:nightly/libosmocore in Debian_8.0/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/i586 Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build lo

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.10/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.10/i586 Package network:osmocom:nightly/libosmocore failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of b

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_17.04/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.04/i586 Package network:osmocom:nightly/libosmocore failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of b

osmo-bts[master]: osmo-bts-trx: Remove duplicate parsing of NM_ATT_CONN_FAIL_CRIT

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2754 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb0179e1443c0b5a97e59919dba684a001e90192 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

osmo-bts[master]: Consistently check for minimum attribute/TLV length in RSL a...

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2752 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c4eee65711c49bc8ba4675221b1d5fd16198e9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

osmo-bts[master]: l1sap.c: Add spec reference to link timeout implementation

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2753 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia95635a4350624b30f2b352e30ee39f856945670 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

[MERGED] openbsc[master]: Use new e1inp_signal_names from libosmo-abis to print input ...

Harald Welte has submitted this change and it was merged. Change subject: Use new e1inp_signal_names from libosmo-abis to print input signal names .. Use new e1inp_signal_names from libosmo-abis to print input signal names Cha

openbsc[master]: costmetic: Document gsm48_multirate_config() + const-ify input

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2756 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2532cde69a18e3b021f7371e68f67a28a43d8b5f Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-

[MERGED] openbsc[master]: bsc_api.c: Documentation for handle_mr_config()

Harald Welte has submitted this change and it was merged. Change subject: bsc_api.c: Documentation for handle_mr_config() .. bsc_api.c: Documentation for handle_mr_config() Change-Id: I6edd442afc7c20f8f097198941bc592d429ba5da -

[MERGED] openbsc[master]: costmetic: Document gsm48_multirate_config() + const-ify input

Harald Welte has submitted this change and it was merged. Change subject: costmetic: Document gsm48_multirate_config() + const-ify input .. costmetic: Document gsm48_multirate_config() + const-ify input We generally use const p

openbsc[master]: bsc_api.c: Documentation for handle_mr_config()

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2757 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6edd442afc7c20f8f097198941bc592d429ba5da Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-

[MERGED] openbsc[master]: bsc_vty: Factor vty_get_ts() out of pdch_act_cmd()

Harald Welte has submitted this change and it was merged. Change subject: bsc_vty: Factor vty_get_ts() out of pdch_act_cmd() .. bsc_vty: Factor vty_get_ts() out of pdch_act_cmd() Resolving a timeslot based on its numeric identi

openbsc[master]: bsc_vty: Factor vty_get_ts() out of pdch_act_cmd()

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2758 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2570232f82542487a1133be7efb1dc1eb3029a8 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-

openbsc[master]: Use new e1inp_signal_names from libosmo-abis to print input ...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2755 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I156027ecdd1456228c9f8776577edd48e70c19da Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-

[PATCH] openbsc[master]: bsc_vty.c: Add command for manual [de]actiovation of logical...

Review at https://gerrit.osmocom.org/2759 bsc_vty.c: Add command for manual [de]actiovation of logical channels Sometimes it is useful to manually activate (or decativate) a given logical channel from the VTY. Doing this on the BSC (rather than the BTS) ensures that the BSC knows that this tim

[PATCH] openbsc[master]: bsc_api.c: Documentation for handle_mr_config()

Review at https://gerrit.osmocom.org/2757 bsc_api.c: Documentation for handle_mr_config() Change-Id: I6edd442afc7c20f8f097198941bc592d429ba5da --- M openbsc/src/libbsc/bsc_api.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/57/

[PATCH] openbsc[master]: bsc_vty: Factor vty_get_ts() out of pdch_act_cmd()

Review at https://gerrit.osmocom.org/2758 bsc_vty: Factor vty_get_ts() out of pdch_act_cmd() Resolving a timeslot based on its numeric identities is a generally useful function, so lets' factor that out. Change-Id: Id2570232f82542487a1133be7efb1dc1eb3029a8 --- M openbsc/src/libbsc/bsc_vty.c 1

[PATCH] openbsc[master]: costmetic: Document gsm48_multirate_config() + const-ify input

Review at https://gerrit.osmocom.org/2756 costmetic: Document gsm48_multirate_config() + const-ify input We generally use const pointers for input arguments. Also, document input/output arguments of function and add spec reference. Change-Id: I2532cde69a18e3b021f7371e68f67a28a43d8b5f --- M op

[PATCH] openbsc[master]: Use new e1inp_signal_names from libosmo-abis to print input ...

Review at https://gerrit.osmocom.org/2755 Use new e1inp_signal_names from libosmo-abis to print input signal names Change-Id: I156027ecdd1456228c9f8776577edd48e70c19da --- M openbsc/src/libbsc/bsc_init.c M openbsc/src/libbsc/bts_ericsson_rbs2000.c 2 files changed, 4 insertions(+), 7 deletions(-

[PATCH] osmo-bts[master]: osmo-bts-trx: Remove duplicate parsing of NM_ATT_CONN_FAIL_CRIT

Review at https://gerrit.osmocom.org/2754 osmo-bts-trx: Remove duplicate parsing of NM_ATT_CONN_FAIL_CRIT For some reason, osmo-bts-trx did another take at parsing NM_ATT_CONN_FAIL_CRIT and storing the second octet in btsb->radio_link_timeout, just like the generic code already does in oml_rx_s

[PATCH] osmo-bts[master]: Consistently check for minimum attribute/TLV length in RSL a...

Review at https://gerrit.osmocom.org/2752 Consistently check for minimum attribute/TLV length in RSL and OML Make more use of TLVP_PRES_LEN() instead of plain TLVP_PRESENT() and implicitly assuming a certain length of the information element. What this obviously doesn't introduce is some kind

[PATCH] osmo-bts[master]: l1sap.c: Add spec reference to link timeout implementation

Review at https://gerrit.osmocom.org/2753 l1sap.c: Add spec reference to link timeout implementation Change-Id: Ia95635a4350624b30f2b352e30ee39f856945670 --- M src/common/l1sap.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/53/

[MERGED] osmo-bts[master]: rx_tchh_fn(): Avoid copy+pasting formula to determine odd-ne...

Harald Welte has submitted this change and it was merged. Change subject: rx_tchh_fn(): Avoid copy+pasting formula to determine odd-ness of fn .. rx_tchh_fn(): Avoid copy+pasting formula to determine odd-ness of fn Change-Id:

[MERGED] osmo-bts[master]: scheduler_trx: Avoid copy+pasting determining CMR from FN

Harald Welte has submitted this change and it was merged. Change subject: scheduler_trx: Avoid copy+pasting determining CMR from FN .. scheduler_trx: Avoid copy+pasting determining CMR from FN instead, let's introduce a specifi

[MERGED] osmo-bts[master]: scheduler_trx.c: Fix typos, improve comments, cosmetics

Harald Welte has submitted this change and it was merged. Change subject: scheduler_trx.c: Fix typos, improve comments, cosmetics .. scheduler_trx.c: Fix typos, improve comments, cosmetics Change-Id: I5e2ce70aea8d62657ce3a7d6c1

[MERGED] osmo-bts[master]: scheduler_trx.c: Avoid code duplication for BER10k computation

Harald Welte has submitted this change and it was merged. Change subject: scheduler_trx.c: Avoid code duplication for BER10k computation .. scheduler_trx.c: Avoid code duplication for BER10k computation Use an (inline) function

[MERGED] osmo-bts[master]: Remove unusued left-over gsm0503_conv.c

Harald Welte has submitted this change and it was merged. Change subject: Remove unusued left-over gsm0503_conv.c .. Remove unusued left-over gsm0503_conv.c gsm0503_conv.c should have been removed as part of efbef50efc170caccf6

osmo-bts[master]: rx_tchh_fn(): Avoid copy+pasting formula to determine odd-ne...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2751 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2a0bdaa70cc28c1ce8237351b0a0c6b998cf0a3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

osmo-bts[master]: scheduler_trx: Avoid copy+pasting determining CMR from FN

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2750 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbb9b685cf0b6a45339b0874438a500dd6254bc2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

osmo-bts[master]: Remove unusued left-over gsm0503_conv.c

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2739 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdcca1bc55a83c76ec47918dc4dd301155210091 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

[PATCH] osmo-bts[master]: Remove unusued left-over gsm0503_conv.c

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2739 to look at the new patch set (#2). Remove unusued left-over gsm0503_conv.c gsm0503_conv.c should have been removed as part of efbef50efc170caccf6354360638cda762dd7fc3 but somehow was le

[PATCH] osmo-bts[master]: scheduler_trx: Avoid copy+pasting determining CMR from FN

Review at https://gerrit.osmocom.org/2750 scheduler_trx: Avoid copy+pasting determining CMR from FN instead, let's introduce a specific function for that. Also, as this can be easily determined from the frame number, skip one argument to tx_tch_common(). Change-Id: Ibbb9b685cf0b6a45339b087443

[PATCH] osmo-bts[master]: rx_tchh_fn(): Avoid copy+pasting formula to determine odd-ne...

Review at https://gerrit.osmocom.org/2751 rx_tchh_fn(): Avoid copy+pasting formula to determine odd-ness of fn Change-Id: Ic2a0bdaa70cc28c1ce8237351b0a0c6b998cf0a3 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/

osmo-bts[master]: measurement: fix measurement computation

Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2412 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e0dfd13b53e8aa2822985f12bf2985e683ab553 Gerrit-PatchSet: 10 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerr

[PATCH] osmo-bts[master]: measurement: fix measurement computation

Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2412 to look at the new patch set (#10). measurement: fix measurement computation Timing advance is currently not taken into account when computing the measurement results, this commit

osmo-gsm-manuals[master]: osmo-nitb: Update VTY command reference

Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2014 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c2d71eeca853ef277e802e9e8e200eb3414bca Gerrit-PatchSet: 3 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: maste

osmo-bts[master]: measurement: Improve log output

Patch Set 8: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/2389/8/src/common/rsl.c File src/common/rsl.c: Line 2249: "%s chan_num:%d Tx MEAS RES valid(%d), flags(%d)\n", the flags are unsigned (not signed), so %u applies. Also, a bit-mask of flags is typically best printe

[MERGED] osmo-bts[master]: Implement basic Get Attribute responder

Harald Welte has submitted this change and it was merged. Change subject: Implement basic Get Attribute responder .. Implement basic Get Attribute responder Add 3GPP TS 52.021 §8.11.2 Get Attribute Response handling: * report O

osmo-bts[master]: Implement basic Get Attribute responder

Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2545 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09f95ed995fab5def9dc6e8cc201012fba4db28d Gerrit-PatchSet: 7 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit