Review at https://gerrit.osmocom.org/2882
gsm0503_{coding,mapping}: Mark input arguments as 'const'
It is generally our coding style to mark pointers to constant input data
as 'const *'. For some reason the gsm0503 coding and mapping was not
adhering to this, so let's bring it into compliance.
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2854
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a334ef3463896c543c0fe592d3903c15e67d4c4
Gerrit-PatchSet: 8
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/2882/1/include/osmocom/coding/gsm0503_mapping.h
File include/osmocom/coding/gsm0503_mapping.h:
Line 7: void gsm0503_xcch_burst_map(ubit_t *iB, ubit_t *eB, const ubit_t *hl,
What about this one?
--
To view, visit https://ge
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2881
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I96c1ba70e332199a4ca95e827a7562f953975af4
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2877
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bfcabd80b57aeb7f110b306350802e6e82c847a
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2878
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c2aaf1ab462c923d62232f1a63fae1e4eb18b4d
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2875
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib77cb703bb1710da396db3a939700515b5c20235
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Review at https://gerrit.osmocom.org/2883
test: Remove unused variable Failure
Commit 6ccda11a98afd6f4459e9ff1c24de4ad4450de23 removed its use but forgot to
remove it on this line.
Change-Id: I90375ce1e4b8e0b7e140df908323bc269e0baf40
---
M src/osmo_gsm_tester/test.py
1 file changed, 1 insertio
Review at https://gerrit.osmocom.org/2884
Add support for SMPP testing
As defined in [1], the different related actors are implemented in this
commit: ESME and SMSC.
SMSC: In Osmocom, the SMSC is currently implemented inside the NITB or
the MSC. A new Smsc abstract class is created to shared c
Patch Set 1: Code-Review+2
Trivial, I merge
--
To view, visit https://gerrit.osmocom.org/2883
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90375ce1e4b8e0b7e140df908323bc269e0baf40
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Ger
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: test: Remove unused variable Failure
..
test: Remove unused variable Failure
Commit 6ccda11a98afd6f4459e9ff1c24de4ad4450de23 removed its use but forg
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2884
to look at the new patch set (#2).
Add support for SMPP testing
As defined in [1], the different related actors are implemented in this
commit: ESME and SMSC.
SMSC: In Osmocom, the SMS
Hello Vadim Yanitskiy, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2882
to look at the new patch set (#2).
gsm0503_{coding,mapping}: Mark input arguments as 'const'
It is generally our coding style to mark pointers to constant input data
as
Hello Vadim Yanitskiy, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2882
to look at the new patch set (#3).
gsm0503_{coding,mapping}: Mark input arguments as 'const'
It is generally our coding style to mark pointers to constant input data
as
Patch Set 2:
Jenkins build is failing because python-smpplib is not installed on the jenkins
node. make check works on my workstation.
--
To view, visit https://gerrit.osmocom.org/2884
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14c
Neels Hofmeyr has submitted this change and it was merged.
Change subject: junit result: also write for aborted runs
..
junit result: also write for aborted runs
Even if aborted due to signal, write a JUnit report XML, and make
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/2884/2/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 351: msisdn = self.resources_pool.next_msisdn(self)
This change was needed, otherwise I get an error with something like "suite has
not origin element"
Review at https://gerrit.osmocom.org/2885
OML: fix potential OOB memory access
Use sizeof target BTS feature storage to make sure we always fit into
pre-allocated memory. Also use it for log check.
Change-Id: Ib107daa6e8b9bc397a10756071849f8ff82455d5
Fixes: CID 170581
---
M openbsc/src/libbsc/
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2882
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8731d7ae6171dff94741b6ddbb95ab5f03bfd4e
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Review at https://gerrit.osmocom.org/2887
log.Origin: ensure to avoid parent loops
Change-Id: I10a2f956beeda38ba1378eace9453eb911aae1a7
---
M src/osmo_gsm_tester/log.py
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/87/2
Review at https://gerrit.osmocom.org/2886
fix and refactor logging: drop 'with', simplify
With the recent fix of the junit report related issues, another issue arose:
the 'with log.Origin' was changed to disallow __enter__ing an object twice to
fix problems, now still code would fail because it
Patch Set 4:
Unfortunately I can't seem to install it, no. I have updated the patch to
include the requirements for python2(.7) in the debian package.
--
To view, visit https://gerrit.osmocom.org/2825
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit
Patch Set 4:
> I can't seem to install it
That itself seems like much bigger issue which we have to resolve sooner or
later anyway. Is there ticket for that?
--
To view, visit https://gerrit.osmocom.org/2825
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: commen
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2779
to look at the new patch set (#10).
ofono_client: Implement network registration during connect()
A new mcc_mnc parameter is now optionally passed to connect() in order
t
Review at https://gerrit.osmocom.org/2889
gsm0503_interleaving: Mark input arguments as 'const *'
The interleaving/deinterleaving functions were missing 'const'
qualifiers on their input data buffers
Change-Id: I2118c34a6353167787b23f877f1d81d60151aaf9
---
M include/osmocom/coding/gsm0503_inte
Review at https://gerrit.osmocom.org/2890
gsm0503_coding: Mark gsm0503_mcs_{ul,dl}_codes as const
The table describing the various MCS convolutional codes are constant
data and should be marked as such.
Change-Id: I4918521ee4572a67cbee5f9b49257fc5bfcde511
---
M src/coding/gsm0503_coding.c
1 fi
Review at https://gerrit.osmocom.org/2888
Add doxygen documentation to libosmocoding
This adds the minimum amount of API documentation that we should have on
all our code, particularly new code merged into a library.
Change-Id: I526804f64313867913574e50e5b9e9205ad3aa74
---
M Doxyfile.coding.in
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2886
to look at the new patch set (#2).
fix and refactor logging: drop 'with', simplify
With the recent fix of the junit report related issues, another issue arose:
the 'with log.Origin' was
Neels Hofmeyr has abandoned this change.
Change subject: log.Origin: ensure to avoid parent loops
..
Abandoned
combined with patch #2886 to satisfy unit tests
--
To view, visit https://gerrit.osmocom.org/2887
To unsubscribe,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2890
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4918521ee4572a67cbee5f9b49257fc5bfcde511
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2882
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8731d7ae6171dff94741b6ddbb95ab5f03bfd4e
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2888
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I526804f64313867913574e50e5b9e9205ad3aa74
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Harald Welte has submitted this change and it was merged.
Change subject: gsm0503_{coding,mapping}: Mark input arguments as 'const'
..
gsm0503_{coding,mapping}: Mark input arguments as 'const'
It is generally our coding style t
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2889
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2118c34a6353167787b23f877f1d81d60151aaf9
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Harald Welte has submitted this change and it was merged.
Change subject: gsm0503_interleaving: Mark input arguments as 'const *'
..
gsm0503_interleaving: Mark input arguments as 'const *'
The interleaving/deinterleaving functi
Harald Welte has submitted this change and it was merged.
Change subject: gsm0503_coding: Mark gsm0503_mcs_{ul,dl}_codes as const
..
gsm0503_coding: Mark gsm0503_mcs_{ul,dl}_codes as const
The table describing the various MCS c
Harald Welte has submitted this change and it was merged.
Change subject: Add doxygen documentation to libosmocoding
..
Add doxygen documentation to libosmocoding
This adds the minimum amount of API documentation that we should
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2871
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8660f75a2b2a13488b913c07637bdd0f5f0f4cf9
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit
Patch Set 10: Code-Review+2
(4 comments)
some replies and comments that are probably outdated. Patch Set 10 looks good!
https://gerrit.osmocom.org/#/c/2779/8//COMMIT_MSG
Commit Message:
Line 42: register by waiting/polling the method "modem.is_connected()". Tests
> ACK. Can I also write there
Review at https://gerrit.osmocom.org/2891
lc15: add jenkins helper
Change-Id: Ib47f5a6cc88e784c5662b0dab4ddc03ce9a35132
Related: SYS#3682
---
M contrib/jenkins_bts_model.sh
A contrib/jenkins_lc15.sh
2 files changed, 57 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/os
Patch Set 8:
(1 comment)
https://gerrit.osmocom.org/#/c/2779/8/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 422: def register(self, scanned_operators):
> Have you tested the DBus API? If calling netreg.Register directly without a
I tested it, there's a
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: ofono_client: Implement network registration during connect()
..
ofono_client: Implement network registration during connect()
A new mcc_mnc paramete
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: ofono_client: Print debug information about network
registration changes
..
ofono_client: Print debug information about network registration changes
Patch Set 2: Code-Review-1
(9 comments)
A few stuff to be fixed. Good job, happy to get rid of the "with" statements :D
https://gerrit.osmocom.org/#/c/2886/2/selftest/log_test.py
File selftest/log_test.py:
Line 89: # some space to keep source line numbers identical to previous code
This can be
Review at https://gerrit.osmocom.org/2893
Add script for fetching BTS-specific L1 headers
Several of the supported BTS models require hw-specific L1 headers for
compilation which are stored in separate repository. Instead of
copy-pasting code which obtains those header for each BTS it's better
Review at https://gerrit.osmocom.org/2892
Add .gitreview
Simplify gerrit usage via .gitreview file.
Change-Id: Ib5e18e675230540c79673eaaf4dc2b75f1353f6d
---
A .gitreview
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/92/2892/1
Patch Set 3: Verified-1
Doesn't work (tested with lc15 hw in TCH/H config):
measurement.c:150 (bts=0,trx=0,ts=2,ss=0) no space for uplink measurement
--
To view, visit https://gerrit.osmocom.org/2861
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-C
Add script for fetching BTS-specific L1 headers
Several of the supported BTS models require hw-specific L1 headers for
compilation which are stored in separate repository. Instead of
copy-pasting code which obtains those header for each BTS it's better to
create separate script.
Change-Id: I8405
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2892
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5e18e675230540c79673eaaf4dc2b75f1353f6d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-
Review at https://gerrit.osmocom.org/2894
Move common steps into common jenkins helper
Move value_string termination check and OpenBSC/OsmoPCU headers checkout
into shared jenkins helper from BTS' model-specific helpers to get rid
of copy-pasted code.
Change-Id: Ic48b1f75179b9008d65219dd5a47c1
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2894
to look at the new patch set (#2).
Move common steps into common jenkins helper
Move value_string termination check and OpenBSC/OsmoPCU headers checkout
into shared jenkins helper from
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2891
to look at the new patch set (#2).
lc15: add jenkins helper
Change-Id: Ib47f5a6cc88e784c5662b0dab4ddc03ce9a35132
Related: SYS#3682
---
M contrib/jenkins_bts_model.sh
A contrib/jenkins_l
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2891
to look at the new patch set (#3).
lc15: add jenkins helper
Change-Id: Ib47f5a6cc88e784c5662b0dab4ddc03ce9a35132
Related: SYS#3682
---
M contrib/jenkins_bts_model.sh
A contrib/jenkins_l
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2894
to look at the new patch set (#3).
Move common steps into common jenkins helper
Move value_string termination check and OpenBSC/OsmoPCU headers checkout
into shared jenkins helper from
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2891
to look at the new patch set (#4).
lc15: add jenkins helper
Change-Id: Ib47f5a6cc88e784c5662b0dab4ddc03ce9a35132
Related: SYS#3682
---
M contrib/jenkins_bts_model.sh
A contrib/jenkins_l
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2894
to look at the new patch set (#4).
Move common steps into common jenkins helper
Move value_string termination check and OpenBSC/OsmoPCU headers checkout
into shared jenkins helper from
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2894
to look at the new patch set (#5).
Move common steps into common jenkins helper
Move value_string termination check and OpenBSC/OsmoPCU headers checkout
into shared jenkins helper from
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2891
to look at the new patch set (#5).
lc15: add jenkins helper
Change-Id: Ib47f5a6cc88e784c5662b0dab4ddc03ce9a35132
Related: SYS#3682
---
M contrib/jenkins_bts_model.sh
A contrib/jenkins_l
Patch Set 5: Code-Review+2
Script looks sane to me. Let's merge it so we can easily test on jenkins, and
fix any problems later.
--
To view, visit https://gerrit.osmocom.org/2891
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47f5a6cc
Patch Set 5: Code-Review-1
(2 comments)
I would prefer keeping the scripts entirely separate, and leaving
jenkins_bts_model.sh as a mere "switch" between N completely standalone
scripts. After this patch, you can't use e.g. jenkins_sysmobts.sh on its own
anymore. Nothing against removing code
Patch Set 5:
(the jenkins_bts_model.sh was added merely to accomodate the jenkins build
matrix, i.e. redirect a call with a given $bts_model env var to the various
scripts)
--
To view, visit https://gerrit.osmocom.org/2894
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Mess
Review at https://gerrit.osmocom.org/2895
ctrl_test.c: fix build with GCC 7.1.1
According to GCC's online docs:
When an inline function is not static, then the compiler must
assume that there may be calls from other source files; since
a global symbol can be defined only once in any program, t
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/2885/1/openbsc/src/libbsc/abis_nm.c
File openbsc/src/libbsc/abis_nm.c:
Line 487: if (m_id_len > MAX_BTS_FEATURES/8 + 1) {
You also need to drop this +1, right?
--
To view, visit https://gerrit.osmocom.org/288
Neels Hofmeyr has submitted this change and it was merged.
Change subject: OML: fix potential OOB memory access
..
OML: fix potential OOB memory access
Use sizeof target BTS feature storage to make sure we always fit into
pre-a
Review at https://gerrit.osmocom.org/2896
Update doxygen main page for libosmo{core,gsm,vty}
We should link to project homepage as well as put the library into the
wider Osmocom context.
Change-Id: I07ca57ecef0f36c87c9ebacc1e1507c217bdb25b
---
M src/application.c
M src/gsm/gsm_utils.c
M src/vt
Review at https://gerrit.osmocom.org/2897
update/extend doxygen documentation
It's a pity that even with this patch we still are fare away from having
the whole API documented. However, at least we have a more solid
foundation. Updates not only extend the documentation, but also make
sure it
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2897
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1344bd1a6869fb00de7c1899a8db93bba9bafce3
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2869
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I96477e4125390b17b43a3705bb1daf98fa01c9bb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2871
to look at the new patch set (#3).
uhd: Use map container for for device parameter access
OsmoTRX is written in C++ so we might as well use built-in
container types when a
Patch Set 2: Code-Review-1
(4 comments)
adding stow seems to be really simple. I'm generally in favor, because this
finds errors in our installation targets. Let's resolve the questions though
(marking -1 for that).
Generally it could be helpful to put explanations as a comment in the build
Review at https://gerrit.osmocom.org/2898
sigProcLib: Remove unused functions from public interface
Also remove entirely completely unused calls. Most of these
calls have been around since OpenBTS conception. Nearly a
decade is long enough time for deprecation.
Change-Id: Ifc122aaff23414c363b4
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2896
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07ca57ecef0f36c87c9ebacc1e1507c217bdb25b
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Harald Welte has submitted this change and it was merged.
Change subject: Update doxygen main page for libosmo{core,gsm,vty}
..
Update doxygen main page for libosmo{core,gsm,vty}
We should link to project homepage as well as pu
Harald Welte has submitted this change and it was merged.
Change subject: use tlvp_val16be() rather than manual pointer-cast + ntohs()
..
use tlvp_val16be() rather than manual pointer-cast + ntohs()
Change-Id: Ib77cb703bb1710da
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2875
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib77cb703bb1710da396db3a939700515b5c20235
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: update/extend doxygen documentation
..
update/extend doxygen documentation
It's a pity that even with this patch we still are fare away from having
the w
Patch Set 2:
(9 comments)
https://gerrit.osmocom.org/#/c/2886/2/selftest/log_test.py
File selftest/log_test.py:
Line 89: # some space to keep source line numbers identical to previous code
> This can be dropped right? it may make sense for this review but doesn't lo
it makes sense to justify wh
Review at https://gerrit.osmocom.org/2899
log_test.py: cosmetic follow-up
This is kept separate to not clutter up previous patch
I5f9b53150f2bb6fa9d63ce27f0806f0ca6a45e90.
Change-Id: I0ce50375fdb028da96c2159d577d8ed1967d4fe6
---
M selftest/log_test.ok
M selftest/log_test.py
2 files changed, 15
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2886
to look at the new patch set (#3).
fix and refactor logging: drop 'with', simplify
With the recent fix of the junit report related issues, another issue arose:
the 'wi
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2898
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc122aaff23414c363b4b00f99061eed8a6902d0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit
80 matches
Mail list logo
