osmo-bts[master]: lc15: add jenkins helper

2017-06-20 Thread Neels Hofmeyr
Patch Set 9: -Code-Review > I hate to repeat myself. The jenkins_common.sh belongs in the other > patch. Argh, you explained the ordering earlier which I missed because our discussion was spread across to patches... sorry about that. -- To view, visit https://gerrit.osmocom.org/2891 To unsub

osmo-bts[master]: Move common steps into common jenkins helper

2017-06-20 Thread Neels Hofmeyr
Patch Set 9: > more sense now, but would have helped to indicate this sooner. Argh, you explained the ordering earlier which I missed because our discussion was spread across to patches... sorry about that. -- To view, visit https://gerrit.osmocom.org/2894 To unsubscribe, visit https://gerrit

osmo-bts[master]: Move common steps into common jenkins helper

2017-06-20 Thread Neels Hofmeyr
Patch Set 9: > Because it was already added by the previous commit. Thanks for this comment, I was for some reason assuming that you were removing the code dup first and later adding the lc15 script (in which case the undup script would have been missing). Makes more sense now, but would have

libosmocore[master]: configure.ac: Enable -Wall by default

2017-06-20 Thread Max
Patch Set 4: Shouldn't this be the 1st patch in the series? We enable all the warnings, fix them and than turn any future warning into error, no? -- To view, visit https://gerrit.osmocom.org/2958 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Chan

libosmocore[master]: gsm0808: add function to translate perm speech to speech cod...

2017-06-20 Thread Neels Hofmeyr
Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/2830/7/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: Line 658:* (See also 3GPP TS 48.008, 3.2.2.11 and 3.2.2.103) */ > and again, as I said before, you have to move this up and join with the mai correction: other than with

libosmocore[master]: configure.ac: Enable -Wall by default

2017-06-20 Thread Max
Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2958 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70f917e05ad46049487710d1752aad2505c96696 Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[PATCH] osmo-bts[master]: Use generic L1 headers helper

2017-06-20 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2974 to look at the new patch set (#3). Use generic L1 headers helper Change-Id: I2253df3509595d7393ec6631ef846dbebae73ca4 --- M contrib/jenkins_lc15.sh M contrib/jenkins_oct.sh M contrib/je

libosmocore[master]: timer_gettimeofday.c: Fix implicit use of timeradd

2017-06-20 Thread Vadim Yanitskiy
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2959 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iced451be255cfde8a6cf38380bef71ef29673994 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

osmo-bts[master]: Move common steps into common jenkins helper

2017-06-20 Thread Max
Patch Set 9: > Max, please pay attention! Ironically, that's exactly the comment I wanted to use as a reply for your review. > calling a script that is missing here Because it was already added by the previous commit. > script is instead added in another patch Yes, exactly - just like every

[PATCH] osmo-bts[master]: Use generic L1 headers helper

2017-06-20 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2974 to look at the new patch set (#2). Use generic L1 headers helper Change-Id: I2253df3509595d7393ec6631ef846dbebae73ca4 --- M contrib/jenkins_lc15.sh M contrib/jenkins_oct.sh M contrib/je

[PATCH] osmo-bts[master]: Move common steps into common jenkins helper

2017-06-20 Thread Max
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2894 to look at the new patch set (#9). Move common steps into common jenkins helper Move value_string termination check and OpenBSC headers checkout into shared jenkins helpe

libosmocore[master]: Fix warnings: tolower() and similar require uchar

2017-06-20 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2963 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fed2ab6a4efba9f8a21fcf84a5b3a91e8df084f Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

libosmocore[master]: timer_gettimeofday.c: Fix implicit use of timeradd

2017-06-20 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2959 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iced451be255cfde8a6cf38380bef71ef29673994 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

libosmocore[master]: lapd_test.c: Convert compilation warning to level message

2017-06-20 Thread Max
Patch Set 1: Code-Review+1 Would be nice to also make a ticket and add reference to this ticket into message. -- To view, visit https://gerrit.osmocom.org/2953 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24c11226cd5bb5b6032f4ece7d1a

[PATCH] libosmo-sccp[master]: sccp: add addressbook functionality for sccp addresses

2017-06-20 Thread dexter
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2924 to look at the new patch set (#7). sccp: add addressbook functionality for sccp addresses SCCP addresses are defined through a number of compoinents, not just an IP-Addre

[PATCH] libosmo-sccp[master]: sccp: add addressbook functionality for sccp addresses

2017-06-20 Thread dexter
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2924 to look at the new patch set (#6). sccp: add addressbook functionality for sccp addresses SCCP addresses are defined through a number of compoinents, not just an IP-Addre

libosmocore[master]: gitignore some tests

2017-06-20 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2976 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If85e665d1c2a0b55d23937db5725768cdbf14f58 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

libosmocore[master]: abis_test.c: Fix warning appearing on some buggy gcc versions

2017-06-20 Thread Pau Espin Pedrol
Patch Set 1: I created a new issue in redmine to track this problem so we don't need to fix further related issues. https://osmocom.org/issues/2332 -- To view, visit https://gerrit.osmocom.org/2955 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Ch